diff mbox series

[v5,4/9] build: add Meson files for avf PMD

Message ID 20180918145822.16763-4-bluca@debian.org (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [v5,1/9] build: add Meson file for TAP PMD |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Luca Boccassi Sept. 18, 2018, 2:58 p.m. UTC 
  Signed-off-by: Luca Boccassi <bluca@debian.org>
---
 drivers/net/avf/base/meson.build | 20 ++++++++++++++++++++
 drivers/net/avf/meson.build      | 19 +++++++++++++++++++
 drivers/net/meson.build          |  1 +
 3 files changed, 40 insertions(+)
 create mode 100644 drivers/net/avf/base/meson.build
 create mode 100644 drivers/net/avf/meson.build

Comments

Thomas Monjalon Sept. 18, 2018, 8:48 p.m. UTC | #1 
18/09/2018 16:58, Luca Boccassi:
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
>  drivers/net/avf/base/meson.build | 20 ++++++++++++++++++++
>  drivers/net/avf/meson.build      | 19 +++++++++++++++++++
>  drivers/net/meson.build          |  1 +
>  3 files changed, 40 insertions(+)

I cannot merge this patch because of compilation issues
in the avf driver itself.

I will merge others and keep this one for later.
Bruce Richardson Sept. 19, 2018, 8:31 a.m. UTC | #2 
On Tue, Sep 18, 2018 at 10:48:30PM +0200, Thomas Monjalon wrote:
> 18/09/2018 16:58, Luca Boccassi:
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> >  drivers/net/avf/base/meson.build | 20 ++++++++++++++++++++
> >  drivers/net/avf/meson.build      | 19 +++++++++++++++++++
> >  drivers/net/meson.build          |  1 +
> >  3 files changed, 40 insertions(+)
> 
> I cannot merge this patch because of compilation issues
> in the avf driver itself.
> 
> I will merge others and keep this one for later.
> 
Those should be fixed by patches: http://patches.dpdk.org/project/dpdk/list/?series=1372
Thomas Monjalon Sept. 19, 2018, 8:42 a.m. UTC | #3 
19/09/2018 10:31, Bruce Richardson:
> On Tue, Sep 18, 2018 at 10:48:30PM +0200, Thomas Monjalon wrote:
> > 18/09/2018 16:58, Luca Boccassi:
> > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > ---
> > >  drivers/net/avf/base/meson.build | 20 ++++++++++++++++++++
> > >  drivers/net/avf/meson.build      | 19 +++++++++++++++++++
> > >  drivers/net/meson.build          |  1 +
> > >  3 files changed, 40 insertions(+)
> > 
> > I cannot merge this patch because of compilation issues
> > in the avf driver itself.
> > 
> > I will merge others and keep this one for later.
> > 
> Those should be fixed by patches: http://patches.dpdk.org/project/dpdk/list/?series=1372

Yes, waiting for them to be merged in next-net-intel and next-net.
Bruce Richardson Sept. 19, 2018, 9:45 a.m. UTC | #4 
On Wed, Sep 19, 2018 at 10:42:50AM +0200, Thomas Monjalon wrote:
> 19/09/2018 10:31, Bruce Richardson:
> > On Tue, Sep 18, 2018 at 10:48:30PM +0200, Thomas Monjalon wrote:
> > > 18/09/2018 16:58, Luca Boccassi:
> > > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > > ---
> > > >  drivers/net/avf/base/meson.build | 20 ++++++++++++++++++++
> > > >  drivers/net/avf/meson.build      | 19 +++++++++++++++++++
> > > >  drivers/net/meson.build          |  1 +
> > > >  3 files changed, 40 insertions(+)
> > > 
> > > I cannot merge this patch because of compilation issues
> > > in the avf driver itself.
> > > 
> > > I will merge others and keep this one for later.
> > > 
> > Those should be fixed by patches: http://patches.dpdk.org/project/dpdk/list/?series=1372
> 
> Yes, waiting for them to be merged in next-net-intel and next-net.
> 
To ease tracking, I'll do a v4 of the above set and include this patch in
that as a third patch. That way, we'll avoid synchronisation between the
trees.

/Bruce
Bruce Richardson Sept. 19, 2018, 10:08 a.m. UTC | #5 
On Wed, Sep 19, 2018 at 10:45:31AM +0100, Bruce Richardson wrote:
> On Wed, Sep 19, 2018 at 10:42:50AM +0200, Thomas Monjalon wrote:
> > 19/09/2018 10:31, Bruce Richardson:
> > > On Tue, Sep 18, 2018 at 10:48:30PM +0200, Thomas Monjalon wrote:
> > > > 18/09/2018 16:58, Luca Boccassi:
> > > > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > > > ---
> > > > >  drivers/net/avf/base/meson.build | 20 ++++++++++++++++++++
> > > > >  drivers/net/avf/meson.build      | 19 +++++++++++++++++++
> > > > >  drivers/net/meson.build          |  1 +
> > > > >  3 files changed, 40 insertions(+)
> > > > 
> > > > I cannot merge this patch because of compilation issues
> > > > in the avf driver itself.
> > > > 
> > > > I will merge others and keep this one for later.
> > > > 
> > > Those should be fixed by patches: http://patches.dpdk.org/project/dpdk/list/?series=1372
> > 
> > Yes, waiting for them to be merged in next-net-intel and next-net.
> > 
> To ease tracking, I'll do a v4 of the above set and include this patch in
> that as a third patch. That way, we'll avoid synchronisation between the
> trees.
> 
> /Bruce

Now superceded by: http://patches.dpdk.org/patch/44908/ from set:
http://patches.dpdk.org/project/dpdk/list/?series=1386

/Bruce
Luca Boccassi Sept. 19, 2018, 10:15 a.m. UTC | #6 
On Wed, 2018-09-19 at 11:08 +0100, Bruce Richardson wrote:
> On Wed, Sep 19, 2018 at 10:45:31AM +0100, Bruce Richardson wrote:
> > On Wed, Sep 19, 2018 at 10:42:50AM +0200, Thomas Monjalon wrote:
> > > 19/09/2018 10:31, Bruce Richardson:
> > > > On Tue, Sep 18, 2018 at 10:48:30PM +0200, Thomas Monjalon
> > > > wrote:
> > > > > 18/09/2018 16:58, Luca Boccassi:
> > > > > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > > > > ---
> > > > > >  drivers/net/avf/base/meson.build | 20 ++++++++++++++++++++
> > > > > >  drivers/net/avf/meson.build      | 19 +++++++++++++++++++
> > > > > >  drivers/net/meson.build          |  1 +
> > > > > >  3 files changed, 40 insertions(+)
> > > > > 
> > > > > I cannot merge this patch because of compilation issues
> > > > > in the avf driver itself.
> > > > > 
> > > > > I will merge others and keep this one for later.
> > > > > 
> > > > 
> > > > Those should be fixed by patches: http://patches.dpdk.org/proje
> > > > ct/dpdk/list/?series=1372
> > > 
> > > Yes, waiting for them to be merged in next-net-intel and next-
> > > net.
> > > 
> > 
> > To ease tracking, I'll do a v4 of the above set and include this
> > patch in
> > that as a third patch. That way, we'll avoid synchronisation
> > between the
> > trees.
> > 
> > /Bruce
> 
> Now superceded by: http://patches.dpdk.org/patch/44908/ from set:
> http://patches.dpdk.org/project/dpdk/list/?series=1386
> 
> /Bruce

Great, thanks
diff mbox series

Patch

diff --git a/drivers/net/avf/base/meson.build b/drivers/net/avf/base/meson.build
new file mode 100644
index 0000000000..90fd6b445f
--- /dev/null
+++ b/drivers/net/avf/base/meson.build
@@ -0,0 +1,20 @@ 
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi <bluca@debian.org>
+
+sources = [
+	'avf_adminq.c',
+	'avf_common.c',
+]
+
+error_cflags = ['-Wno-pointer-to-int-cast']
+c_args = cflags
+foreach flag: error_cflags
+	if cc.has_argument(flag)
+		c_args += flag
+	endif
+endforeach
+
+base_lib = static_library('avf_base', sources,
+	dependencies: static_rte_eal,
+	c_args: c_args)
+base_objs = base_lib.extract_all_objects()
diff --git a/drivers/net/avf/meson.build b/drivers/net/avf/meson.build
new file mode 100644
index 0000000000..b5ad9cc673
--- /dev/null
+++ b/drivers/net/avf/meson.build
@@ -0,0 +1,19 @@ 
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi <bluca@debian.org>
+
+cflags += ['-Wno-strict-aliasing']
+
+subdir('base')
+objs = [base_objs]
+
+sources = files(
+	'avf_ethdev.c',
+	'avf_rxtx.c',
+	'avf_rxtx_vec_sse.c',
+	'avf_vchnl.c',
+)
+
+if arch_subdir == 'x86'
+	dpdk_conf.set('RTE_LIBRTE_AVF_INC_VECTOR', 1)
+	sources += files('avf_rxtx_vec_sse.c')
+endif
diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index 68ac42d67c..28efeda0b6 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -3,6 +3,7 @@ 
 
 drivers = ['af_packet',
 	'ark',
+	'avf',
 	'avp',
 	'axgbe', 'bonding',
 	'bnx2x',