Message ID | 1533833430-29134-1-git-send-email-fiona.trahe@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DB1F23421; Thu, 9 Aug 2018 18:50:37 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A1CFE2BC1 for <dev@dpdk.org>; Thu, 9 Aug 2018 18:50:36 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Aug 2018 09:50:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,215,1531810800"; d="scan'208";a="71528922" Received: from sivswdev01.ir.intel.com (HELO localhost.localdomain) ([10.237.217.45]) by FMSMGA003.fm.intel.com with ESMTP; 09 Aug 2018 09:50:33 -0700 From: Fiona Trahe <fiona.trahe@intel.com> To: dev@dpdk.org, pablo.de.lara.guarch@intel.com, tomaszx.jozwiak@intel.com Cc: fiona.trahe@intel.com Date: Thu, 9 Aug 2018 17:50:22 +0100 Message-Id: <1533833430-29134-1-git-send-email-fiona.trahe@intel.com> X-Mailer: git-send-email 1.7.0.7 In-Reply-To: <1533820674-9507-1-git-send-email-fiona.trahe@intel.com> References: <1533820674-9507-1-git-send-email-fiona.trahe@intel.com> Subject: [dpdk-dev] [PATCH v2 0/8] doc/qat: clarify build config options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
doc/qat: clarify build config options
|
|
Message
Fiona Trahe
Aug. 9, 2018, 4:50 p.m. UTC
Clarified documentation structure between compressedev, cryptodev and common build parts. Clarified build configuration options. Added Testing section. Fixed typos and made some cosmetic improvements. v2 changes - split into patchset - changed test path from build/build/test/test to build/app - use make defconfig instead of make config T=xxx - matched underline lengths to titles Fiona Trahe (8): doc/qat: add limitations to compressdev PMD doc/qat: add information on how to test doc/qat: fix typos and make cosmetic changes doc/qat: add overview of doc sections doc/qat: remove unnecessary text doc/qat: update kernel dependency section doc/qat: update PMD build section doc/qat: describe build config options doc/guides/compressdevs/qat_comp.rst | 6 +- doc/guides/cryptodevs/qat.rst | 197 ++++++++++++++++++++++++----------- 2 files changed, 141 insertions(+), 62 deletions(-)
Comments
> -----Original Message----- > From: Trahe, Fiona > Sent: Thursday, August 9, 2018 5:50 PM > To: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; > Jozwiak, TomaszX <tomaszx.jozwiak@intel.com> > Cc: Trahe, Fiona <fiona.trahe@intel.com> > Subject: [PATCH v2 0/8] doc/qat: clarify build config options > > Clarified documentation structure between compressedev, cryptodev and > common build parts. > Clarified build configuration options. > Added Testing section. > Fixed typos and made some cosmetic improvements. > > v2 changes > - split into patchset > - changed test path from build/build/test/test to build/app > - use make defconfig instead of make config T=xxx > - matched underline lengths to titles > > Fiona Trahe (8): > doc/qat: add limitations to compressdev PMD > doc/qat: add information on how to test > doc/qat: fix typos and make cosmetic changes > doc/qat: add overview of doc sections > doc/qat: remove unnecessary text > doc/qat: update kernel dependency section > doc/qat: update PMD build section > doc/qat: describe build config options > > doc/guides/compressdevs/qat_comp.rst | 6 +- > doc/guides/cryptodevs/qat.rst | 197 ++++++++++++++++++++++++----------- > 2 files changed, 141 insertions(+), 62 deletions(-) > > -- > 2.13.6 Nice splitting :) Just a note on patch 8, which shows as [Patch v2] doc/qat: describe build config options. Apart from that: Series-acked-by: Pablo de Lara <Pablo.de.lara.guarch@intel.com>
09/08/2018 18:50, Fiona Trahe: > Clarified documentation structure between > compressedev, cryptodev and common build parts. > Clarified build configuration options. > Added Testing section. > Fixed typos and made some cosmetic improvements. > > v2 changes > - split into patchset I am not sure about the split. Usually, when there is no text in the commit log, it is a tip that it is not worth to be a separate commit. Perhaps, it is good to have this split, but in this case, please try to explain the purpose (or reason) of each patch in the commit logs. Thanks
Hi Thomas > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, August 9, 2018 8:49 PM > To: Trahe, Fiona <fiona.trahe@intel.com> > Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Jozwiak, TomaszX > <tomaszx.jozwiak@intel.com> > Subject: Re: [dpdk-dev] [PATCH v2 0/8] doc/qat: clarify build config options > > 09/08/2018 18:50, Fiona Trahe: > > Clarified documentation structure between > > compressedev, cryptodev and common build parts. > > Clarified build configuration options. > > Added Testing section. > > Fixed typos and made some cosmetic improvements. > > > > v2 changes > > - split into patchset > > I am not sure about the split. > Usually, when there is no text in the commit log, > it is a tip that it is not worth to be a separate commit. > Perhaps, it is good to have this split, but in this case, > please try to explain the purpose (or reason) of each patch in the commit logs. > > Thanks > With over 200 changed lines in the v1 patch I did this to make it easier for Pablo to review. I'll add more explanation in the v3.