[1/2] rawdev: fix missing queue count API
Checks
Commit Message
Rawdev queue count API prototype was declared, but the definition was
missing from the library. This patch implements the function.
This API is used to query the device about the count of queues it has
been configured with.
Fixes: c88b3f2558ed ("rawdev: introduce raw device library")
Cc: shreyansh.jain@nxp.com
Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
Suggested-by: Keith Wiles <keith.wiles@intel.com>
---
lib/librte_rawdev/rte_rawdev.c | 12 ++++++++++++
lib/librte_rawdev/rte_rawdev.h | 1 +
lib/librte_rawdev/rte_rawdev_pmd.h | 20 ++++++++++++++++++++
lib/librte_rawdev/rte_rawdev_version.map | 1 +
4 files changed, 34 insertions(+)
Comments
> On Jul 31, 2018, at 5:33 AM, Shreyansh Jain <shreyansh.jain@nxp.com> wrote:
>
> Rawdev queue count API prototype was declared, but the definition was
> missing from the library. This patch implements the function.
>
> This API is used to query the device about the count of queues it has
> been configured with.
>
> Fixes: c88b3f2558ed ("rawdev: introduce raw device library")
> Cc: shreyansh.jain@nxp.com
>
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> Suggested-by: Keith Wiles <keith.wiles@intel.com>
> ---
> lib/librte_rawdev/rte_rawdev.c | 12 ++++++++++++
> lib/librte_rawdev/rte_rawdev.h | 1 +
> lib/librte_rawdev/rte_rawdev_pmd.h | 20 ++++++++++++++++++++
> lib/librte_rawdev/rte_rawdev_version.map | 1 +
> 4 files changed, 34 insertions(+)
>
Acked-by Keith Wiles<keith.wiles@intel.com>
Regards,
Keith
@@ -172,6 +172,18 @@ rte_rawdev_queue_release(uint16_t dev_id, uint16_t queue_id)
return (*dev->dev_ops->queue_release)(dev, queue_id);
}
+uint16_t
+rte_rawdev_queue_count(uint16_t dev_id)
+{
+ struct rte_rawdev *dev;
+
+ RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);
+ dev = &rte_rawdevs[dev_id];
+
+ RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->queue_count, -ENOTSUP);
+ return (*dev->dev_ops->queue_count)(dev);
+}
+
int
rte_rawdev_get_attr(uint16_t dev_id,
const char *attr_name,
@@ -182,6 +182,7 @@ rte_rawdev_queue_setup(uint16_t dev_id,
*/
int
rte_rawdev_queue_release(uint16_t dev_id, uint16_t queue_id);
+
/**
* Get the number of raw queues on a specific raw device
*
@@ -250,6 +250,24 @@ typedef int (*rawdev_queue_setup_t)(struct rte_rawdev *dev,
typedef int (*rawdev_queue_release_t)(struct rte_rawdev *dev,
uint16_t queue_id);
+/**
+ * Get the count of number of queues configured on this device.
+ *
+ * Another way to fetch this information is to fetch the device configuration.
+ * But, that assumes that the device configuration managed by the driver has
+ * that kind of information.
+ *
+ * This function helps in getting queue count supported, independently. It
+ * can help in cases where iterator needs to be implemented.
+ *
+ * @param
+ * Raw device pointer
+ * @return
+ * Number of queues; 0 is assumed to be a valid response.
+ *
+ */
+typedef uint16_t (*rawdev_queue_count_t)(struct rte_rawdev *dev);
+
/**
* Enqueue an array of raw buffers to the device.
*
@@ -506,6 +524,8 @@ struct rte_rawdev_ops {
rawdev_queue_setup_t queue_setup;
/**< Release an raw queue. */
rawdev_queue_release_t queue_release;
+ /**< Get the number of queues attached to the device */
+ rawdev_queue_count_t queue_count;
/**< Enqueue an array of raw buffers to device. */
rawdev_enqueue_bufs_t enqueue_bufs;
@@ -16,6 +16,7 @@ DPDK_18.08 {
rte_rawdev_pmd_allocate;
rte_rawdev_pmd_release;
rte_rawdev_queue_conf_get;
+ rte_rawdev_queue_count;
rte_rawdev_queue_setup;
rte_rawdev_queue_release;
rte_rawdev_reset;