[v10,0/5] add unit tests for bitrate, latency and pdump libraries

  From: Reshma Pattan <reshma.pattan@intel.com>

1/5: add helper functions for tests using ring-PMD Rx/Tx
2/5: unit test cases added for bitrate library
3/5: unit test cases added for latencystats library
4/5: unit test cases added for pdump library
5/5: added new unit tests to autotest list

Patches 2/5,3/5 depends on 1/5
Patch 4/5 depends on 1/5 and the below patch http://patches.dpdk.org/patch/43354/

Signed-off-by: Naga Suresh Somarowthu <naga.sureshx.somarowthu@intel.com>
Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
Reviewed-by: Remy Horton <remy.horton@intel.com>
Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: Reshma Pattan <reshma.pattan@intel.com>

---
v10: fixed clang compiler issues and freed latency stats memzone in latency
stats unit tests.
v9: rebased ontop of latest autotest changes and added new tests to the autotest list
v8: renamed commit headline and freed the metrics memzone for bitrate ut
v7: removed unused macros and corrected the comment
v6: updated ring variable appropriately
v5: rebased, freed pools and rings, created common patch set
---

Naga Suresh Somarowthu (4):
  test: add helper functions for tests using ring-PMD Rx/Tx
  test: add unit tests for bitrate library
  test: add unit tests for latencystats library
  test: add unit test for pdump library

Reshma Pattan (1):
  autotest: add new unit tests to autotest list

 test/test/Makefile                |   9 ++
 test/test/autotest_data.py        |  18 +++
 test/test/process.h               |  12 ++
 test/test/sample_packet_forward.c | 115 +++++++++++++++++++
 test/test/sample_packet_forward.h |  40 +++++++
 test/test/test.c                  |   2 +
 test/test/test_bitratestats.c     | 229 +++++++++++++++++++++++++++++++++++++
 test/test/test_latencystats.c     | 229 +++++++++++++++++++++++++++++++++++++
 test/test/test_pdump.c            | 232 ++++++++++++++++++++++++++++++++++++++
 test/test/test_pdump.h            |  31 +++++
 10 files changed, 917 insertions(+)
 create mode 100644 test/test/sample_packet_forward.c
 create mode 100644 test/test/sample_packet_forward.h
 create mode 100644 test/test/test_bitratestats.c
 create mode 100644 test/test/test_latencystats.c
 create mode 100644 test/test/test_pdump.c
 create mode 100644 test/test/test_pdump.h
  

Hi Reshma,

01/08/2018 00:18, Reshma Pattan:
> v10: fixed clang compiler issues and freed latency stats memzone in latency
> stats unit tests.
> v9: rebased ontop of latest autotest changes and added new tests to the autotest list
> v8: renamed commit headline and freed the metrics memzone for bitrate ut
> v7: removed unused macros and corrected the comment
> v6: updated ring variable appropriately
> v5: rebased, freed pools and rings, created common patch set

Please use --in-reply-to as explained in the contributing guide,
in order to get all the versions in the same thread.
  

01/08/2018 00:18, Reshma Pattan:
> v10: fixed clang compiler issues and freed latency stats memzone in latency
> stats unit tests.
> v9: rebased ontop of latest autotest changes and added new tests to the autotest list
> v8: renamed commit headline and freed the metrics memzone for bitrate ut
> v7: removed unused macros and corrected the comment
> v6: updated ring variable appropriately
> v5: rebased, freed pools and rings, created common patch set
> ---

Sorry, the integration of this patchset is very painful.

After asking for rebase, for clang fix, there are still some basic errors
with 32-bit compilation:

	test_latencystats.c:131:21: error:
	format ‘%ld’ expects argument of type ‘long int’,
	but argument 2 has type ‘uint64_t’ {aka ‘long long unsigned int’}

linkage:

	test@test@@dpdk-test@exe/test.c.o:(.data+0x18): undefined reference to `test_pdump'

or even MAINTAINERS file:

	test/test/sample_packet_forward.c
	test/test/sample_packet_forward.h
	test/test/test_bitratestats.c
	test/test/test_latencystats.c

I have already spent too much time on it, despite it is not fixing 18.08.

Please do a complete detailed review of this series,
so it can be considered for 18.11.
  

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, August 1, 2018 8:52 AM
> To: Pattan, Reshma <reshma.pattan@intel.com>
> Cc: dev@dpdk.org; Burakov, Anatoly <anatoly.burakov@intel.com>;
> Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com>;
> Somarowthu, Naga SureshX <naga.sureshx.somarowthu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v10 0/5] add unit tests for bitrate, latency and
> pdump libraries
> 
> 01/08/2018 00:18, Reshma Pattan:
> > v10: fixed clang compiler issues and freed latency stats memzone in
> > latency stats unit tests.
> > v9: rebased ontop of latest autotest changes and added new tests to
> > the autotest list
> > v8: renamed commit headline and freed the metrics memzone for bitrate
> > ut
> > v7: removed unused macros and corrected the comment
> > v6: updated ring variable appropriately
> > v5: rebased, freed pools and rings, created common patch set
> > ---
> 
> Sorry, the integration of this patchset is very painful.
> 
> After asking for rebase, for clang fix, there are still some basic errors with 32-
> bit compilation:
> 
> 	test_latencystats.c:131:21: error:
> 	format ‘%ld’ expects argument of type ‘long int’,
> 	but argument 2 has type ‘uint64_t’ {aka ‘long long unsigned int’}
> 
> linkage:
> 
> 	test@test@@dpdk-test@exe/test.c.o:(.data+0x18): undefined
> reference to `test_pdump'
> 
> or even MAINTAINERS file:
> 
> 	test/test/sample_packet_forward.c
> 	test/test/sample_packet_forward.h
> 	test/test/test_bitratestats.c
> 	test/test/test_latencystats.c
> 
> I have already spent too much time on it, despite it is not fixing 18.08.
> 
> Please do a complete detailed review of this series, so it can be considered for
> 18.11.
> 

We missed to do these basic checks, apologies for consuming your time.
 Naga Suresh has now proactively worked on fixing these issues and running pre checks on patches and addressed in v12.
The earlier versions were reviewed by me, Remy and Anatoly . So we request you to consider latest patches for 18.08,
until unless they don’t give any last minute  surprises.

Thanks,
Reshma
  

03/08/2018 15:45, Pattan, Reshma:
> Hi Thomas,
> 
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, August 1, 2018 8:52 AM
> > 
> > 01/08/2018 00:18, Reshma Pattan:
> > > v10: fixed clang compiler issues and freed latency stats memzone in
> > > latency stats unit tests.
> > > v9: rebased ontop of latest autotest changes and added new tests to
> > > the autotest list
> > > v8: renamed commit headline and freed the metrics memzone for bitrate
> > > ut
> > > v7: removed unused macros and corrected the comment
> > > v6: updated ring variable appropriately
> > > v5: rebased, freed pools and rings, created common patch set
> > > ---
> > 
> > Sorry, the integration of this patchset is very painful.
> > 
> > After asking for rebase, for clang fix, there are still some basic errors with 32-
> > bit compilation:
> > 
> > 	test_latencystats.c:131:21: error:
> > 	format ‘%ld’ expects argument of type ‘long int’,
> > 	but argument 2 has type ‘uint64_t’ {aka ‘long long unsigned int’}
> > 
> > linkage:
> > 
> > 	test@test@@dpdk-test@exe/test.c.o:(.data+0x18): undefined
> > reference to `test_pdump'
> > 
> > or even MAINTAINERS file:
> > 
> > 	test/test/sample_packet_forward.c
> > 	test/test/sample_packet_forward.h
> > 	test/test/test_bitratestats.c
> > 	test/test/test_latencystats.c
> > 
> > I have already spent too much time on it, despite it is not fixing 18.08.
> > 
> > Please do a complete detailed review of this series, so it can be considered for
> > 18.11.
> > 
> 
> We missed to do these basic checks, apologies for consuming your time.
>  Naga Suresh has now proactively worked on fixing these issues and running pre checks on patches and addressed in v12.
> The earlier versions were reviewed by me, Remy and Anatoly . So we request you to consider latest patches for 18.08,
> until unless they don’t give any last minute  surprises.

Sorry, I consider it is now too late for such patch in 18.08.
It is not fixing any issue.

Last days of 18.08 cycle will be really focus on bugs and doc.
  

Hi Thomas,

>-----Original Message-----
>From: Pattan, Reshma
>Sent: Friday, August 03, 2018 7:15 PM
>To: Thomas Monjalon <thomas@monjalon.net>; Somarowthu, Naga SureshX
><naga.sureshx.somarowthu@intel.com>
>Cc: dev@dpdk.org; Burakov, Anatoly <anatoly.burakov@intel.com>;
>Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com>
>Subject: RE: [dpdk-dev] [PATCH v10 0/5] add unit tests for bitrate, latency and
>pdump libraries
>
>Hi Thomas,
>
>> -----Original Message-----
>> From: Thomas Monjalon [mailto:thomas@monjalon.net]
>> Sent: Wednesday, August 1, 2018 8:52 AM
>> To: Pattan, Reshma <reshma.pattan@intel.com>
>> Cc: dev@dpdk.org; Burakov, Anatoly <anatoly.burakov@intel.com>;
>> Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com>;
>> Somarowthu, Naga SureshX <naga.sureshx.somarowthu@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH v10 0/5] add unit tests for bitrate,
>> latency and pdump libraries
>>
>> 01/08/2018 00:18, Reshma Pattan:
>> > v10: fixed clang compiler issues and freed latency stats memzone in
>> > latency stats unit tests.
>> > v9: rebased ontop of latest autotest changes and added new tests to
>> > the autotest list
>> > v8: renamed commit headline and freed the metrics memzone for
>> > bitrate ut
>> > v7: removed unused macros and corrected the comment
>> > v6: updated ring variable appropriately
>> > v5: rebased, freed pools and rings, created common patch set
>> > ---
>>
>> Sorry, the integration of this patchset is very painful.
>>
>> After asking for rebase, for clang fix, there are still some basic
>> errors with 32- bit compilation:
>>
>> 	test_latencystats.c:131:21: error:
>> 	format ‘%ld’ expects argument of type ‘long int’,
>> 	but argument 2 has type ‘uint64_t’ {aka ‘long long unsigned int’}
>>
>> linkage:
>>
>> 	test@test@@dpdk-test@exe/test.c.o:(.data+0x18): undefined
>reference
>> to `test_pdump'
>>
>> or even MAINTAINERS file:
>>
>> 	test/test/sample_packet_forward.c
>> 	test/test/sample_packet_forward.h
>> 	test/test/test_bitratestats.c
>> 	test/test/test_latencystats.c
>>
>> I have already spent too much time on it, despite it is not fixing 18.08.
>>
>> Please do a complete detailed review of this series, so it can be
>> considered for 18.11.
>>
>
>We missed to do these basic checks, apologies for consuming your time.
> Naga Suresh has now proactively worked on fixing these issues and running
>pre checks on patches and addressed in v12.
>The earlier versions were reviewed by me, Remy and Anatoly . So we request
>you to consider latest patches for 18.08, until unless they don’t give any last
>minute  surprises.
>
>Thanks,
>Reshma
>
>
>
Apologies very much to miss the earlier patch pre-checks.
We have gone through the cheatsheet and validated pre-checks in the patch v12.
Compiled Successfully in Fedora 27, Fedora 26, CentOS 7.2, CentOS 7.4, Ubuntu for both 32bit/64bit and FreeBSD (64bit)
Build using compilers gcc, icc, clang were successful in Fedora.
Shared Library builds were successful in Fedora 27, CentOS 7.2 and Ubuntu

Executed checkpatch, check-git-log without any errors.
Code changes were acknowledged by reviewers.

Request to please consider the patch set v12 to be included in RC3 18.08.

In case of any info/change please let us know.

Thanks for your support.
M.P.Jananee
--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.
  

03/08/2018 16:16, Parthasarathy, JananeeX M:
> Hi Thomas,
> 
> From: Pattan, Reshma
> >
> >Hi Thomas,
> >
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> >> 01/08/2018 00:18, Reshma Pattan:
> >> > v10: fixed clang compiler issues and freed latency stats memzone in
> >> > latency stats unit tests.
> >> > v9: rebased ontop of latest autotest changes and added new tests to
> >> > the autotest list
> >> > v8: renamed commit headline and freed the metrics memzone for
> >> > bitrate ut
> >> > v7: removed unused macros and corrected the comment
> >> > v6: updated ring variable appropriately
> >> > v5: rebased, freed pools and rings, created common patch set
> >> > ---
> >>
> >> Sorry, the integration of this patchset is very painful.
> >>
> >> After asking for rebase, for clang fix, there are still some basic
> >> errors with 32- bit compilation:
> >>
> >> 	test_latencystats.c:131:21: error:
> >> 	format ‘%ld’ expects argument of type ‘long int’,
> >> 	but argument 2 has type ‘uint64_t’ {aka ‘long long unsigned int’}
> >>
> >> linkage:
> >>
> >> 	test@test@@dpdk-test@exe/test.c.o:(.data+0x18): undefined
> >reference
> >> to `test_pdump'
> >>
> >> or even MAINTAINERS file:
> >>
> >> 	test/test/sample_packet_forward.c
> >> 	test/test/sample_packet_forward.h
> >> 	test/test/test_bitratestats.c
> >> 	test/test/test_latencystats.c
> >>
> >> I have already spent too much time on it, despite it is not fixing 18.08.
> >>
> >> Please do a complete detailed review of this series, so it can be
> >> considered for 18.11.
> >>
> >
> >We missed to do these basic checks, apologies for consuming your time.
> > Naga Suresh has now proactively worked on fixing these issues and running
> >pre checks on patches and addressed in v12.
> >The earlier versions were reviewed by me, Remy and Anatoly . So we request
> >you to consider latest patches for 18.08, until unless they don’t give any last
> >minute  surprises.
> >
> >Thanks,
> >Reshma
> >
> >
> >
> Apologies very much to miss the earlier patch pre-checks.
> We have gone through the cheatsheet and validated pre-checks in the patch v12.
> Compiled Successfully in Fedora 27, Fedora 26, CentOS 7.2, CentOS 7.4, Ubuntu for both 32bit/64bit and FreeBSD (64bit)
> Build using compilers gcc, icc, clang were successful in Fedora.
> Shared Library builds were successful in Fedora 27, CentOS 7.2 and Ubuntu
> 
> Executed checkpatch, check-git-log without any errors.
> Code changes were acknowledged by reviewers.
> 
> Request to please consider the patch set v12 to be included in RC3 18.08.
> 
> In case of any info/change please let us know.

Why are you insisting so much?
I have already replied to Reshma that it is too late and not urgent:
	http://mails.dpdk.org/archives/dev/2018-August/109352.html

Please do not make it even more difficult.
I just do not want to spend more time on this series now.

When I will take time, I will do a better review, and I can promise
that I will have some comments.
So please consider my earlier comment to avoid burning too much time:
	"Please do a complete detailed review of this series"

After a quick look, I already see some suspicious includes, linkage,
and last 2 patches should be integrated with others.

To make it clear, the quality was not good and I already burnt too much time.
I won't spend more time on it during August.