Message ID | 1531843225-14638-1-git-send-email-reshma.pattan@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C690D2B92; Tue, 17 Jul 2018 18:00:30 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id B61B92965 for <dev@dpdk.org>; Tue, 17 Jul 2018 18:00:28 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2018 09:00:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,366,1526367600"; d="scan'208";a="55694063" Received: from sivswdev02.ir.intel.com (HELO localhost.localdomain) ([10.237.217.46]) by fmsmga008.fm.intel.com with ESMTP; 17 Jul 2018 09:00:26 -0700 From: Reshma Pattan <reshma.pattan@intel.com> To: thomas@monjalon.net, dev@dpdk.org Cc: anatoly.burakov@intel.com, jananeex.m.parthasarathy@intel.com Date: Tue, 17 Jul 2018 17:00:15 +0100 Message-Id: <1531843225-14638-1-git-send-email-reshma.pattan@intel.com> X-Mailer: git-send-email 1.7.0.7 Subject: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
Make unit tests great again
|
|
Message
Pattan, Reshma
July 17, 2018, 4 p.m. UTC
Previously, unit tests were running in groups. There were technical reasons why that was the case (mostly having to do with limiting memory), but it was hard to maintain and update the autotest script. In 18.05, limiting of memory at DPDK startup was no longer necessary, as DPDK allocates memory at runtime as needed. This has the implication that the old test grouping can now be retired and replaced with a more sensible way of running unit tests (using multiprocessing pool of workers and a queue of tests). This patchset accomplishes exactly that. This patchset merges changes done in [1], [2] [1] http://dpdk.org/dev/patchwork/patch/40370/ [2] http://patches.dpdk.org/patch/40373/ Removed unused and duplicate make rules for test-basic, test-mempool, test-ring from make file system in patch 10/10. v4: Removed unused and duplicate make rules for test-basic, test-mempool, test-ring from make file system in patch 10/10. Reshma Pattan (10): autotest: fix printing autotest: fix invalid code on reports autotest: make autotest runner python 2/3 compliant autotest: visually separate different test categories autotest: improve filtering autotest: remove autotest grouping autotest: properly parallelize unit tests autotest: update autotest test case list mk: update make targets for classified testcases mk: remove unnecessary make rules of test mk/rte.sdkroot.mk | 4 +- mk/rte.sdktest.mk | 32 +- test/test/autotest.py | 13 +- test/test/autotest_data.py | 1081 +++++++++++++++++++++++++----------------- test/test/autotest_runner.py | 519 ++++++++++---------- 5 files changed, 947 insertions(+), 702 deletions(-)
Comments
17/07/2018 18:00, Reshma Pattan: > Previously, unit tests were running in groups. There were technical reasons why that was the case (mostly having to do with limiting memory), but it was hard to maintain and update the autotest script. > > In 18.05, limiting of memory at DPDK startup was no longer necessary, as DPDK allocates memory at runtime as needed. This has the implication that the old test grouping can now be retired and replaced with a more sensible way of running unit tests (using multiprocessing pool of workers and a queue of tests). This patchset accomplishes exactly that. > > This patchset merges changes done in [1], [2] > > [1] http://dpdk.org/dev/patchwork/patch/40370/ > [2] http://patches.dpdk.org/patch/40373/ > > Removed unused and duplicate make rules for test-basic, > test-mempool, test-ring from make file system in patch 10/10. > > v4: Removed unused and duplicate make rules for test-basic, > test-mempool, test-ring from make file system in patch 10/10. > > Reshma Pattan (10): > autotest: fix printing > autotest: fix invalid code on reports > autotest: make autotest runner python 2/3 compliant > autotest: visually separate different test categories > autotest: improve filtering > autotest: remove autotest grouping > autotest: properly parallelize unit tests > autotest: update autotest test case list > mk: update make targets for classified testcases > mk: remove unnecessary make rules of test Patches 1 to 7 are from Anatoly. Patches 8 and 9 were initiated by Jananee. Please fix authorship of these patches. Note: it should not happen if you use git-am to get the patches.
Hi, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, July 26, 2018 9:05 PM > To: Pattan, Reshma <reshma.pattan@intel.com> > Cc: dev@dpdk.org; Burakov, Anatoly <anatoly.burakov@intel.com>; > Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com> > Subject: Re: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again > > 17/07/2018 18:00, Reshma Pattan: > > Previously, unit tests were running in groups. There were technical reasons > why that was the case (mostly having to do with limiting memory), but it was > hard to maintain and update the autotest script. > > > > In 18.05, limiting of memory at DPDK startup was no longer necessary, as > DPDK allocates memory at runtime as needed. This has the implication that > the old test grouping can now be retired and replaced with a more sensible > way of running unit tests (using multiprocessing pool of workers and a queue > of tests). This patchset accomplishes exactly that. > > > > This patchset merges changes done in [1], [2] > > > > [1] http://dpdk.org/dev/patchwork/patch/40370/ > > [2] http://patches.dpdk.org/patch/40373/ > > > > Removed unused and duplicate make rules for test-basic, test-mempool, > > test-ring from make file system in patch 10/10. > > > > v4: Removed unused and duplicate make rules for test-basic, > > test-mempool, test-ring from make file system in patch 10/10. > > > > Reshma Pattan (10): > > autotest: fix printing > > autotest: fix invalid code on reports > > autotest: make autotest runner python 2/3 compliant > > autotest: visually separate different test categories > > autotest: improve filtering > > autotest: remove autotest grouping > > autotest: properly parallelize unit tests > > autotest: update autotest test case list > > mk: update make targets for classified testcases > > mk: remove unnecessary make rules of test > > Patches 1 to 7 are from Anatoly. > Patches 8 and 9 were initiated by Jananee. The respective patches have i.e 1 to 7 have Anatolys Signed--off And 8 and 9 have Jananees Signed-off along with mine. I have used git-am. What I am missing here? Thanks, Reshma
On 27-Jul-18 9:36 AM, Pattan, Reshma wrote: > Hi, > >> -----Original Message----- >> From: Thomas Monjalon [mailto:thomas@monjalon.net] >> Sent: Thursday, July 26, 2018 9:05 PM >> To: Pattan, Reshma <reshma.pattan@intel.com> >> Cc: dev@dpdk.org; Burakov, Anatoly <anatoly.burakov@intel.com>; >> Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com> >> Subject: Re: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again >> >> 17/07/2018 18:00, Reshma Pattan: >>> Previously, unit tests were running in groups. There were technical reasons >> why that was the case (mostly having to do with limiting memory), but it was >> hard to maintain and update the autotest script. >>> >>> In 18.05, limiting of memory at DPDK startup was no longer necessary, as >> DPDK allocates memory at runtime as needed. This has the implication that >> the old test grouping can now be retired and replaced with a more sensible >> way of running unit tests (using multiprocessing pool of workers and a queue >> of tests). This patchset accomplishes exactly that. >>> >>> This patchset merges changes done in [1], [2] >>> >>> [1] http://dpdk.org/dev/patchwork/patch/40370/ >>> [2] http://patches.dpdk.org/patch/40373/ >>> >>> Removed unused and duplicate make rules for test-basic, test-mempool, >>> test-ring from make file system in patch 10/10. >>> >>> v4: Removed unused and duplicate make rules for test-basic, >>> test-mempool, test-ring from make file system in patch 10/10. >>> >>> Reshma Pattan (10): >>> autotest: fix printing >>> autotest: fix invalid code on reports >>> autotest: make autotest runner python 2/3 compliant >>> autotest: visually separate different test categories >>> autotest: improve filtering >>> autotest: remove autotest grouping >>> autotest: properly parallelize unit tests >>> autotest: update autotest test case list >>> mk: update make targets for classified testcases >>> mk: remove unnecessary make rules of test >> >> Patches 1 to 7 are from Anatoly. >> Patches 8 and 9 were initiated by Jananee. > > The respective patches have i.e 1 to 7 have Anatolys Signed--off > And 8 and 9 have Jananees Signed-off along with mine. > > I have used git-am. What I am missing here? > > Thanks, > Reshma > The signoff is part of commit message, but the author name is part of commit metadata. I.e. as it stands, if these patches are applied, the commit message says i am the author, but the actual commit metadata says it's you. Use "git show --pretty=fuller" to see who is the author and who is the committer of each commit. To fix each commit, do an interactive rebase, stop after each commit (i.e. mark each commit as "edit") and do git commit --amend --author="Author Name <email@address.com>" (this is a brute force way - a "smarter" way would be to use git filter-branch, but IMO it's overkill unless you do that often and already have all necessary scripts ready and set up :) )
Hi, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, July 26, 2018 9:05 PM > To: Pattan, Reshma <reshma.pattan@intel.com> > Cc: dev@dpdk.org; Burakov, Anatoly <anatoly.burakov@intel.com>; > Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com> > Subject: Re: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again > > Reshma Pattan (10): > > autotest: fix printing > > autotest: fix invalid code on reports > > autotest: make autotest runner python 2/3 compliant > > autotest: visually separate different test categories > > autotest: improve filtering > > autotest: remove autotest grouping > > autotest: properly parallelize unit tests > > autotest: update autotest test case list > > mk: update make targets for classified testcases > > mk: remove unnecessary make rules of test > > Patches 1 to 7 are from Anatoly. > Patches 8 and 9 were initiated by Jananee. > > Please fix authorship of these patches. > Note: it should not happen if you use git-am to get the patches. > Addressed in v6 and sent. Thanks, Reshma