[v1] lib/metrics: disallow NULL as metric name
Checks
Commit Message
This patch adds a sanity check so that names passed into
rte_metrics_reg_names() and the wrapper rte_metrics_reg_name()
cannot be NULL.
Fixes: 349950ddb9c5 ("metrics: add information metrics library")
Signed-off-by: Remy Horton <remy.horton@intel.com>
---
lib/librte_metrics/rte_metrics.c | 3 +++
1 file changed, 3 insertions(+)
Comments
On 7/2/2018 2:46 PM, Remy Horton wrote:
> This patch adds a sanity check so that names passed into
> rte_metrics_reg_names() and the wrapper rte_metrics_reg_name()
> cannot be NULL.
>
> Fixes: 349950ddb9c5 ("metrics: add information metrics library")
>
> Signed-off-by: Remy Horton <remy.horton@intel.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
20/07/2018 17:30, Ferruh Yigit:
> On 7/2/2018 2:46 PM, Remy Horton wrote:
> > This patch adds a sanity check so that names passed into
> > rte_metrics_reg_names() and the wrapper rte_metrics_reg_name()
> > cannot be NULL.
> >
> > Fixes: 349950ddb9c5 ("metrics: add information metrics library")
> >
> > Signed-off-by: Remy Horton <remy.horton@intel.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
@@ -96,6 +96,9 @@ rte_metrics_reg_names(const char * const *names, uint16_t cnt_names)
/* Some sanity checks */
if (cnt_names < 1 || names == NULL)
return -EINVAL;
+ for (idx_name = 0; idx_name < cnt_names; idx_name++)
+ if (names[idx_name] == NULL)
+ return -EINVAL;
memzone = rte_memzone_lookup(RTE_METRICS_MEMZONE_NAME);
if (memzone == NULL)