diff mbox series

[v8,01/15] vhost: add virtio packed virtqueue defines

Message ID	20180705210741.17974-2-maxime.coquelin@redhat.com (mailing list archive)
State	Superseded, archived
Delegated to:	Maxime Coquelin
Headers	From: Maxime Coquelin <maxime.coquelin@redhat.com> To: tiwei.bie@intel.com, zhihong.wang@intel.com, jfreimann@redhat.com, dev@dpdk.org Cc: mst@redhat.com, jasowang@redhat.com, wexu@redhat.com Date: Thu, 5 Jul 2018 23:07:27 +0200 Message-Id: <20180705210741.17974-2-maxime.coquelin@redhat.com> In-Reply-To: <20180705210741.17974-1-maxime.coquelin@redhat.com> References: <20180705210741.17974-1-maxime.coquelin@redhat.com> Subject: [dpdk-dev] [PATCH v8 01/15] vhost: add virtio packed virtqueue defines Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	Vhost: add support to packed ring layout \| [v8,00/15] Vhost: add support to packed ring layout [v8,01/15] vhost: add virtio packed virtqueue defines [v8,02/15] vhost: add helpers for packed virtqueues [v8,03/15] vhost: vring address setup for packed queues [v8,04/15] vhost: clear shadow used table index at flush time [v8,05/15] vhost: make indirect desc table copy desc type agnostic [v8,06/15] vhost: clear batch copy index at copy time [v8,07/15] vhost: extract split ring handling from Rx and Tx functions [v8,08/15] vhost: append shadow used ring function names with split [v8,09/15] vhost: add shadow used ring support for packed rings [v8,10/15] vhost: create descriptor mapping function [v8,11/15] vhost: add vector filling support for packed ring [v8,12/15] vhost: add Rx support for packed ring [v8,13/15] vhost: add Tx support for packed ring [v8,14/15] vhost: add notification for packed ring [v8,15/15] vhost: advertize packed ring layout support

Checks

Context	Check	Description
ci/Intel-compilation	fail	Compilation issues

Commit Message

Maxime Coquelin July 5, 2018, 9:07 p.m. UTC

  From: Jens Freimann <jfreimann@redhat.com>

Signed-off-by: Jens Freimann <jfreimann@redhat.com>
---
 lib/librte_vhost/vhost.h | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

Comments

Tiwei Bie July 6, 2018, 2:52 a.m. UTC | #1

On Thu, Jul 05, 2018 at 11:07:27PM +0200, Maxime Coquelin wrote:
> From: Jens Freimann <jfreimann@redhat.com>
> 
> Signed-off-by: Jens Freimann <jfreimann@redhat.com>
> ---
>  lib/librte_vhost/vhost.h | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
> index 79e3117d2..4fc804bd8 100644
> --- a/lib/librte_vhost/vhost.h
> +++ b/lib/librte_vhost/vhost.h
> @@ -192,6 +192,26 @@ struct vhost_msg {
>   #define VIRTIO_F_VERSION_1 32
>  #endif
>  
> +/* Declare packed ring related bits for older kernels */
> +#ifndef VIRTIO_F_RING_PACKED
> +
> +#define VIRTIO_F_RING_PACKED 34
> +
> +#define VRING_DESC_F_NEXT			1
> +#define VRING_DESC_F_WRITE			2
> +#define VRING_DESC_F_INDIRECT		4
> +
> +#define VRING_DESC_F_AVAIL			(1ULL << 7)
> +#define VRING_DESC_F_USED			(1ULL << 15)
> +
> +struct vring_desc_packed {

Maybe vring_packed_desc will be more consistent with
vring_packed_desc_event and vring_packed. Jason also
planned to change the name to vring_packed_desc [1].

[1] https://lkml.org/lkml/2018/7/4/36

Best regards,
Tiwei Bie

> +	uint64_t addr;
> +	uint32_t len;
> +	uint16_t id;
> +	uint16_t flags;
> +};
> +#endif
> +
>  /*
>   * Available and used descs are in same order
>   */
> -- 
> 2.14.4
>

Maxime Coquelin July 6, 2018, 6:34 a.m. UTC | #2

On 07/06/2018 04:52 AM, Tiwei Bie wrote:
> On Thu, Jul 05, 2018 at 11:07:27PM +0200, Maxime Coquelin wrote:
>> From: Jens Freimann <jfreimann@redhat.com>
>>
>> Signed-off-by: Jens Freimann <jfreimann@redhat.com>
>> ---
>>   lib/librte_vhost/vhost.h | 20 ++++++++++++++++++++
>>   1 file changed, 20 insertions(+)
>>
>> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
>> index 79e3117d2..4fc804bd8 100644
>> --- a/lib/librte_vhost/vhost.h
>> +++ b/lib/librte_vhost/vhost.h
>> @@ -192,6 +192,26 @@ struct vhost_msg {
>>    #define VIRTIO_F_VERSION_1 32
>>   #endif
>>   
>> +/* Declare packed ring related bits for older kernels */
>> +#ifndef VIRTIO_F_RING_PACKED
>> +
>> +#define VIRTIO_F_RING_PACKED 34
>> +
>> +#define VRING_DESC_F_NEXT			1
>> +#define VRING_DESC_F_WRITE			2
>> +#define VRING_DESC_F_INDIRECT		4
>> +
>> +#define VRING_DESC_F_AVAIL			(1ULL << 7)
>> +#define VRING_DESC_F_USED			(1ULL << 15)
>> +
>> +struct vring_desc_packed {
> 
> Maybe vring_packed_desc will be more consistent with
> vring_packed_desc_event and vring_packed. Jason also
> planned to change the name to vring_packed_desc [1].
> 
> [1] https://lkml.org/lkml/2018/7/4/36

Thanks for the reminder, I fixed it in the series.

Regards,
Maxime
> 
> Best regards,
> Tiwei Bie
> 
>> +	uint64_t addr;
>> +	uint32_t len;
>> +	uint16_t id;
>> +	uint16_t flags;
>> +};
>> +#endif
>> +
>>   /*
>>    * Available and used descs are in same order
>>    */
>> -- 
>> 2.14.4
>>

diff mbox series

Patch

diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
index 79e3117d2..4fc804bd8 100644
--- a/lib/librte_vhost/vhost.h
+++ b/lib/librte_vhost/vhost.h
@@ -192,6 +192,26 @@  struct vhost_msg {
  #define VIRTIO_F_VERSION_1 32
 #endif
 
+/* Declare packed ring related bits for older kernels */
+#ifndef VIRTIO_F_RING_PACKED
+
+#define VIRTIO_F_RING_PACKED 34
+
+#define VRING_DESC_F_NEXT			1
+#define VRING_DESC_F_WRITE			2
+#define VRING_DESC_F_INDIRECT		4
+
+#define VRING_DESC_F_AVAIL			(1ULL << 7)
+#define VRING_DESC_F_USED			(1ULL << 15)
+
+struct vring_desc_packed {
+	uint64_t addr;
+	uint32_t len;
+	uint16_t id;
+	uint16_t flags;
+};
+#endif
+
 /*
  * Available and used descs are in same order
  */