[v4] net/e1000: add support for check descriptor status APIs
Checks
Commit Message
rte_eth_rx_descritpr_status and rte_eth_tx_descriptor_status
are supported by igb VF.
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
v2:
-add release note document info
v3:
-rebase code and change git log
v4:
-rebase code
---
doc/guides/rel_notes/release_18_08.rst | 4 ++--
drivers/net/e1000/igb_ethdev.c | 3 +++
2 files changed, 5 insertions(+), 2 deletions(-)
Comments
Hi, Ferruh
The doc of igb_vf.ini has enable "Rx descriptor status" & "Tx descriptor status" features, so I do not need update this doc in this patch.
Thanks
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Friday, June 29, 2018 9:53 AM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH v4] net/e1000: add support for check descriptor status APIs
>
> rte_eth_rx_descritpr_status and rte_eth_tx_descriptor_status are
> supported by igb VF.
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>
> ---
>
> v2:
> -add release note document info
>
> v3:
> -rebase code and change git log
>
> v4:
> -rebase code
> ---
> doc/guides/rel_notes/release_18_08.rst | 4 ++--
> drivers/net/e1000/igb_ethdev.c | 3 +++
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/rel_notes/release_18_08.rst
> b/doc/guides/rel_notes/release_18_08.rst
> index ac54121..d7613a2 100644
> --- a/doc/guides/rel_notes/release_18_08.rst
> +++ b/doc/guides/rel_notes/release_18_08.rst
> @@ -54,10 +54,10 @@ New Features
> PMD does not provide any. The provision of such tuned values now
> includes
> the ixgbe PMD.
>
> -* **Added fm10k ethernet driver to support check descriptor status
> APIs.**
> +* **Added fm10k and igb VF ethernet driver to support check descriptor
> +status APIs.**
>
> rte_eth_rx_descritpr_status and rte_eth_tx_descriptor_status
> - are supported by fm10K.
> + are supported by fm10K and igb VF.
>
>
> API Changes
> diff --git a/drivers/net/e1000/igb_ethdev.c
> b/drivers/net/e1000/igb_ethdev.c index edc7be3..f5b02b2 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -435,6 +435,9 @@ static const struct eth_dev_ops igbvf_eth_dev_ops =
> {
> .dev_supported_ptypes_get = eth_igb_supported_ptypes_get,
> .rx_queue_setup = eth_igb_rx_queue_setup,
> .rx_queue_release = eth_igb_rx_queue_release,
> + .rx_descriptor_done = eth_igb_rx_descriptor_done,
> + .rx_descriptor_status = eth_igb_rx_descriptor_status,
> + .tx_descriptor_status = eth_igb_tx_descriptor_status,
> .tx_queue_setup = eth_igb_tx_queue_setup,
> .tx_queue_release = eth_igb_tx_queue_release,
> .set_mc_addr_list = eth_igb_set_mc_addr_list,
> --
> 2.7.5
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, July 2, 2018 3:42 PM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; dev@dpdk.org
> Subject: RE: [PATCH v4] net/e1000: add support for check descriptor status
> APIs
>
> Hi, Ferruh
>
> The doc of igb_vf.ini has enable "Rx descriptor status" & "Tx descriptor
> status" features, so I do not need update this doc in this patch.
>
> Thanks
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Friday, June 29, 2018 9:53 AM
> > To: dev@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei
> > <wei.zhao1@intel.com>
> > Subject: [PATCH v4] net/e1000: add support for check descriptor status
> > APIs
> >
> > rte_eth_rx_descritpr_status and rte_eth_tx_descriptor_status are
> > supported by igb VF.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
So the patch looks like a fix, but not new feature enable, so I will remove the release notes update.
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z
> Sent: Monday, July 2, 2018 9:04 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4] net/e1000: add support for check
> descriptor status APIs
>
>
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Monday, July 2, 2018 3:42 PM
> > To: Yigit, Ferruh <ferruh.yigit@intel.com>
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; dev@dpdk.org
> > Subject: RE: [PATCH v4] net/e1000: add support for check descriptor
> > status APIs
> >
> > Hi, Ferruh
> >
> > The doc of igb_vf.ini has enable "Rx descriptor status" & "Tx
> > descriptor status" features, so I do not need update this doc in this patch.
>
> >
> > Thanks
> >
> > > -----Original Message-----
> > > From: Zhao1, Wei
> > > Sent: Friday, June 29, 2018 9:53 AM
> > > To: dev@dpdk.org
> > > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei
> > > <wei.zhao1@intel.com>
> > > Subject: [PATCH v4] net/e1000: add support for check descriptor
> > > status APIs
> > >
> > > rte_eth_rx_descritpr_status and rte_eth_tx_descriptor_status are
> > > supported by igb VF.
> > >
> > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>
> So the patch looks like a fix, but not new feature enable, so I will remove the
> release notes update.
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel
Thanks!
Qi
@@ -54,10 +54,10 @@ New Features
PMD does not provide any. The provision of such tuned values now includes
the ixgbe PMD.
-* **Added fm10k ethernet driver to support check descriptor status APIs.**
+* **Added fm10k and igb VF ethernet driver to support check descriptor status APIs.**
rte_eth_rx_descritpr_status and rte_eth_tx_descriptor_status
- are supported by fm10K.
+ are supported by fm10K and igb VF.
API Changes
@@ -435,6 +435,9 @@ static const struct eth_dev_ops igbvf_eth_dev_ops = {
.dev_supported_ptypes_get = eth_igb_supported_ptypes_get,
.rx_queue_setup = eth_igb_rx_queue_setup,
.rx_queue_release = eth_igb_rx_queue_release,
+ .rx_descriptor_done = eth_igb_rx_descriptor_done,
+ .rx_descriptor_status = eth_igb_rx_descriptor_status,
+ .tx_descriptor_status = eth_igb_tx_descriptor_status,
.tx_queue_setup = eth_igb_tx_queue_setup,
.tx_queue_release = eth_igb_tx_queue_release,
.set_mc_addr_list = eth_igb_set_mc_addr_list,