[dpdk-dev,2/7] bpf: fix 32-bit build support with meson

Message ID 20180608163807.66737-3-bruce.richardson@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series Enable 32-bit native builds with meson |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Bruce Richardson June 8, 2018, 4:38 p.m. UTC
  The JIT is only supported on x86_64 so disable for 32-bit builds.

Fixes: cc752e43e079 ("bpf: add JIT compilation for x86_64 ISA")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/librte_bpf/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Ananyev, Konstantin June 14, 2018, 11:57 a.m. UTC | #1
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson
> Sent: Friday, June 8, 2018 5:38 PM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>
> Subject: [dpdk-dev] [PATCH 2/7] bpf: fix 32-bit build support with meson
> 
> The JIT is only supported on x86_64 so disable for 32-bit builds.
> 
> Fixes: cc752e43e079 ("bpf: add JIT compilation for x86_64 ISA")
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  lib/librte_bpf/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_bpf/meson.build b/lib/librte_bpf/meson.build
> index de9de0091..bc0cd78f9 100644
> --- a/lib/librte_bpf/meson.build
> +++ b/lib/librte_bpf/meson.build
> @@ -8,7 +8,7 @@ sources = files('bpf.c',
>  		'bpf_pkt.c',
>  		'bpf_validate.c')
> 
> -if arch_subdir == 'x86'
> +if arch_subdir == 'x86' and cc.sizeof('void *') == 8
>  	sources += files('bpf_jit_x86.c')
>  endif
> 
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 2.17.1
  

Patch

diff --git a/lib/librte_bpf/meson.build b/lib/librte_bpf/meson.build
index de9de0091..bc0cd78f9 100644
--- a/lib/librte_bpf/meson.build
+++ b/lib/librte_bpf/meson.build
@@ -8,7 +8,7 @@  sources = files('bpf.c',
 		'bpf_pkt.c',
 		'bpf_validate.c')
 
-if arch_subdir == 'x86'
+if arch_subdir == 'x86' and cc.sizeof('void *') == 8
 	sources += files('bpf_jit_x86.c')
 endif