[dpdk-dev,v4,06/18] net/nfp/nfpcore: solve strncpy misuse
Checks
Commit Message
Signed-off-by: Andy Green <andy@warmcat.com>
Acked-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Tested-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green
> Sent: Friday, May 11, 2018 2:46 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v4 06/18] net/nfp/nfpcore: solve strncpy misuse
>
> Signed-off-by: Andy Green <andy@warmcat.com>
> Acked-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> Tested-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Missing fixes line.
Fixes: c7e9729da6b5 ("net/nfp: support CPP")
@@ -31,6 +31,8 @@
#include <sys/file.h>
#include <sys/stat.h>
+#include <rte_string_fns.h>
+
#include "nfp_cpp.h"
#include "nfp_target.h"
#include "nfp6000/nfp6000.h"
@@ -846,7 +848,7 @@ nfp6000_init(struct nfp_cpp *cpp, const char *devname)
memset(desc->busdev, 0, BUSDEV_SZ);
- strncpy(desc->busdev, devname, strlen(devname));
+ strlcpy(desc->busdev, devname, sizeof(desc->busdev));
ret = nfp_acquire_process_lock(desc);
if (ret)