Message ID | 1525327041-128382-1-git-send-email-Ravi1.kumar@amd.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Pablo de Lara Guarch |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1EA203238; Thu, 3 May 2018 07:57:52 +0200 (CEST) Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0072.outbound.protection.outlook.com [104.47.40.72]) by dpdk.org (Postfix) with ESMTP id EA1103230 for <dev@dpdk.org>; Thu, 3 May 2018 07:57:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Q/Y9fI4PwGA9IJcHGMckzKyam2Qr8DS40smpEYL1BHk=; b=txJDU33vsT/G+ZQk8hfP8iUIf3KW7oc/ACitKSc4aIzwdQPhstml3308pEeugCz3/9z05LyuSzXRFbtWtkMGZe9szNH21sbLHz+4C34zW80x9vRDCVGn7svFUIWUOV+eS2VaT2eflw6jVtJY3E4fVo0CMQ+t97gL9UZSeB6HXlo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Ravi1.Kumar@amd.com; Received: from wallaby-smavila.amd.com (202.56.249.162) by BN6PR12MB1505.namprd12.prod.outlook.com (2603:10b6:405:11::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.715.18; Thu, 3 May 2018 05:57:46 +0000 From: Ravi Kumar <Ravi1.kumar@amd.com> To: dev@dpdk.org Cc: pablo.de.lara.guarch@intel.com, thomas@monjalon.net, hemant.agrawal@nxp.com Date: Thu, 3 May 2018 01:57:20 -0400 Message-Id: <1525327041-128382-1-git-send-email-Ravi1.kumar@amd.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [202.56.249.162] X-ClientProxiedBy: MAXPR0101CA0045.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::31) To BN6PR12MB1505.namprd12.prod.outlook.com (2603:10b6:405:11::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:BN6PR12MB1505; X-Microsoft-Exchange-Diagnostics: 1; BN6PR12MB1505; 3:3/RCUiMIDxOgyLc31H9NTxHMKmDKHk/DvKISzJmC330EC0qZn9BVgFNXema12WrgWTQuaUFIB/mrm6Ms2wvvRBHoUoOY3eb+1P8jV1aqKynX5SGdExmvAWpA4wrle0lpn1/+q/wIlNW8nUTD8NcryvUmm6ZZMA/eMhmu6E1sMkBWscuO3dl9FhuTaU3wBIzeFeqF8loSVDhi/JZ1DJNAJ0qdmRTwb2vcldg2i3qn3x10Nb5T8Xa+YBlYsXPK6dyS; 25:VSDmHpyA+jyOkWtXDapK5vNo2tiyFVFzvNK7R0j31fVj5n3O/4FJ6gVtxOcCLYyPyeERUe55S9yU6FhAH0gRmZzm79HFvAgHpt3P2qEaJBpu9JxgMoQiitN7/y9K03TpcdCQOh45YnXFcsbZu7LyMSEWVlCauHk+hTpp650v56YLUb/JJST+s7gwCuTUen8nXa/kGUAoPlwm9STGMKbDnqQVYw3kqI9/LqbJW8gZsPp1d6+0JHAYjsbfGS7UaUHeo7s94nh/AOVtBQhTNgiv+rAFsT4S+smXMWJYBcijo+4uHgl/0Z77VMdoBCZjSNnw64VZoW4ahL8nz31LoRKyVg==; 31:Rh3f+L6RLVjTXfrpZN8YurNy4HPDetq4DFKlYWGWWBUrcCWnNZrC0RmeIYLSdTWDkOOQSUiEBO7jCteomczE18sKMPKWgEVyuMIXyzeG+KYYll7cjvsVQQ4kPR/i9ekR5CfeGv92NG59pF4vDwv/JrRkEgNy32uMWibJNvgq/Qh2DE0Ys2N/GUmfLk1psP3AM327sz4MzJWHUnqUMBEyAyvfRM6fdw9RWG4CVn/ZfRY= X-MS-TrafficTypeDiagnostic: BN6PR12MB1505: X-Microsoft-Exchange-Diagnostics: 1; BN6PR12MB1505; 20:admusAO2NP+Zh1U2WmVZi0yN6cz5SsjOC4MPuOKSqU8U3jjYR0u2DJsfEe5HgLGKSiWc5Ae8eXOWCtF3h5RWdf8Xfif08yZ1WHaIu3BVfAl0iuTY2vKTSsUWC7awZsxpmVR28PHa6IPn4dykFsudYWcFLd241vU5BcbcWcpBp4p4Oz3lUbVq142PQsmceYvNgRVZHqWo2zFBPoAROnXR5E0fuAkHYYwa2NGrCEGHAMpe8/MIBXoOXS7DJ02L+NjbSiec4Ckh5PfZgQrVFk0USGS2RN1GjITMJHamzxpkIdQlslvAmGkJGEP9LnbhWD1HG4b7V+z/+uCgnbJF8my6K6I/gsJR47BGU8nvQce/DFQlUGsH/1RfmO/T/aMUQAnOSpwvVbdjgzqtgbosv0F5bxdEwDVtE3YV8IWXXWVQBLntj4NKNBKLdzmahiQF/gn50mZaO4pPDA0y/vG2u6f1drc2HhieXVzqM289SYoaN1Ge6USMkPzoKLAmjloc9aUO; 4:bjzLGdIQrkAEasJPeMVDYIji46dNa01HG7DtBUpozlH0L2tVbLveCYkgSRTvU9oltFmA0RWWgT1hnFq4jsX2wxpQSwUNIr90TFkKc3JFfOL1vEQm5rl9DgSNOIpi9V0ULGBIUJQ+2KdLxQkmpIsr9guH+jTb0lAlYq8tROunkNySgiUUKhe8nZ/L51PJD3FrNLwQi4Ngv9NbMIuy/VPS9RYz5hOHWzbz7S5f6R+klxMEGd2vDwbEXKMSk/GV/rmypbRG4cFw4Xg3q8MPDFM6ZoWVbp3kVyx/lhIDS8sKn8umVfFrCiq/g+dqUbWxS/Fp X-Microsoft-Antispam-PRVS: <BN6PR12MB15054A5782EAC1C183E4C928AE870@BN6PR12MB1505.namprd12.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041310)(20161123560045)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:BN6PR12MB1505; BCL:0; PCL:0; RULEID:; SRVR:BN6PR12MB1505; X-Forefront-PRVS: 066153096A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(346002)(39860400002)(396003)(376002)(366004)(189003)(199004)(486006)(105586002)(106356001)(68736007)(48376002)(53416004)(50466002)(2906002)(305945005)(36756003)(51416003)(7696005)(50226002)(6486002)(2351001)(6666003)(52116002)(4326008)(53936002)(6916009)(8936002)(2361001)(8676002)(7736002)(3846002)(6116002)(97736004)(66066001)(26005)(5660300001)(81156014)(81166006)(47776003)(59450400001)(386003)(8656006)(956004)(86362001)(478600001)(72206003)(16586007)(186003)(316002)(2616005)(16526019)(476003)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR12MB1505; H:wallaby-smavila.amd.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR12MB1505; 23:Vrv/DSETl9YFu7P/c2zIlHADJwtgEr1rcllU6Woff?= FGG0x9u1r8EXZFil3ICSJQ8VPH4IjGvHOffdcczEekQw4PeBmHsZ/eYdiEyyO5PhHHzCQCdiCZnc9Thx/6Y0VqHS9iiR+S2HKAJAKOJEatCw6sRVa1c/A+LLYvo+6A4gu2jEa6cbBbGSIoLCR/YEF/5rJ6tIlwgIaVvWTjCaDVCprGSqMqJiHcRMBbNKK1mhX2Wr+HVMAGAOMR5VCPO7r2TQKkGPcYTb/QXauNrolcu8dbV8OGe/gm/Oi78hekpSxDDmubDmZr/D8G/I8Q5Ld9SWqQzyUEG2oDEBaBIiJegloCknBDN8bVUls+PBQM7L6l60lLmRt9+uQhSRg1V3EgmStYRzgz3huKLIpZCaagFed1VkPEiw4riSFL0Lo7KoRNlzyFVV1yfSrj4x5KlM2obT1wimBAsfCFZ4YAbPcDihkUCPaKBzqft4F/l+QjuJizioLjhqrT0wG2cDPfBueJqbjFoqmMHjb+kQvSXgQIJ5lvz6Dh4I3RzxpdMlsPeBk5KKE2BAv74/P87wyU6Yy1kbjKP/x250b32oeCQqh+P7YUjCHGBUdJTjGQ2osTrzrOb3KEs8MTDy8yVYZGrZt9Gv5Zt7+M3HXz2SQ41B+NUMp9DgakfHDtZeg86RE01C8j3aWuyX3bc/aFcyUQ60oI+iQ4YmN+J5g32sR/fPzXn8nAz1Rq1Pi6ud/HOdmg1IwjvEnwPsyuzQKFzY9KQEF/aeuioQsanX+uWloHJFhGymTZapTUnJ8lR45K/7V6z6DEaGf0WmeycjTALYizJEAOnQBG4JZSv7BeWOWV+lWRQ6kEgS2FNcug9jTzpelNGM4axmGEJf3k2uY7PnqwN43Mh0TybdC7WUhIT8FM/ePTDV/mPnKxvvRiUvLVMWWQB0dijEpphG4R84+Z6q+ZMMlQaqA2OOcvxHkYv3KIr85ARv+IbzVCU1PTgeNXMwtgO+8PXUzvmML+SqJE3RpSf65/VlSuL0C3nNkUMZDHmXo4f47Q1/h6M6yWIXuN+c8oaZvahdoEYf7bNofT/FNrhGH1x9Lsx8vP/e6z69V/68x/hf/lbLX+CnAkzGUa7N0mSZT+2hv0l6DVil8/JYxOBTIpgolMKBQwl5XBk88wHT7HiIxKbr0aNKzOPk3y4Q6494bvyeHpqWvUMVcitfw148Ijggmst0j3ehZ9WpCSmzYBJEg== X-Microsoft-Antispam-Message-Info: 199qBBXe0HHrUoNhpAsIjri0laKCzgQM/k7TEnYXqR+1TUxrldGRr/X/q7gVHRVVvGhdch0/EX63yOKHBsyErpJnjDiKNSkvZSR5Cus2tsIf1I9v03pMBrWHdivcPV75f2xK0KbxwEepJaTv2eHPQhBZjW34K5ks2RqAFHDwSGw4Mp8+N7fjx5uIU7D5yfY3 X-Microsoft-Exchange-Diagnostics: 1; BN6PR12MB1505; 6:zsRmaVaxMh85pHcYeo8AbSHX5hkcvdoMF/9LY2am4galjENTFpjdmVc7ewrUp2ggwrwjglcGvInuqs8GJoFAMO0QclHylB4XGpHHG+tSBcofO0xFtX+EqiH1B8YFM5YPaDJkzEzSvdaeRKt+3G2ARBUjd61G+UY7Vd4TiTC9fjH0sQfLzF4aR31DHq442Wab6Hz70f/jSLW3tujGKZW670RhpMmB4/RM8mM3ZGPS40r+Uh80rPc05e8Llrvi3mW0+xQM7Pl6deEwocfBkw4aRL8zDLgi8yWIsUKWL+RoSYbsPNOD7kJWm0NI43sEJucYppdvSPTsBMaROXpku/UOpBbf8yLs3XY+UUUlr7H6xFvsFXnYici6YXNO/zOPyToLlCKhfMatucbi9b6yEfJdDQyhVdqooaYIdrAo8TD0c1AZbxrwzVI0pCXiAH6E0H6XBVKRdQ5fcgWiRBBiV2W3vQ==; 5:y4hC515i9Y5U9mhQONRZXVRmGnU6Ad8xmuvWfTVBid7xr4Zgnxajbc8rxM0vO+a5a3mMcYfDNI3pNQ/MnpBDHJSS6vz98M/dtnDFZXHMdQQQ2Tc/1HVBiv7+jG5Aqn3vE/49qzyg1gwf6cO6xpbVjhrlmvlcrC3gU1ZPheEKwU0=; 24:l8mJsabeoELAs+ozyqTWBTZJsP6NZkkuqDM9SWCO5awuQK/7r3oBL2cyyiqzt7W8pbJs4yYhcPQ4twKYKoD/2ZZS2Njt3iTjzQ/1rnJVWUg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR12MB1505; 7:0pVZrHNRR4VSLSWtlwAAKssqd7P5ZiwK2r9qXIpjwo1e9EyBIxnkohbchC/84yl3lOEcrOQ2U5LnwmpALlD1FWYn/Qs1Rt4iPMThmb8vk5Oou9umb0ZTKvg0vShyUuc35j/v/kHfuRlHlavAHbvZD5D2Bx3hqoPU1JtJsth619FBQgbhp92nK2WwSapWN9t8o6tCZIYxRfluTfW+I8EF9OcCBLFe9S+r5//a8VJuL9pkk5q6j/h2JKWObakHbFA1; 20:waXLzVrWOkxTWKU+JCX13BHTP73M2OwKT1AqCBE98EWHHbNJQcyGgIyyh/UP0R1c1uflk4YVzPn5pIB3fotp0d0Lop7IbpeVo8io8STqmIs1zofrogBQEpneOq78noQAn9QA3WidrCiVQ6etcFwHkcBNy88Jc65QPWfqVkK+jpCCyjE551Z9QWOxQhvWGQErwgcVWNOzYeXslAQYQOuxQqkB8pnY5KZq13XEfhEP9i0eBLhWH1T7bn16jk804Sz3 X-MS-Office365-Filtering-Correlation-Id: 776881ad-95a2-4b17-ec71-08d5b0bacc3d X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2018 05:57:46.4395 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 776881ad-95a2-4b17-ec71-08d5b0bacc3d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1505 Subject: [dpdk-dev] [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | fail | Compilation issues |
Commit Message
Kumar, Ravi1
May 3, 2018, 5:57 a.m. UTC
Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
---
config/common_base | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Ravi, > -----Original Message----- > From: Ravi Kumar [mailto:Ravi1.kumar@amd.com] > Sent: Thursday, May 3, 2018 6:57 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; > thomas@monjalon.net; hemant.agrawal@nxp.com > Subject: [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver by default > > Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com> > --- > config/common_base | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/config/common_base b/config/common_base index > 03a8688..802035b 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -555,7 +555,7 @@ CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO=y > # > # Compile PMD for AMD CCP crypto device # - > CONFIG_RTE_LIBRTE_PMD_CCP=n > +CONFIG_RTE_LIBRTE_PMD_CCP=y > CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH=n > > # > -- > 2.7.4 I think this cannot be enabled by default, since it has an external dependency on OpenSSL. Pablo
>Hi Ravi, > >> -----Original Message----- >> From: Ravi Kumar [mailto:Ravi1.kumar@amd.com] >> Sent: Thursday, May 3, 2018 6:57 AM >> To: dev@dpdk.org >> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; >> thomas@monjalon.net; hemant.agrawal@nxp.com >> Subject: [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver by >> default >> >> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com> >> --- >> config/common_base | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/config/common_base b/config/common_base index >> 03a8688..802035b 100644 >> --- a/config/common_base >> +++ b/config/common_base >> @@ -555,7 +555,7 @@ CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO=y >> # >> # Compile PMD for AMD CCP crypto device # - >> CONFIG_RTE_LIBRTE_PMD_CCP=n >> +CONFIG_RTE_LIBRTE_PMD_CCP=y >> CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH=n >> >> # >> -- >> 2.7.4 > >I think this cannot be enabled by default, since it has an external dependency on OpenSSL. Hi Pablo, We were asked to enable the PMD by default in one of the previous emails. Unfortunately, we can't remove the dependency on OpenSSL. Kindly suggest the option in this case. We could leave this patch-set and have the code as-is, I mean the older compile-time option. If not, then this is our only option. Regards, Ravi > >Pablo >
09/05/2018 07:53, Kumar, Ravi1: > > > >I think this cannot be enabled by default, since it has an external dependency on OpenSSL. > > Hi Pablo, > > We were asked to enable the PMD by default in one of the previous emails. Unfortunately, we can't remove the dependency on OpenSSL. Kindly suggest the option in this case. We could leave this patch-set and have the code as-is, I mean the older compile-time option. If not, then this is our only option. If you have a dependency, you cannot enable by default.
>09/05/2018 07:53, Kumar, Ravi1: >> > >> >I think this cannot be enabled by default, since it has an external dependency on OpenSSL. >> >> Hi Pablo, >> >> We were asked to enable the PMD by default in one of the previous emails. Unfortunately, we can't remove the dependency on OpenSSL. Kindly suggest the option in this case. We could leave this patch-set and have the code as-is, I mean the older compile-time option. If not, then this is our only option. > >If you have a dependency, you cannot enable by default. > Hi Thomas, Ok. Could we still submit the 2nd patch for changing compile time to run time option and remove the first one? Regards, Ravi
09/05/2018 10:11, Kumar, Ravi1: > >09/05/2018 07:53, Kumar, Ravi1: > >> > > >> >I think this cannot be enabled by default, since it has an external dependency on OpenSSL. > >> > >> Hi Pablo, > >> > >> We were asked to enable the PMD by default in one of the previous emails. Unfortunately, we can't remove the dependency on OpenSSL. Kindly suggest the option in this case. We could leave this patch-set and have the code as-is, I mean the older compile-time option. If not, then this is our only option. > > > >If you have a dependency, you cannot enable by default. > > > Hi Thomas, > > Ok. Could we still submit the 2nd patch for changing compile time to run time option and remove the first one? Yes, sure
Hi Ravi, > -----Original Message----- > From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com] > Sent: Wednesday, May 9, 2018 9:11 AM > To: Thomas Monjalon <thomas@monjalon.net> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; dev@dpdk.org; > hemant.agrawal@nxp.com > Subject: RE: [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver by > default > > >09/05/2018 07:53, Kumar, Ravi1: > >> > > >> >I think this cannot be enabled by default, since it has an external > dependency on OpenSSL. > >> > >> Hi Pablo, > >> > >> We were asked to enable the PMD by default in one of the previous emails. > Unfortunately, we can't remove the dependency on OpenSSL. Kindly suggest the > option in this case. We could leave this patch-set and have the code as-is, I > mean the older compile-time option. If not, then this is our only option. > > > >If you have a dependency, you cannot enable by default. > > > Hi Thomas, > > Ok. Could we still submit the 2nd patch for changing compile time to run time > option and remove the first one? I have two comments on the other patch. Could you submit a v2 of that patch and drop this first patch? Thanks, Pablo > > Regards, > Ravi
>Hi Ravi, > >> -----Original Message----- >> From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com] >> Sent: Wednesday, May 9, 2018 9:11 AM >> To: Thomas Monjalon <thomas@monjalon.net> >> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; >> dev@dpdk.org; hemant.agrawal@nxp.com >> Subject: RE: [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode >> driver by default >> >> >09/05/2018 07:53, Kumar, Ravi1: >> >> > >> >> >I think this cannot be enabled by default, since it has an >> >> >external >> dependency on OpenSSL. >> >> >> >> Hi Pablo, >> >> >> >> We were asked to enable the PMD by default in one of the previous emails. >> Unfortunately, we can't remove the dependency on OpenSSL. Kindly >> suggest the option in this case. We could leave this patch-set and >> have the code as-is, I mean the older compile-time option. If not, then this is our only option. >> > >> >If you have a dependency, you cannot enable by default. >> > >> Hi Thomas, >> >> Ok. Could we still submit the 2nd patch for changing compile time to >> run time option and remove the first one? > >I have two comments on the other patch. Could you submit a v2 of that patch and drop this first patch? > >Thanks, >Pablo Hi Pablo, Sure. I will submit v2 with the changes. Regards, Ravi > >> >> Regards, >> Ravi > >
diff --git a/config/common_base b/config/common_base index 03a8688..802035b 100644 --- a/config/common_base +++ b/config/common_base @@ -555,7 +555,7 @@ CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO=y # # Compile PMD for AMD CCP crypto device # -CONFIG_RTE_LIBRTE_PMD_CCP=n +CONFIG_RTE_LIBRTE_PMD_CCP=y CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH=n #