[dpdk-dev,14/14] bnxt: add device ID for Stratus VF
Checks
Commit Message
From: Somnath Kotur <somnath.kotur@broadcom.com>
Fixes: 1cd45aeb3270 ("net/bnxt: support Stratus VF device")
Cc: ajit.khaparde@broadcom.com
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
drivers/net/bnxt/bnxt_ethdev.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
Comments
On 4/17/2018 2:11 AM, Ajit Khaparde wrote:
> From: Somnath Kotur <somnath.kotur@broadcom.com>
>
This is adding new device id to driver.
Does it require any change in documentation?
Do you want to announce new hw support in release notes?
> Fixes: 1cd45aeb3270 ("net/bnxt: support Stratus VF device")
> Cc: ajit.khaparde@broadcom.com
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index 3cf845089..7632c326b 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -34,7 +34,8 @@ int bnxt_logtype_driver;
>
> #define PCI_VENDOR_ID_BROADCOM 0x14E4
>
> -#define BROADCOM_DEV_ID_STRATUS_NIC_VF 0x1609
> +#define BROADCOM_DEV_ID_STRATUS_NIC_VF1 0x1606
> +#define BROADCOM_DEV_ID_STRATUS_NIC_VF2 0x1609
> #define BROADCOM_DEV_ID_STRATUS_NIC 0x1614
> #define BROADCOM_DEV_ID_57414_VF 0x16c1
> #define BROADCOM_DEV_ID_57301 0x16c8
> @@ -75,7 +76,9 @@ int bnxt_logtype_driver;
>
> static const struct rte_pci_id bnxt_pci_id_map[] = {
> { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
> - BROADCOM_DEV_ID_STRATUS_NIC_VF) },
> + BROADCOM_DEV_ID_STRATUS_NIC_VF1) },
> + { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
> + BROADCOM_DEV_ID_STRATUS_NIC_VF2) },
> { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_STRATUS_NIC) },
> { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57414_VF) },
> { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57301) },
> @@ -3063,7 +3066,8 @@ static bool bnxt_vf_pciid(uint16_t id)
> id == BROADCOM_DEV_ID_5731X_VF ||
> id == BROADCOM_DEV_ID_5741X_VF ||
> id == BROADCOM_DEV_ID_57414_VF ||
> - id == BROADCOM_DEV_ID_STRATUS_NIC_VF)
> + id == BROADCOM_DEV_ID_STRATUS_NIC_VF1 ||
> + id == BROADCOM_DEV_ID_STRATUS_NIC_VF2)
> return true;
> return false;
> }
>
No Ferruh. It is not a new product family.
Just adding a device ID (for a VF) for a skew of already existing product.
So a documentation update is not required.
Thanks
Ajit
On Tue, Apr 17, 2018 at 11:20 AM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:
> On 4/17/2018 2:11 AM, Ajit Khaparde wrote:
> > From: Somnath Kotur <somnath.kotur@broadcom.com>
> >
>
> This is adding new device id to driver.
> Does it require any change in documentation?
> Do you want to announce new hw support in release notes?
>
> > Fixes: 1cd45aeb3270 ("net/bnxt: support Stratus VF device")
> > Cc: ajit.khaparde@broadcom.com
> > Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
> > ---
> > drivers/net/bnxt/bnxt_ethdev.c | 10 +++++++---
> > 1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_
> ethdev.c
> > index 3cf845089..7632c326b 100644
> > --- a/drivers/net/bnxt/bnxt_ethdev.c
> > +++ b/drivers/net/bnxt/bnxt_ethdev.c
> > @@ -34,7 +34,8 @@ int bnxt_logtype_driver;
> >
> > #define PCI_VENDOR_ID_BROADCOM 0x14E4
> >
> > -#define BROADCOM_DEV_ID_STRATUS_NIC_VF 0x1609
> > +#define BROADCOM_DEV_ID_STRATUS_NIC_VF1 0x1606
> > +#define BROADCOM_DEV_ID_STRATUS_NIC_VF2 0x1609
> > #define BROADCOM_DEV_ID_STRATUS_NIC 0x1614
> > #define BROADCOM_DEV_ID_57414_VF 0x16c1
> > #define BROADCOM_DEV_ID_57301 0x16c8
> > @@ -75,7 +76,9 @@ int bnxt_logtype_driver;
> >
> > static const struct rte_pci_id bnxt_pci_id_map[] = {
> > { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
> > - BROADCOM_DEV_ID_STRATUS_NIC_VF) },
> > + BROADCOM_DEV_ID_STRATUS_NIC_VF1) },
> > + { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
> > + BROADCOM_DEV_ID_STRATUS_NIC_VF2) },
> > { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
> BROADCOM_DEV_ID_STRATUS_NIC) },
> > { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
> BROADCOM_DEV_ID_57414_VF) },
> > { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57301) },
> > @@ -3063,7 +3066,8 @@ static bool bnxt_vf_pciid(uint16_t id)
> > id == BROADCOM_DEV_ID_5731X_VF ||
> > id == BROADCOM_DEV_ID_5741X_VF ||
> > id == BROADCOM_DEV_ID_57414_VF ||
> > - id == BROADCOM_DEV_ID_STRATUS_NIC_VF)
> > + id == BROADCOM_DEV_ID_STRATUS_NIC_VF1 ||
> > + id == BROADCOM_DEV_ID_STRATUS_NIC_VF2)
> > return true;
> > return false;
> > }
> >
>
>
On 4/17/2018 7:25 PM, Ajit Khaparde wrote:
> No Ferruh. It is not a new product family.
> Just adding a device ID (for a VF) for a skew of already existing product.
> So a documentation update is not required.
OK, thanks for clarification.
>
> Thanks
> Ajit
>
> On Tue, Apr 17, 2018 at 11:20 AM, Ferruh Yigit <ferruh.yigit@intel.com
> <mailto:ferruh.yigit@intel.com>> wrote:
>
> On 4/17/2018 2:11 AM, Ajit Khaparde wrote:
> > From: Somnath Kotur <somnath.kotur@broadcom.com
> <mailto:somnath.kotur@broadcom.com>>
> >
>
> This is adding new device id to driver.
> Does it require any change in documentation?
> Do you want to announce new hw support in release notes?
>
> > Fixes: 1cd45aeb3270 ("net/bnxt: support Stratus VF device")
> > Cc: ajit.khaparde@broadcom.com <mailto:ajit.khaparde@broadcom.com>
> > Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com
> <mailto:somnath.kotur@broadcom.com>>
> > ---
> > drivers/net/bnxt/bnxt_ethdev.c | 10 +++++++---
> > 1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> > index 3cf845089..7632c326b 100644
> > --- a/drivers/net/bnxt/bnxt_ethdev.c
> > +++ b/drivers/net/bnxt/bnxt_ethdev.c
> > @@ -34,7 +34,8 @@ int bnxt_logtype_driver;
> >
> > #define PCI_VENDOR_ID_BROADCOM 0x14E4
> >
> > -#define BROADCOM_DEV_ID_STRATUS_NIC_VF 0x1609
> > +#define BROADCOM_DEV_ID_STRATUS_NIC_VF1 0x1606
> > +#define BROADCOM_DEV_ID_STRATUS_NIC_VF2 0x1609
> > #define BROADCOM_DEV_ID_STRATUS_NIC 0x1614
> > #define BROADCOM_DEV_ID_57414_VF 0x16c1
> > #define BROADCOM_DEV_ID_57301 0x16c8
> > @@ -75,7 +76,9 @@ int bnxt_logtype_driver;
> >
> > static const struct rte_pci_id bnxt_pci_id_map[] = {
> > { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
> > - BROADCOM_DEV_ID_STRATUS_NIC_VF) },
> > + BROADCOM_DEV_ID_STRATUS_NIC_VF1) },
> > + { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
> > + BROADCOM_DEV_ID_STRATUS_NIC_VF2) },
> > { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_STRATUS_NIC) },
> > { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57414_VF) },
> > { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57301) },
> > @@ -3063,7 +3066,8 @@ static bool bnxt_vf_pciid(uint16_t id)
> > id == BROADCOM_DEV_ID_5731X_VF ||
> > id == BROADCOM_DEV_ID_5741X_VF ||
> > id == BROADCOM_DEV_ID_57414_VF ||
> > - id == BROADCOM_DEV_ID_STRATUS_NIC_VF)
> > + id == BROADCOM_DEV_ID_STRATUS_NIC_VF1 ||
> > + id == BROADCOM_DEV_ID_STRATUS_NIC_VF2)
> > return true;
> > return false;
> > }
> >
>
>
@@ -34,7 +34,8 @@ int bnxt_logtype_driver;
#define PCI_VENDOR_ID_BROADCOM 0x14E4
-#define BROADCOM_DEV_ID_STRATUS_NIC_VF 0x1609
+#define BROADCOM_DEV_ID_STRATUS_NIC_VF1 0x1606
+#define BROADCOM_DEV_ID_STRATUS_NIC_VF2 0x1609
#define BROADCOM_DEV_ID_STRATUS_NIC 0x1614
#define BROADCOM_DEV_ID_57414_VF 0x16c1
#define BROADCOM_DEV_ID_57301 0x16c8
@@ -75,7 +76,9 @@ int bnxt_logtype_driver;
static const struct rte_pci_id bnxt_pci_id_map[] = {
{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
- BROADCOM_DEV_ID_STRATUS_NIC_VF) },
+ BROADCOM_DEV_ID_STRATUS_NIC_VF1) },
+ { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM,
+ BROADCOM_DEV_ID_STRATUS_NIC_VF2) },
{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_STRATUS_NIC) },
{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57414_VF) },
{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57301) },
@@ -3063,7 +3066,8 @@ static bool bnxt_vf_pciid(uint16_t id)
id == BROADCOM_DEV_ID_5731X_VF ||
id == BROADCOM_DEV_ID_5741X_VF ||
id == BROADCOM_DEV_ID_57414_VF ||
- id == BROADCOM_DEV_ID_STRATUS_NIC_VF)
+ id == BROADCOM_DEV_ID_STRATUS_NIC_VF1 ||
+ id == BROADCOM_DEV_ID_STRATUS_NIC_VF2)
return true;
return false;
}