[dpdk-dev] net/i40e: fix flow RSS queue region error
Checks
Commit Message
Queue region comparison error in configuration parameters.
Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Tested-by: Peng Yuan <yuan.peng@intel.com>
---
drivers/net/i40e/i40e_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Tuesday, April 3, 2018 2:09 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] net/i40e: fix flow RSS queue region error
>
> Queue region comparison error in configuration parameters.
>
> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Tested-by: Peng Yuan <yuan.peng@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/i40e/i40e_flow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index
> 8d0a36b..f3e8c5f 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -4239,7 +4239,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev
> *dev,
> }
>
> if (rss_info->num < rss->num ||
> - rss_info->queue[0] < rss->queue[0] ||
> + rss->queue[0] < rss_info->queue[0] ||
> (rss->queue[0] + rss->num >
> rss_info->num + rss_info->queue[0])) {
> rte_flow_error_set(error, EINVAL,
> --
> 2.7.5
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z
> Sent: Wednesday, April 4, 2018 12:06 PM
> To: Zhao1, Wei; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix flow RSS queue region error
>
>
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Tuesday, April 3, 2018 2:09 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei
> > <wei.zhao1@intel.com>
> > Subject: [PATCH] net/i40e: fix flow RSS queue region error
> >
> > Queue region comparison error in configuration parameters.
> >
> > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > Tested-by: Peng Yuan <yuan.peng@intel.com>
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel, thanks!
/Helin
@@ -4239,7 +4239,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
}
if (rss_info->num < rss->num ||
- rss_info->queue[0] < rss->queue[0] ||
+ rss->queue[0] < rss_info->queue[0] ||
(rss->queue[0] + rss->num >
rss_info->num + rss_info->queue[0])) {
rte_flow_error_set(error, EINVAL,