[dpdk-dev,01/13] net/bonding: fix library version in meson build
Checks
Commit Message
Fixes: a0ace286a60b ("net/bonding: build with meson")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/bonding/meson.build | 1 +
1 file changed, 1 insertion(+)
Comments
On Tue, Mar 20, 2018 at 11:26:15AM +0000, Andrew Rybchenko wrote:
> Fixes: a0ace286a60b ("net/bonding: build with meson")
> Cc: stable@dpdk.org
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> --- a/drivers/net/bonding/meson.build
> +++ b/drivers/net/bonding/meson.build
> @@ -2,6 +2,7 @@
> # Copyright(c) 2017 Intel Corporation
>
> name = 'bond' #, james bond :-)
Ah ah ah, I had missed this important comment!
Unfortunately I think the real name is "bonding".
Does it mean the full name should be james bonding?
On Tue, Mar 27, 2018 at 06:43:48PM +0200, Thomas Monjalon wrote:
> > --- a/drivers/net/bonding/meson.build
> > +++ b/drivers/net/bonding/meson.build
> > @@ -2,6 +2,7 @@
> > # Copyright(c) 2017 Intel Corporation
> >
> > name = 'bond' #, james bond :-)
>
> Ah ah ah, I had missed this important comment!
>
> Unfortunately I think the real name is "bonding".
> Does it mean the full name should be james bonding?
>
Nope, the name of the driver when built is "bond", according to the old
build system anyway. The name of the directory is "bonding", hence the
override here.
ls x86_64-native-linuxapp-gcc/lib/librte_pmd_bond*
x86_64-native-linuxapp-gcc/lib/librte_pmd_bond.a
Ideally, I'd like to be able to get rid of that "name" parameter entirely,
if we can just rename all directories to match the driver names exactly. In
this case, if we do want the driver to be called librte_pmd_bonding.a/.so,
then we just remove this override.
/Bruce
@@ -2,6 +2,7 @@
# Copyright(c) 2017 Intel Corporation
name = 'bond' #, james bond :-)
+version = 2
sources = files('rte_eth_bond_api.c', 'rte_eth_bond_pmd.c',
'rte_eth_bond_args.c', 'rte_eth_bond_8023ad.c', 'rte_eth_bond_alb.c')