[dpdk-dev,RFC,v2,1/3] vhost: invalidate vring addresses in cleanup_vq()
Checks
Commit Message
When cleaning-up the virtqueue, we also need to invalidate its
addresses to be sure outdated addresses won't be used later.
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Reviewed-by: Jens Freimann <jfreimann@redhat.com>
---
lib/librte_vhost/vhost.c | 6 ++++--
lib/librte_vhost/vhost.h | 3 ++-
lib/librte_vhost/vhost_user.c | 2 +-
3 files changed, 7 insertions(+), 4 deletions(-)
Comments
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Maxime Coquelin
> Sent: Tuesday, February 27, 2018 10:35 PM
> To: Tan, Jianfeng <jianfeng.tan@intel.com>; stefanha@redhat.com; Bie,
> Tiwei <tiwei.bie@intel.com>; jfreimann@redhat.com; dev@dpdk.org
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [dpdk-dev] [RFC v2 1/3] vhost: invalidate vring addresses in
> cleanup_vq()
>
> When cleaning-up the virtqueue, we also need to invalidate its addresses to
> be sure outdated addresses won't be used later.
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> Reviewed-by: Jens Freimann <jfreimann@redhat.com>
> ---
Reviewed-by: Zhiyong Yang <zhiyong.yang@intel.com>
@@ -69,12 +69,14 @@ __vhost_iova_to_vva(struct virtio_net *dev, struct vhost_virtqueue *vq,
}
void
-cleanup_vq(struct vhost_virtqueue *vq, int destroy)
+cleanup_vq(struct virtio_net *dev, struct vhost_virtqueue *vq, int destroy)
{
if ((vq->callfd >= 0) && (destroy != 0))
close(vq->callfd);
if (vq->kickfd >= 0)
close(vq->kickfd);
+
+ vring_invalidate(dev, vq);
}
/*
@@ -89,7 +91,7 @@ cleanup_device(struct virtio_net *dev, int destroy)
vhost_backend_cleanup(dev);
for (i = 0; i < dev->nr_vring; i++)
- cleanup_vq(dev->virtqueue[i], destroy);
+ cleanup_vq(dev, dev->virtqueue[i], destroy);
}
void
@@ -362,7 +362,8 @@ void cleanup_device(struct virtio_net *dev, int destroy);
void reset_device(struct virtio_net *dev);
void vhost_destroy_device(int);
-void cleanup_vq(struct vhost_virtqueue *vq, int destroy);
+void cleanup_vq(struct virtio_net *dev, struct vhost_virtqueue *vq,
+ int destroy);
void free_vq(struct vhost_virtqueue *vq);
int alloc_vring_queue(struct virtio_net *dev, uint32_t vring_idx);
@@ -219,7 +219,7 @@ vhost_user_set_features(struct virtio_net *dev, uint64_t features)
continue;
dev->virtqueue[dev->nr_vring] = NULL;
- cleanup_vq(vq, 1);
+ cleanup_vq(dev, vq, 1);
free_vq(vq);
}
}