[dpdk-dev,dpdk-stable] build: remove unused map symbols
Checks
Commit Message
Remove some unused map symbol.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
drivers/bus/fslmc/rte_bus_fslmc_version.map | 2 --
drivers/mempool/dpaa/rte_mempool_dpaa_version.map | 1 -
lib/librte_eal/rte_eal_version.map | 1 -
lib/librte_ether/rte_ethdev_version.map | 1 -
lib/librte_ring/rte_ring_version.map | 1 -
5 files changed, 6 deletions(-)
Comments
On Mon, Feb 12, 2018 at 07:53:05PM +0530, Pavan Nikhilesh wrote:
> Remove some unused map symbol.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
> drivers/bus/fslmc/rte_bus_fslmc_version.map | 2 --
> drivers/mempool/dpaa/rte_mempool_dpaa_version.map | 1 -
> lib/librte_eal/rte_eal_version.map | 1 -
> lib/librte_ether/rte_ethdev_version.map | 1 -
> lib/librte_ring/rte_ring_version.map | 1 -
> 5 files changed, 6 deletions(-)
>
> diff --git a/drivers/bus/fslmc/rte_bus_fslmc_version.map b/drivers/bus/fslmc/rte_bus_fslmc_version.map
> index 3f1ba130c..b7db07414 100644
> --- a/drivers/bus/fslmc/rte_bus_fslmc_version.map
> +++ b/drivers/bus/fslmc/rte_bus_fslmc_version.map
> @@ -28,7 +28,6 @@ DPDK_17.05 {
> qbman_eq_desc_set_no_orp;
> qbman_eq_desc_set_qd;
> qbman_eq_desc_set_response;
> - qbman_get_version;
> qbman_pull_desc_clear;
> qbman_pull_desc_set_fq;
> qbman_pull_desc_set_numframes;
> @@ -41,7 +40,6 @@ DPDK_17.05 {
> qbman_swp_acquire;
> qbman_swp_pull;
> qbman_swp_release;
> - qbman_swp_send_multiple;
> rte_fslmc_driver_register;
> rte_fslmc_driver_unregister;
> rte_fslmc_vfio_dmamap;
> diff --git a/drivers/mempool/dpaa/rte_mempool_dpaa_version.map b/drivers/mempool/dpaa/rte_mempool_dpaa_version.map
> index cc635c736..d05f274d0 100644
> --- a/drivers/mempool/dpaa/rte_mempool_dpaa_version.map
> +++ b/drivers/mempool/dpaa/rte_mempool_dpaa_version.map
> @@ -2,7 +2,6 @@ DPDK_17.11 {
> global:
>
> rte_dpaa_bpid_info;
> - rte_dpaa_pool_table;
>
> local: *;
> };
> diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
> index 2e6cbe96e..d12360235 100644
> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -248,7 +248,6 @@ EXPERIMENTAL {
> rte_service_map_lcore_get;
> rte_service_map_lcore_set;
> rte_service_probe_capability;
> - rte_service_reset;
> rte_service_run_iter_on_app_lcore;
> rte_service_runstate_get;
> rte_service_runstate_set;
> diff --git a/lib/librte_ether/rte_ethdev_version.map b/lib/librte_ether/rte_ethdev_version.map
> index a5cb372b1..87f02fb74 100644
> --- a/lib/librte_ether/rte_ethdev_version.map
> +++ b/lib/librte_ether/rte_ethdev_version.map
> @@ -156,7 +156,6 @@ DPDK_17.08 {
> rte_flow_copy;
> rte_flow_isolate;
> rte_tm_capabilities_get;
> - rte_tm_get_leaf_nodes;
> rte_tm_hierarchy_commit;
> rte_tm_level_capabilities_get;
> rte_tm_mark_ip_dscp;
> diff --git a/lib/librte_ring/rte_ring_version.map b/lib/librte_ring/rte_ring_version.map
> index 5474b985e..d935efd0d 100644
> --- a/lib/librte_ring/rte_ring_version.map
> +++ b/lib/librte_ring/rte_ring_version.map
> @@ -7,7 +7,6 @@ DPDK_2.0 {
> rte_ring_init;
> rte_ring_list_dump;
> rte_ring_lookup;
> - rte_ring_set_water_mark;
>
> local: *;
> };
> --
> 2.16.1
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Though we should probably figure out a check to catch these getting left behind
when their corresponding symbols are removed
Neil
On Mon, Feb 12, 2018 at 12:41:54PM -0500, Neil Horman wrote:
> On Mon, Feb 12, 2018 at 07:53:05PM +0530, Pavan Nikhilesh wrote:
> > Remove some unused map symbol.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
> > drivers/bus/fslmc/rte_bus_fslmc_version.map | 2 --
> > drivers/mempool/dpaa/rte_mempool_dpaa_version.map | 1 -
> > lib/librte_eal/rte_eal_version.map | 1 -
> > lib/librte_ether/rte_ethdev_version.map | 1 -
> > lib/librte_ring/rte_ring_version.map | 1 -
> > 5 files changed, 6 deletions(-)
> >
> > diff --git a/drivers/bus/fslmc/rte_bus_fslmc_version.map b/drivers/bus/fslmc/rte_bus_fslmc_version.map
> > index 3f1ba130c..b7db07414 100644
> > --- a/drivers/bus/fslmc/rte_bus_fslmc_version.map
> > +++ b/drivers/bus/fslmc/rte_bus_fslmc_version.map
> > @@ -28,7 +28,6 @@ DPDK_17.05 {
> > qbman_eq_desc_set_no_orp;
> > qbman_eq_desc_set_qd;
> > qbman_eq_desc_set_response;
> > - qbman_get_version;
> > qbman_pull_desc_clear;
> > qbman_pull_desc_set_fq;
> > qbman_pull_desc_set_numframes;
> > @@ -41,7 +40,6 @@ DPDK_17.05 {
> > qbman_swp_acquire;
> > qbman_swp_pull;
> > qbman_swp_release;
> > - qbman_swp_send_multiple;
> > rte_fslmc_driver_register;
> > rte_fslmc_driver_unregister;
> > rte_fslmc_vfio_dmamap;
> > diff --git a/drivers/mempool/dpaa/rte_mempool_dpaa_version.map b/drivers/mempool/dpaa/rte_mempool_dpaa_version.map
> > index cc635c736..d05f274d0 100644
> > --- a/drivers/mempool/dpaa/rte_mempool_dpaa_version.map
> > +++ b/drivers/mempool/dpaa/rte_mempool_dpaa_version.map
> > @@ -2,7 +2,6 @@ DPDK_17.11 {
> > global:
> >
> > rte_dpaa_bpid_info;
> > - rte_dpaa_pool_table;
> >
> > local: *;
> > };
> > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
> > index 2e6cbe96e..d12360235 100644
> > --- a/lib/librte_eal/rte_eal_version.map
> > +++ b/lib/librte_eal/rte_eal_version.map
> > @@ -248,7 +248,6 @@ EXPERIMENTAL {
> > rte_service_map_lcore_get;
> > rte_service_map_lcore_set;
> > rte_service_probe_capability;
> > - rte_service_reset;
> > rte_service_run_iter_on_app_lcore;
> > rte_service_runstate_get;
> > rte_service_runstate_set;
> > diff --git a/lib/librte_ether/rte_ethdev_version.map b/lib/librte_ether/rte_ethdev_version.map
> > index a5cb372b1..87f02fb74 100644
> > --- a/lib/librte_ether/rte_ethdev_version.map
> > +++ b/lib/librte_ether/rte_ethdev_version.map
> > @@ -156,7 +156,6 @@ DPDK_17.08 {
> > rte_flow_copy;
> > rte_flow_isolate;
> > rte_tm_capabilities_get;
> > - rte_tm_get_leaf_nodes;
> > rte_tm_hierarchy_commit;
> > rte_tm_level_capabilities_get;
> > rte_tm_mark_ip_dscp;
> > diff --git a/lib/librte_ring/rte_ring_version.map b/lib/librte_ring/rte_ring_version.map
> > index 5474b985e..d935efd0d 100644
> > --- a/lib/librte_ring/rte_ring_version.map
> > +++ b/lib/librte_ring/rte_ring_version.map
> > @@ -7,7 +7,6 @@ DPDK_2.0 {
> > rte_ring_init;
> > rte_ring_list_dump;
> > rte_ring_lookup;
> > - rte_ring_set_water_mark;
> >
> > local: *;
> > };
> > --
> > 2.16.1
> >
> >
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
>
> Though we should probably figure out a check to catch these getting left behind
> when their corresponding symbols are removed
I have written a script to do the same
http://dpdk.org/dev/patchwork/patch/35137/
> Neil
>
Pavan
HI Pavan,
On 2/12/2018 7:53 PM, Pavan Nikhilesh wrote:
> Remove some unused map symbol.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
<snip..>
> diff --git a/drivers/mempool/dpaa/rte_mempool_dpaa_version.map b/drivers/mempool/dpaa/rte_mempool_dpaa_version.map
> index cc635c736..d05f274d0 100644
> --- a/drivers/mempool/dpaa/rte_mempool_dpaa_version.map
> +++ b/drivers/mempool/dpaa/rte_mempool_dpaa_version.map
> @@ -2,7 +2,6 @@ DPDK_17.11 {
> global:
>
> rte_dpaa_bpid_info;
> - rte_dpaa_pool_table;
>
> local: *;
> };
DPAA(x) related changes LGTM
> diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
> index 2e6cbe96e..d12360235 100644
> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -248,7 +248,6 @@ EXPERIMENTAL {
> rte_service_map_lcore_get;
> rte_service_map_lcore_set;
> rte_service_probe_capability;
> - rte_service_reset;
It is not a good idea to remove these APIs form MAP
Some of these are external APIs. The existing examples may not be using
them in DPDK, but a real app may use that. The same comment apply to
other removal for external APIs.
Cristian, what is your opinion.
> rte_service_run_iter_on_app_lcore;
> rte_service_runstate_get;
> rte_service_runstate_set;
> diff --git a/lib/librte_ether/rte_ethdev_version.map b/lib/librte_ether/rte_ethdev_version.map
> index a5cb372b1..87f02fb74 100644
> --- a/lib/librte_ether/rte_ethdev_version.map
> +++ b/lib/librte_ether/rte_ethdev_version.map
> @@ -156,7 +156,6 @@ DPDK_17.08 {
> rte_flow_copy;
> rte_flow_isolate;
> rte_tm_capabilities_get;
> - rte_tm_get_leaf_nodes;
> rte_tm_hierarchy_commit;
> rte_tm_level_capabilities_get;
> rte_tm_mark_ip_dscp;
> diff --git a/lib/librte_ring/rte_ring_version.map b/lib/librte_ring/rte_ring_version.map
> index 5474b985e..d935efd0d 100644
> --- a/lib/librte_ring/rte_ring_version.map
> +++ b/lib/librte_ring/rte_ring_version.map
> @@ -7,7 +7,6 @@ DPDK_2.0 {
> rte_ring_init;
> rte_ring_list_dump;
> rte_ring_lookup;
> - rte_ring_set_water_mark;
>
> local: *;
> };
>
On 2/13/2018 9:16 AM, Hemant Agrawal wrote:
> HI Pavan,
>
> On 2/12/2018 7:53 PM, Pavan Nikhilesh wrote:
>> Remove some unused map symbol.
>>
>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
>> ---
> <snip..>
>> diff --git a/drivers/mempool/dpaa/rte_mempool_dpaa_version.map
>> b/drivers/mempool/dpaa/rte_mempool_dpaa_version.map
>> index cc635c736..d05f274d0 100644
>> --- a/drivers/mempool/dpaa/rte_mempool_dpaa_version.map
>> +++ b/drivers/mempool/dpaa/rte_mempool_dpaa_version.map
>> @@ -2,7 +2,6 @@ DPDK_17.11 {
>> global:
>> rte_dpaa_bpid_info;
>> - rte_dpaa_pool_table;
>> local: *;
>> };
>
> DPAA(x) related changes LGTM
>
>> diff --git a/lib/librte_eal/rte_eal_version.map
>> b/lib/librte_eal/rte_eal_version.map
>> index 2e6cbe96e..d12360235 100644
>> --- a/lib/librte_eal/rte_eal_version.map
>> +++ b/lib/librte_eal/rte_eal_version.map
>> @@ -248,7 +248,6 @@ EXPERIMENTAL {
>> rte_service_map_lcore_get;
>> rte_service_map_lcore_set;
>> rte_service_probe_capability;
>> - rte_service_reset;
>
> It is not a good idea to remove these APIs form MAP
> Some of these are external APIs. The existing examples may not be using
> them in DPDK, but a real app may use that. The same comment apply to
> other removal for external APIs.
>
Please ignore my comments. I was too quick in reviewing it.
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> Cristian, what is your opinion.
>
>> rte_service_run_iter_on_app_lcore;
>> rte_service_runstate_get;
>> rte_service_runstate_set;
>> diff --git a/lib/librte_ether/rte_ethdev_version.map
>> b/lib/librte_ether/rte_ethdev_version.map
>> index a5cb372b1..87f02fb74 100644
>> --- a/lib/librte_ether/rte_ethdev_version.map
>> +++ b/lib/librte_ether/rte_ethdev_version.map
>> @@ -156,7 +156,6 @@ DPDK_17.08 {
>> rte_flow_copy;
>> rte_flow_isolate;
>> rte_tm_capabilities_get;
>> - rte_tm_get_leaf_nodes;
>> rte_tm_hierarchy_commit;
>> rte_tm_level_capabilities_get;
>> rte_tm_mark_ip_dscp;
>> diff --git a/lib/librte_ring/rte_ring_version.map
>> b/lib/librte_ring/rte_ring_version.map
>> index 5474b985e..d935efd0d 100644
>> --- a/lib/librte_ring/rte_ring_version.map
>> +++ b/lib/librte_ring/rte_ring_version.map
>> @@ -7,7 +7,6 @@ DPDK_2.0 {
>> rte_ring_init;
>> rte_ring_list_dump;
>> rte_ring_lookup;
>> - rte_ring_set_water_mark;
>> local: *;
>> };
>>
>
>
On 2/13/2018 4:56 AM, Hemant Agrawal wrote:
> On 2/13/2018 9:16 AM, Hemant Agrawal wrote:
>> HI Pavan,
>>
>> On 2/12/2018 7:53 PM, Pavan Nikhilesh wrote:
>>> Remove some unused map symbol.
>>>
>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
<...>
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
12/02/2018 18:41, Neil Horman:
> On Mon, Feb 12, 2018 at 07:53:05PM +0530, Pavan Nikhilesh wrote:
> > Remove some unused map symbol.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
Applied, thanks
@@ -28,7 +28,6 @@ DPDK_17.05 {
qbman_eq_desc_set_no_orp;
qbman_eq_desc_set_qd;
qbman_eq_desc_set_response;
- qbman_get_version;
qbman_pull_desc_clear;
qbman_pull_desc_set_fq;
qbman_pull_desc_set_numframes;
@@ -41,7 +40,6 @@ DPDK_17.05 {
qbman_swp_acquire;
qbman_swp_pull;
qbman_swp_release;
- qbman_swp_send_multiple;
rte_fslmc_driver_register;
rte_fslmc_driver_unregister;
rte_fslmc_vfio_dmamap;
@@ -2,7 +2,6 @@ DPDK_17.11 {
global:
rte_dpaa_bpid_info;
- rte_dpaa_pool_table;
local: *;
};
@@ -248,7 +248,6 @@ EXPERIMENTAL {
rte_service_map_lcore_get;
rte_service_map_lcore_set;
rte_service_probe_capability;
- rte_service_reset;
rte_service_run_iter_on_app_lcore;
rte_service_runstate_get;
rte_service_runstate_set;
@@ -156,7 +156,6 @@ DPDK_17.08 {
rte_flow_copy;
rte_flow_isolate;
rte_tm_capabilities_get;
- rte_tm_get_leaf_nodes;
rte_tm_hierarchy_commit;
rte_tm_level_capabilities_get;
rte_tm_mark_ip_dscp;
@@ -7,7 +7,6 @@ DPDK_2.0 {
rte_ring_init;
rte_ring_list_dump;
rte_ring_lookup;
- rte_ring_set_water_mark;
local: *;
};