[dpdk-dev] net/vmxnet3: remove useless copy when setting MAC address
Checks
Commit Message
This operation is already done by the ethdev layer, it should not
be done by the driver.
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 -
1 file changed, 1 deletion(-)
Comments
On 1/3/2018 1:32 PM, Olivier Matz wrote:
> This operation is already done by the ethdev layer, it should not
> be done by the driver.
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
On 1/12/2018 6:40 PM, Ferruh Yigit wrote:
> On 1/3/2018 1:32 PM, Olivier Matz wrote:
>> This operation is already done by the ethdev layer, it should not
>> be done by the driver.
>>
>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
@@ -1149,7 +1149,6 @@ vmxnet3_mac_addr_set(struct rte_eth_dev *dev, struct ether_addr *mac_addr)
struct vmxnet3_hw *hw = dev->data->dev_private;
ether_addr_copy(mac_addr, (struct ether_addr *)(hw->perm_addr));
- ether_addr_copy(mac_addr, &dev->data->mac_addrs[0]);
vmxnet3_write_mac(hw, mac_addr->addr_bytes);
}