[dpdk-dev,6/7] devtools/test-build: add MRVL NET PMD to test-build
Checks
Commit Message
Add MRVL NET PMD to test build tool.
Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
---
devtools/test-build.sh | 1 +
1 file changed, 1 insertion(+)
Comments
On 12/1/2017 7:19 AM, Tomasz Duszynski wrote:
> Add MRVL NET PMD to test build tool.
>
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> ---
> devtools/test-build.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/devtools/test-build.sh b/devtools/test-build.sh
> index 092d3a7..78609c9 100755
> --- a/devtools/test-build.sh
> +++ b/devtools/test-build.sh
> @@ -197,6 +197,7 @@ config () # <directory> <target> <options>
> sed -ri 's,(SCHED_.*=)n,\1y,' $1/.config
> test -z "$LIBMUSDK_PATH" || \
> sed -ri 's,(PMD_MRVL_CRYPTO=)n,\1y,' $1/.config
> + sed -ri 's,(MRVL_PMD=)n,\1y,' $1/.config
Won't MRVL_PMD also require LIBMUSDK_PATH?
For this case check doesn't cover it and will be enabled always.
> build_config_hook $1 $2 $3
>
> # Explicit enabler/disabler (uppercase)
>
On Mon, Dec 04, 2017 at 04:48:51PM -0800, Ferruh Yigit wrote:
> On 12/1/2017 7:19 AM, Tomasz Duszynski wrote:
> > Add MRVL NET PMD to test build tool.
> >
> > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> > ---
> > devtools/test-build.sh | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/devtools/test-build.sh b/devtools/test-build.sh
> > index 092d3a7..78609c9 100755
> > --- a/devtools/test-build.sh
> > +++ b/devtools/test-build.sh
> > @@ -197,6 +197,7 @@ config () # <directory> <target> <options>
> > sed -ri 's,(SCHED_.*=)n,\1y,' $1/.config
> > test -z "$LIBMUSDK_PATH" || \
> > sed -ri 's,(PMD_MRVL_CRYPTO=)n,\1y,' $1/.config
> > + sed -ri 's,(MRVL_PMD=)n,\1y,' $1/.config
>
> Won't MRVL_PMD also require LIBMUSDK_PATH?
> For this case check doesn't cover it and will be enabled always.
>
Good catch. Will be fixed in v3.
> > build_config_hook $1 $2 $3
> >
> > # Explicit enabler/disabler (uppercase)
> >
>
--
- Tomasz Duszyński
@@ -197,6 +197,7 @@ config () # <directory> <target> <options>
sed -ri 's,(SCHED_.*=)n,\1y,' $1/.config
test -z "$LIBMUSDK_PATH" || \
sed -ri 's,(PMD_MRVL_CRYPTO=)n,\1y,' $1/.config
+ sed -ri 's,(MRVL_PMD=)n,\1y,' $1/.config
build_config_hook $1 $2 $3
# Explicit enabler/disabler (uppercase)