Message ID | 20170915173612.13636-2-luca.boccassi@gmail.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Bruce Richardson |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 47B09325C; Fri, 15 Sep 2017 19:36:37 +0200 (CEST) Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id D64213238 for <dev@dpdk.org>; Fri, 15 Sep 2017 19:36:36 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id f4so3364982wmh.4 for <dev@dpdk.org>; Fri, 15 Sep 2017 10:36:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=qT8jYN+F6vqvhzR7UE16N8TzfzTbmK3zofhQSm+U/q0=; b=bJHC9G+Rgx2VdG+vbvxOvN38fCQKexsa/YJmedFRLvG43vo2GKCUSnYD0Vm1ulT3BL Wr3tw85mm1x9c2a+llFIp4BktSjM7Kf0KEHsHK/BZn/+XVTCPHL3pE9xtnDwNItpqqRW tP3QnEaycWk+lTwpBLECmut+TtE2Eg5Fy4WWvv5do3l4jkOj9pmcfyxKbJmWmWedfjld bkOBk2tzLMdObzv9YB+vzZX0qcDON0uPqj7h4hn/AOslaEKo+cRz2u65J0zOyzfpSlRk +CdkYeZ5K2r803rNvaKh6Hti5sudNm9pc5U6o6ZhH7oeKph0vZxwI23GlhFYTq0a1ghx E7Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=qT8jYN+F6vqvhzR7UE16N8TzfzTbmK3zofhQSm+U/q0=; b=psg9lzO1Ap/AzTVkcM3C3TLyQCyxzR+2e2GWiUQHPF8O+amyQl8l5PjMC3+bXlAuZG hrjpCJdyCMowmXAPnN/omGPtiyaYlHfnCMa9/tR9//lGd3+N0TaQyjKAcD3wHktgfFGv 9Qel1sOTVDFtacD3Ls5jfgC+vS0drw3bsxVkBOpgStPS+DUUzNMVWF2Dj3bLR4Jp6UNL Wp7O6sCKhwX5UP9yaQyB3zHxvGFwBVwb5rW/kyJDx17hMy+wHlvjTsHqfd1XLVaxJ85V hU9PH25FNtag9S0VPjS09p/8gWuVbo4DnpjKtFtgBLYkBq9mpx+nA5oGUX9swrVwu3Px W+Wg== X-Gm-Message-State: AHPjjUhTKOFWJ06DfYoaRN761NW4bCf34lBIWr0P3984d0HNG/NGjM8c x8lBcW5GGQYmEZUhazI= X-Google-Smtp-Source: AOwi7QCratNmy9+cWjRDcH6abFefFiKFBaZfkL/Rt3phecuXCfg2zmMe40aCcDKvltERT4fXyU8Nzw== X-Received: by 10.28.86.67 with SMTP id k64mr3545773wmb.143.1505496996190; Fri, 15 Sep 2017 10:36:36 -0700 (PDT) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id u13sm869309wre.11.2017.09.15.10.36.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Sep 2017 10:36:35 -0700 (PDT) From: luca.boccassi@gmail.com To: dev@dpdk.org Cc: bruce.richardson@intel.com, Luca Boccassi <bluca@debian.org> Date: Fri, 15 Sep 2017 18:36:10 +0100 Message-Id: <20170915173612.13636-2-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170915173612.13636-1-luca.boccassi@gmail.com> References: <20170915173612.13636-1-luca.boccassi@gmail.com> Subject: [dpdk-dev] [PATCH 1/3] build: rename pkgconfig to libdpdk.pc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | success | Compilation OK |
Commit Message
Luca Boccassi
Sept. 15, 2017, 5:36 p.m. UTC
From: Luca Boccassi <bluca@debian.org> In Debian and Ubuntu we have been shipping a pkgconfig file for DPDK for more than a year now, and the filename is libdpdk.pc. A few downstream projects, like OVS and Collectd, have adopted the use of libdpdk.pc in their build systems as well. In order to maintain backward compatibility, rename the file from DPDK.pc to libdpdk.pc. Signed-off-by: Luca Boccassi <bluca@debian.org> --- meson.build | 1 + 1 file changed, 1 insertion(+)
Comments
On Fri, Sep 15, 2017 at 06:36:10PM +0100, luca.boccassi@gmail.com wrote: > From: Luca Boccassi <bluca@debian.org> > > In Debian and Ubuntu we have been shipping a pkgconfig file for DPDK > for more than a year now, and the filename is libdpdk.pc. > A few downstream projects, like OVS and Collectd, have adopted the > use of libdpdk.pc in their build systems as well. > In order to maintain backward compatibility, rename the file from > DPDK.pc to libdpdk.pc. > > Signed-off-by: Luca Boccassi <bluca@debian.org> > --- I find the 'lib' bit strange, but if that is what is already out there, then we should keep it for compatibility. In future, we might create two pkgconfig files to transition over to a new name, but to start with lets use what is being looked for by our dependencies. Acked-by: Bruce Richardson <bruce.richardson@intel.com>
On Mon, 2017-09-18 at 12:09 +0100, Bruce Richardson wrote: > On Fri, Sep 15, 2017 at 06:36:10PM +0100, luca.boccassi@gmail.com > wrote: > > From: Luca Boccassi <bluca@debian.org> > > > > In Debian and Ubuntu we have been shipping a pkgconfig file for > > DPDK > > for more than a year now, and the filename is libdpdk.pc. > > A few downstream projects, like OVS and Collectd, have adopted the > > use of libdpdk.pc in their build systems as well. > > In order to maintain backward compatibility, rename the file from > > DPDK.pc to libdpdk.pc. > > > > Signed-off-by: Luca Boccassi <bluca@debian.org> > > --- > > I find the 'lib' bit strange, but if that is what is already out > there, > then we should keep it for compatibility. Not sure where the original name came from, it's been like that for a few years - it might have been my fault :-) In Debian/Ubuntu libraries development headers, unversioned shared object symlinks and static archives always ship in packages named libfoo[api-ver]-dev. This is strictly enforced by policy. We have libdpdk-dev for example. Then, usually, pkg-config files follow the same naming convention, so that if you want to build against libfoo-dev you use pkg-config libfoo. This makes it nice and predictable. But IIRC it's not enforced, and not universally followed. > In future, we might create two pkgconfig files to transition over to > a > new name, but to start with lets use what is being looked for by our > dependencies. > > Acked-by: Bruce Richardson <bruce.richardson@intel.com> Even just a symlink should work fine, at least it does with the pkg- config I have on Debian. Should not cause issues on any implementation.
diff --git a/meson.build b/meson.build index 6ad3e8053..f41fb4120 100644 --- a/meson.build +++ b/meson.build @@ -81,6 +81,7 @@ endif pkg = import('pkgconfig') pkg.generate(name: meson.project_name(), + filebase: 'lib' + meson.project_name().to_lower(), version: meson.project_version(), libraries: dpdk_libraries, description: 'The Data Plane Development Kit (DPDK)',