[dpdk-dev,v2] armv8/config: enable igb_uio on arm64 platform

Message ID 1505361227-29822-1-git-send-email-jianbo.liu@linaro.org (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Jianbo Liu Sept. 14, 2017, 3:53 a.m. UTC
  The kernel patch was merged to support pci resource mapping.
https://patchwork.kernel.org/patch/9677441/

So enable igu_uio in the default arm64 configuration.

v2:
  - keep headline format

Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
---
 config/common_armv8a_linuxapp | 2 --
 1 file changed, 2 deletions(-)
  

Comments

Santosh Shukla Sept. 14, 2017, 5:23 a.m. UTC | #1
On Thursday 14 September 2017 09:23 AM, Jianbo Liu wrote:
> The kernel patch was merged to support pci resource mapping.
> https://patchwork.kernel.org/patch/9677441/
>
> So enable igu_uio in the default arm64 configuration.
>
> v2:
>   - keep headline format
>
> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
> ---

Perhaps remove v2 from desciption.
Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
  
Ferruh Yigit Sept. 14, 2017, 9:41 a.m. UTC | #2
On 9/14/2017 6:23 AM, santosh wrote:
> 
> On Thursday 14 September 2017 09:23 AM, Jianbo Liu wrote:
>> The kernel patch was merged to support pci resource mapping.
>> https://patchwork.kernel.org/patch/9677441/
>>
>> So enable igu_uio in the default arm64 configuration.
>>
>> v2:
>>   - keep headline format
>>
>> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
>> ---
> 
> Perhaps remove v2 from desciption.

A quick tip, if you add changelog after "---" in commit log, this will
be visible in commit log and the patch itself, but will be removed
automatically by git am, making maintainer life easy :)

> Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
>
  
Jianbo Liu Sept. 14, 2017, 10:05 a.m. UTC | #3
On 14 September 2017 at 17:41, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 9/14/2017 6:23 AM, santosh wrote:
>>
>> On Thursday 14 September 2017 09:23 AM, Jianbo Liu wrote:
>>> The kernel patch was merged to support pci resource mapping.
>>> https://patchwork.kernel.org/patch/9677441/
>>>
>>> So enable igu_uio in the default arm64 configuration.
>>>
>>> v2:
>>>   - keep headline format
>>>
>>> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
>>> ---
>>
>> Perhaps remove v2 from desciption.
>
> A quick tip, if you add changelog after "---" in commit log, this will
> be visible in commit log and the patch itself, but will be removed
> automatically by git am, making maintainer life easy :)
>

Thanks a lot! It's really a great help...

>> Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
>>
>
  
Hemant Agrawal Sept. 14, 2017, 11:31 a.m. UTC | #4
On 9/14/2017 9:23 AM, Jianbo Liu wrote:
> The kernel patch was merged to support pci resource mapping.
> https://patchwork.kernel.org/patch/9677441/
>
> So enable igu_uio in the default arm64 configuration.
>
> v2:
>   - keep headline format
>
> Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
> ---
>  config/common_armv8a_linuxapp | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/config/common_armv8a_linuxapp b/config/common_armv8a_linuxapp
> index 880313a..6732d1e 100644
> --- a/config/common_armv8a_linuxapp
> +++ b/config/common_armv8a_linuxapp
> @@ -44,8 +44,6 @@ CONFIG_RTE_FORCE_INTRINSICS=y
>  # to address minimum DMA alignment across all arm64 implementations.
>  CONFIG_RTE_CACHE_LINE_SIZE=128
>
> -CONFIG_RTE_EAL_IGB_UIO=n
> -
>  CONFIG_RTE_LIBRTE_FM10K_PMD=n
>  CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
>  CONFIG_RTE_LIBRTE_AVP_PMD=n
>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
  
Thomas Monjalon Oct. 6, 2017, 9:39 p.m. UTC | #5
14/09/2017 13:31, Hemant Agrawal:
> On 9/14/2017 9:23 AM, Jianbo Liu wrote:
> > The kernel patch was merged to support pci resource mapping.
> > https://patchwork.kernel.org/patch/9677441/
> >
> > So enable igu_uio in the default arm64 configuration.
> >
> > v2:
> >   - keep headline format
> >
> > Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Applied, thanks
  

Patch

diff --git a/config/common_armv8a_linuxapp b/config/common_armv8a_linuxapp
index 880313a..6732d1e 100644
--- a/config/common_armv8a_linuxapp
+++ b/config/common_armv8a_linuxapp
@@ -44,8 +44,6 @@  CONFIG_RTE_FORCE_INTRINSICS=y
 # to address minimum DMA alignment across all arm64 implementations.
 CONFIG_RTE_CACHE_LINE_SIZE=128
 
-CONFIG_RTE_EAL_IGB_UIO=n
-
 CONFIG_RTE_LIBRTE_FM10K_PMD=n
 CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
 CONFIG_RTE_LIBRTE_AVP_PMD=n