[dpdk-dev,4/6] net/vmxnet3: Make vmxnet3_process_events less noisy
Checks
Commit Message
From: Robert Shearman <rshearma@brocade.com>
Make vmxnet3_process_events less noisy by removing logging when there
are no events to process and by making link, device-change and debug
events DEBUG level rather than ERR.
Change these to use PMD_DRV_LOG instead of PMD_INIT_LOG since they
don't happen at device init.
Signed-off-by: Robert Shearman <rshearma@brocade.com>
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
Comments
On Fri, 19 May 2017, Charles (Chas) Williams wrote:
> From: Robert Shearman <rshearma@brocade.com>
>
> Make vmxnet3_process_events less noisy by removing logging when there
> are no events to process and by making link, device-change and debug
> events DEBUG level rather than ERR.
>
> Change these to use PMD_DRV_LOG instead of PMD_INIT_LOG since they
> don't happen at device init.
>
> Signed-off-by: Robert Shearman <rshearma@brocade.com>
Acked-by: Shrikrishna Khare <skhare@vmware.com>
@@ -1305,10 +1305,8 @@ vmxnet3_process_events(struct rte_eth_dev *dev)
struct vmxnet3_hw *hw = dev->data->dev_private;
uint32_t events = hw->shared->ecr;
- if (!events) {
- PMD_INIT_LOG(ERR, "No events to process");
+ if (!events)
return;
- }
/*
* ECR bits when written with 1b are cleared. Hence write
@@ -1318,9 +1316,7 @@ vmxnet3_process_events(struct rte_eth_dev *dev)
/* Check if link state has changed */
if (events & VMXNET3_ECR_LINK) {
- PMD_INIT_LOG(ERR,
- "Process events in %s(): VMXNET3_ECR_LINK event",
- __func__);
+ PMD_DRV_LOG(DEBUG, "Process events: VMXNET3_ECR_LINK event");
if (vmxnet3_dev_link_update(dev, 0) == 0)
_rte_eth_dev_callback_process(dev,
RTE_ETH_EVENT_INTR_LSC,
@@ -1333,11 +1329,11 @@ vmxnet3_process_events(struct rte_eth_dev *dev)
VMXNET3_CMD_GET_QUEUE_STATUS);
if (hw->tqd_start->status.stopped)
- PMD_INIT_LOG(ERR, "tq error 0x%x",
- hw->tqd_start->status.error);
+ PMD_DRV_LOG(ERR, "tq error 0x%x",
+ hw->tqd_start->status.error);
if (hw->rqd_start->status.stopped)
- PMD_INIT_LOG(ERR, "rq error 0x%x",
+ PMD_DRV_LOG(ERR, "rq error 0x%x",
hw->rqd_start->status.error);
/* Reset the device */
@@ -1345,10 +1341,10 @@ vmxnet3_process_events(struct rte_eth_dev *dev)
}
if (events & VMXNET3_ECR_DIC)
- PMD_INIT_LOG(ERR, "Device implementation change event.");
+ PMD_DRV_LOG(DEBUG, "Device implementation change event.");
if (events & VMXNET3_ECR_DEBUG)
- PMD_INIT_LOG(ERR, "Debug event generated by device.");
+ PMD_DRV_LOG(DEBUG, "Debug event generated by device.");
}
static void