Message ID | 1707851523-27998-1-git-send-email-roretzla@linux.microsoft.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02CF343B10; Tue, 13 Feb 2024 20:12:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B79342E1B; Tue, 13 Feb 2024 20:12:07 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 954F942E10 for <dev@dpdk.org>; Tue, 13 Feb 2024 20:12:05 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id B1A8A207EC9E; Tue, 13 Feb 2024 11:12:04 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B1A8A207EC9E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1707851524; bh=mu7JR/mIhwP29cB74x0OlqmARFty4t34ulorByvyDDc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=njeQ0+baaGq1h3Ehk3i0REhqNn9ud05hX7aJrQIjoKFCZk0ihwi9K4t5xQlO/Tu8q 3rvsYw9/o/N1JEcqV3pCl0Mb6gFvgUOsxzVxpdPmnbQiPrHhm8jXvjal7gtcGugRJE YT1M5NSgJbHuMtVIsuNvt5L6EOwTs4Fh1QkDrkZk= From: Tyler Retzlaff <roretzla@linux.microsoft.com> To: dev@dpdk.org Cc: Kai Ji <kai.ji@intel.com>, Pablo de Lara <pablo.de.lara.guarch@intel.com>, bruce.richardson@intel.com, david.marchand@redhat.com, Tyler Retzlaff <roretzla@linux.microsoft.com> Subject: [PATCH v3 0/3] remove __typeof__ from expansion of per lcore macros Date: Tue, 13 Feb 2024 11:12:00 -0800 Message-Id: <1707851523-27998-1-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1703006864-27378-1-git-send-email-roretzla@linux.microsoft.com> References: <1703006864-27378-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
remove __typeof__ from expansion of per lcore macros
|
|
Message
Tyler Retzlaff
Feb. 13, 2024, 7:12 p.m. UTC
The design of the macros requires a type to be provided to the macro. By expanding the type parameter inside of typeof it also inadvertently allows an expression to be used which appears not to have been intended after evaluating the parameter name and existing macro use. Technically this is an API break but only for applications that were using these macros outside of the original design intent. v3: * provide notice in release_24_03.rst about change in macro expansion. v2: * add additional patch to adjust usage for crypto/ipsec_mb Tyler Retzlaff (3): eal: provide type to per lcore macro crypto/ipsec_mb: provide type to per lcore macro eal: remove typeof from per lcore macros doc/guides/rel_notes/release_24_03.rst | 5 +++++ drivers/crypto/ipsec_mb/pmd_aesni_gcm_priv.h | 2 +- lib/eal/common/eal_common_errno.c | 2 +- lib/eal/include/rte_per_lcore.h | 8 ++++---- 4 files changed, 11 insertions(+), 6 deletions(-)
Comments
On Tue, Feb 13, 2024 at 8:12 PM Tyler Retzlaff <roretzla@linux.microsoft.com> wrote: > > The design of the macros requires a type to be provided to the macro. > > By expanding the type parameter inside of typeof it also inadvertently > allows an expression to be used which appears not to have been intended > after evaluating the parameter name and existing macro use. > > Technically this is an API break but only for applications that were > using these macros outside of the original design intent. > > v3: > * provide notice in release_24_03.rst about change in macro > expansion. > v2: > * add additional patch to adjust usage for crypto/ipsec_mb > > Tyler Retzlaff (3): > eal: provide type to per lcore macro > crypto/ipsec_mb: provide type to per lcore macro > eal: remove typeof from per lcore macros > > doc/guides/rel_notes/release_24_03.rst | 5 +++++ > drivers/crypto/ipsec_mb/pmd_aesni_gcm_priv.h | 2 +- > lib/eal/common/eal_common_errno.c | 2 +- > lib/eal/include/rte_per_lcore.h | 8 ++++---- > 4 files changed, 11 insertions(+), 6 deletions(-) Thanks Tyler. Series applied.