[dpdk-dev] net/bnxt: make eth dev ops struct const

Message ID 20170116132739.30872-1-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel compilation success Compilation OK

Commit Message

Ferruh Yigit Jan. 16, 2017, 1:27 p.m. UTC
  Reported-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Ferruh Yigit Jan. 16, 2017, 1:44 p.m. UTC | #1
On 1/16/2017 1:27 PM, Ferruh Yigit wrote:
> Reported-by: Stephen Hemminger <sthemmin@microsoft.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Both applied to dpdk-next-net/master, thanks.
  
Thomas Monjalon Jan. 17, 2017, 8:57 p.m. UTC | #2
2017-01-16 13:44, Ferruh Yigit:
> On 1/16/2017 1:27 PM, Ferruh Yigit wrote:
> > Reported-by: Stephen Hemminger <sthemmin@microsoft.com>
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Both applied to dpdk-next-net/master, thanks.

I must admit it is the force of Stephen:
he sends just a cover letter and do not reply, so you do the patch for him :)
  
Stephen Hemminger Jan. 17, 2017, 10:38 p.m. UTC | #3
On Tue, 17 Jan 2017 21:57:33 +0100
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> 2017-01-16 13:44, Ferruh Yigit:
> > On 1/16/2017 1:27 PM, Ferruh Yigit wrote:  
> > > Reported-by: Stephen Hemminger <sthemmin@microsoft.com>
> > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>  
> > 
> > Both applied to dpdk-next-net/master, thanks.  
> 
> I must admit it is the force of Stephen:
> he sends just a cover letter and do not reply, so you do the patch for him :)

Actually I did do the patches but git send-email ate them :-)
  
Ferruh Yigit Jan. 18, 2017, 12:01 p.m. UTC | #4
On 1/16/2017 1:44 PM, Ferruh Yigit wrote:
> On 1/16/2017 1:27 PM, Ferruh Yigit wrote:
>> Reported-by: Stephen Hemminger <sthemmin@microsoft.com>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Both applied to dpdk-next-net/master, thanks.
> 

Updated mail address of Stephen to the mail address initially used:
Reported-by: Stephen Hemminger <stephen@networkplumber.org>
  

Patch

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 1252a36..501c97d 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -1002,7 +1002,7 @@  static int bnxt_flow_ctrl_set_op(struct rte_eth_dev *dev,
  * Initialization
  */
 
-static struct eth_dev_ops bnxt_dev_ops = {
+static const struct eth_dev_ops bnxt_dev_ops = {
 	.dev_infos_get = bnxt_dev_info_get_op,
 	.dev_close = bnxt_dev_close_op,
 	.dev_configure = bnxt_dev_configure_op,