diff mbox

[dpdk-dev] vmxnet3: remove 0x prefix for %p format

Message ID 1466679174-6538-1-git-send-email-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Bruce Richardson
Headers

Commit Message

Ferruh Yigit June 23, 2016, 10:52 a.m. UTC 
  To prevent double 0x in logs

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 drivers/net/vmxnet3/vmxnet3_rxtx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Yong Wang June 23, 2016, 8:45 p.m. UTC | #1 
> On Jun 23, 2016, at 3:52 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
> To prevent double 0x in logs
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> —

Acked-by: Yong Wang <yongwang@vmware.com>

> drivers/net/vmxnet3/vmxnet3_rxtx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
> index ccafc0c..1e0fde0 100644
> --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
> +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
> @@ -96,7 +96,7 @@ vmxnet3_rxq_dump(struct vmxnet3_rx_queue *rxq)
> 		return;
> 
> 	PMD_RX_LOG(DEBUG,
> -		   "RXQ: cmd0 base : 0x%p cmd1 base : 0x%p comp ring base : 0x%p.",
> +		   "RXQ: cmd0 base : %p cmd1 base : %p comp ring base : %p.",
> 		   rxq->cmd_ring[0].base, rxq->cmd_ring[1].base, rxq->comp_ring.base);
> 	PMD_RX_LOG(DEBUG,
> 		   "RXQ: cmd0 basePA : 0x%lx cmd1 basePA : 0x%lx comp ring basePA : 0x%lx.",
> @@ -126,7 +126,7 @@ vmxnet3_txq_dump(struct vmxnet3_tx_queue *txq)
> 	if (txq == NULL)
> 		return;
> 
> -	PMD_TX_LOG(DEBUG, "TXQ: cmd base : 0x%p comp ring base : 0x%p data ring base : 0x%p.",
> +	PMD_TX_LOG(DEBUG, "TXQ: cmd base : %p comp ring base : %p data ring base : %p.",
> 		   txq->cmd_ring.base, txq->comp_ring.base, txq->data_ring.base);
> 	PMD_TX_LOG(DEBUG, "TXQ: cmd basePA : 0x%lx comp ring basePA : 0x%lx data ring basePA : 0x%lx.",
> 		   (unsigned long)txq->cmd_ring.basePA,
> -- 
> 2.5.5
>
Bruce Richardson June 24, 2016, 4:44 p.m. UTC | #2 
On Thu, Jun 23, 2016 at 01:45:43PM -0700, Yong Wang wrote:
> > On Jun 23, 2016, at 3:52 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> > 
> > To prevent double 0x in logs

The commit message would be better as the title and vice versa, I think.

> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > —
> 
> Acked-by: Yong Wang <yongwang@vmware.com>
> 

Applied to dpdk-next-net/rel_16_07 with updated title.

/Bruce
diff mbox

Patch

diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
index ccafc0c..1e0fde0 100644
--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
@@ -96,7 +96,7 @@  vmxnet3_rxq_dump(struct vmxnet3_rx_queue *rxq)
 		return;
 
 	PMD_RX_LOG(DEBUG,
-		   "RXQ: cmd0 base : 0x%p cmd1 base : 0x%p comp ring base : 0x%p.",
+		   "RXQ: cmd0 base : %p cmd1 base : %p comp ring base : %p.",
 		   rxq->cmd_ring[0].base, rxq->cmd_ring[1].base, rxq->comp_ring.base);
 	PMD_RX_LOG(DEBUG,
 		   "RXQ: cmd0 basePA : 0x%lx cmd1 basePA : 0x%lx comp ring basePA : 0x%lx.",
@@ -126,7 +126,7 @@  vmxnet3_txq_dump(struct vmxnet3_tx_queue *txq)
 	if (txq == NULL)
 		return;
 
-	PMD_TX_LOG(DEBUG, "TXQ: cmd base : 0x%p comp ring base : 0x%p data ring base : 0x%p.",
+	PMD_TX_LOG(DEBUG, "TXQ: cmd base : %p comp ring base : %p data ring base : %p.",
 		   txq->cmd_ring.base, txq->comp_ring.base, txq->data_ring.base);
 	PMD_TX_LOG(DEBUG, "TXQ: cmd basePA : 0x%lx comp ring basePA : 0x%lx data ring basePA : 0x%lx.",
 		   (unsigned long)txq->cmd_ring.basePA,