Message ID | 20231028014611.4086500-1-haijie1@huawei.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38B514321C; Sat, 28 Oct 2023 03:49:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28421406FF; Sat, 28 Oct 2023 03:49:46 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 8A88D40291 for <dev@dpdk.org>; Sat, 28 Oct 2023 03:49:39 +0200 (CEST) Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SHMp945B2zrSqY for <dev@dpdk.org>; Sat, 28 Oct 2023 09:46:41 +0800 (CST) Received: from localhost.localdomain (10.67.165.2) by kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Sat, 28 Oct 2023 09:49:37 +0800 From: Jie Hai <haijie1@huawei.com> To: <dev@dpdk.org> CC: <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <liudongdong3@huawei.com>, <haijie1@huawei.com> Subject: [PATCH v7 0/9] support setting and querying RSS algorithms Date: Sat, 28 Oct 2023 09:46:02 +0800 Message-ID: <20231028014611.4086500-1-haijie1@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20231027092836.445224-1-haijie1@huawei.com> References: <20231027092836.445224-1-haijie1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.67.165.2] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500020.china.huawei.com (7.221.188.8) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
support setting and querying RSS algorithms
|
|
Message
Jie Hai
Oct. 28, 2023, 1:46 a.m. UTC
This patchset is to support setting and querying RSS algorithms. For this purpose, field "rss_algo_capa" is added to ``rte_eth_dev_info`` and field "algorithm" is added to ``rte_eth_rss_conf``. The drivers should reports their "rss_algo_capa" if they support updating RSS algorithms. Otherwise, the "rss_algo_capa" is set to RTE_ETH_HASH_ALGO_CAPA_MASK(DEFAULT). The app configures RSS algorithms by field "algorithm" and the related API should verify "algorithm" with "rss_algo_capa". -- v7: 1. fix compile error. 2. add signed-off-by to patch[4/9]. v6: 1. rewrite some comments. 2. add "rss_algo_capa" for `rte_eth_dev_info``. 3. add new API to get name of RSS algorithms v5: 1. rewrite some comments. 2. check RSS algorithm for drivers supporting RSS. 3. change field "func" of rss_conf to "algorithm". 4. fix commit log for [PATCH v4 4/7]. 5. add Acked-by Reshma Pattan. 6. add symmetric_toeplitz_sort for showing. 7. change "hf" to "hash function" for showing. v4: 1. recomment some definitions related to RSS. 2. allocate static memory for rss_key instead of dynamic. 3. use array of strings to get the name of rss algorithm. 4. add display of rss algorithm with testpmd. v3: 1. fix commit log for PATCH [1/5]. 2. make RSS ABI changes description to start the actual text at the margin. 3. move defnition of enum rte_eth_hash_function to rte_ethdev.h. 4. fix some comment codes. v2: 1. return error if "func" is invalid. 2. modify the comments of the "func" field. 3. modify commit log of patch [3/5]. 4. use malloc instead of rte_malloc. 5. adjust display format of RSS info. 6. remove the string display of rss_hf. Huisong Li (1): net/hns3: support setting and querying RSS hash function Jie Hai (8): ethdev: overwrite some comment related to RSS ethdev: support setting and querying RSS algorithm net/hns3: report RSS hash algorithms capability app/proc-info: fix never show RSS info app/proc-info: adjust the display format of RSS info lib/ethdev: add API to get RSS algorithm names app/proc-info: support querying RSS hash algorithm app/testpmd: add RSS hash algorithms display app/proc-info/main.c | 24 +++++---- app/test-pmd/cmdline.c | 29 +++++++++-- app/test-pmd/config.c | 29 ++++------- app/test-pmd/testpmd.h | 2 +- doc/guides/rel_notes/release_23_11.rst | 8 +++ drivers/net/hns3/hns3_common.c | 4 ++ drivers/net/hns3/hns3_rss.c | 47 +++++++++-------- lib/ethdev/rte_ethdev.c | 51 +++++++++++++++++++ lib/ethdev/rte_ethdev.h | 70 ++++++++++++++++++++------ lib/ethdev/rte_flow.c | 1 - lib/ethdev/rte_flow.h | 25 +-------- 11 files changed, 196 insertions(+), 94 deletions(-)
Comments
On 10/28/2023 2:46 AM, Jie Hai wrote: > This patchset is to support setting and querying RSS algorithms. > For this purpose, field "rss_algo_capa" is added to ``rte_eth_dev_info`` > and field "algorithm" is added to ``rte_eth_rss_conf``. > The drivers should reports their "rss_algo_capa" if they support > updating RSS algorithms. Otherwise, the "rss_algo_capa" is set to > RTE_ETH_HASH_ALGO_CAPA_MASK(DEFAULT). The app configures RSS algorithms > by field "algorithm" and the related API should verify "algorithm" with > "rss_algo_capa". > > -- > v7: > 1. fix compile error. > 2. add signed-off-by to patch[4/9]. > v6: > 1. rewrite some comments. > 2. add "rss_algo_capa" for `rte_eth_dev_info``. > 3. add new API to get name of RSS algorithms > > v5: > 1. rewrite some comments. > 2. check RSS algorithm for drivers supporting RSS. > 3. change field "func" of rss_conf to "algorithm". > 4. fix commit log for [PATCH v4 4/7]. > 5. add Acked-by Reshma Pattan. > 6. add symmetric_toeplitz_sort for showing. > 7. change "hf" to "hash function" for showing. > > v4: > 1. recomment some definitions related to RSS. > 2. allocate static memory for rss_key instead of dynamic. > 3. use array of strings to get the name of rss algorithm. > 4. add display of rss algorithm with testpmd. > > v3: > 1. fix commit log for PATCH [1/5]. > 2. make RSS ABI changes description to start the actual text at the margin. > 3. move defnition of enum rte_eth_hash_function to rte_ethdev.h. > 4. fix some comment codes. > > v2: > 1. return error if "func" is invalid. > 2. modify the comments of the "func" field. > 3. modify commit log of patch [3/5]. > 4. use malloc instead of rte_malloc. > 5. adjust display format of RSS info. > 6. remove the string display of rss_hf. > > Huisong Li (1): > net/hns3: support setting and querying RSS hash function > > Jie Hai (8): > ethdev: overwrite some comment related to RSS > ethdev: support setting and querying RSS algorithm > net/hns3: report RSS hash algorithms capability > app/proc-info: fix never show RSS info > app/proc-info: adjust the display format of RSS info > lib/ethdev: add API to get RSS algorithm names > app/proc-info: support querying RSS hash algorithm > app/testpmd: add RSS hash algorithms display > Hi Jie, Patchset mostly looks good to me, new capability in dev_info approach is better, but only I put some comments in the new API patch, can you please check it, rest looks good but please send new version as whole patchset. Thanks, ferruh