[dpdk-dev,00/10] standard make install
Commit Message
2015-12-02 09:44, Panu Matilainen:
> That aside, a bigger problem is that it doesn't seem to work.
>
> make clean
> make config T=x86_64-native-linuxapp-gcc
> make
> make install DESTDIR=/tmp/dpdk-root
Oh, I forgot to test the simple case where O= is not specified!
It should be fixed with this change:
Comments
On 12/02/2015 11:25 AM, Thomas Monjalon wrote:
> 2015-12-02 09:44, Panu Matilainen:
>> That aside, a bigger problem is that it doesn't seem to work.
>>
>> make clean
>> make config T=x86_64-native-linuxapp-gcc
>> make
>> make install DESTDIR=/tmp/dpdk-root
>
> Oh, I forgot to test the simple case where O= is not specified!
>
> It should be fixed with this change:
>
Okay, that helped a bunch :)
Now that I can actually test it, seems mostly ok to me. As for the rest,
I'll comment on the specific patches.
- Panu -
2015-12-02 11:47, Panu Matilainen:
> On 12/02/2015 11:25 AM, Thomas Monjalon wrote:
> > 2015-12-02 09:44, Panu Matilainen:
> >> That aside, a bigger problem is that it doesn't seem to work.
> >>
> >> make clean
> >> make config T=x86_64-native-linuxapp-gcc
> >> make
> >> make install DESTDIR=/tmp/dpdk-root
> >
> > Oh, I forgot to test the simple case where O= is not specified!
> >
> > It should be fixed with this change:
> >
>
> Okay, that helped a bunch :)
>
> Now that I can actually test it, seems mostly ok to me. As for the rest,
> I'll comment on the specific patches.
OK thanks :)
@@ -31,8 +31,10 @@
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
# Build directory is given with O=
-O ?= .
+ifndef T
+O ?= build
BUILD_DIR := $O
+endif
prefix ?= /usr/local
exec_prefix ?= $(prefix)
@@ -52,6 +54,7 @@ sdkdir ?= $(datadir)
# with make install T=<config>
ifdef T
# The build directory is T and may be prepended with O
+O ?= .
BUILD_DIR := $O/$T
# Default usage of T= will install an almost flat staging tree
export prefix =