net/nfp: fix getting firmware VNIC version
Checks
Commit Message
From: Qin Ke <qin.ke@corigine.com>
When getting firmware VNIC version, the logic for representor
ports and other ports is inverse, fix it.
Fixes: c4de52eca76c ("net/nfp: remove redundancy for representor port")
Cc: Chaoyong He <chaoyong.he@corigine.com>
Cc: stable@dpdk.org
Signed-off-by: Qin Ke <qin.ke@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
---
drivers/net/nfp/nfp_net_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 3/11/2024 1:54 AM, Chaoyong He wrote:
> From: Qin Ke <qin.ke@corigine.com>
>
> When getting firmware VNIC version, the logic for representor
> ports and other ports is inverse, fix it.
>
> Fixes: c4de52eca76c ("net/nfp: remove redundancy for representor port")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qin Ke <qin.ke@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Long Wu <long.wu@corigine.com>
> Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
>
Applied to dpdk-next-net/main, thanks.
@@ -2155,7 +2155,7 @@ nfp_net_firmware_version_get(struct rte_eth_dev *dev,
hw = nfp_net_get_hw(dev);
- if (rte_eth_dev_is_repr(dev)) {
+ if (!rte_eth_dev_is_repr(dev)) {
snprintf(vnic_version, FW_VER_LEN, "%d.%d.%d.%d",
hw->ver.extend, hw->ver.class,
hw->ver.major, hw->ver.minor);