[v5,0/1] devtools: add tracepoint check in checkpatch
Message ID | 20230307120514.2774917-1-adwivedi@marvell.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BCCD41E05; Tue, 7 Mar 2023 13:05:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DCE7640E03; Tue, 7 Mar 2023 13:05:39 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 2CF624067E for <dev@dpdk.org>; Tue, 7 Mar 2023 13:05:38 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 327A6ANc031066; Tue, 7 Mar 2023 04:05:37 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=Rm0+7ZU1BMoYOSoL8uvWnWhOMCf4QvFeqgziSr7xCQM=; b=PPY86l7wqB92iZowaL6Y+UqetHPj2/e5fp9Nz2W71vIhx7ecIPUYbrjGAxCCO8ZW+3Xx ppwzdCMkMjmBGixf+Nb4SvlXuPyWK12VocjDNLq6sGu4LmHlT9mcNLoOmio195+XjRiC fv8H5uplYLgu/NIdSvX4k3c6I6a9fUMM8Y1TLXPJru6LkwQCuD1ENKeJecI9UAMu2flO JzifX67qB3uxlnQJTW1z9CLxd60uKVSZfw5K8BbL8XsUREqa65CaAq8A4lABBGNHSVLq 2lUG3ykLMQ55a/4Gu967ct4tvb20S6jpYAMHvQSJsO8S+zaYHjSs8yOB0DbUwGgGByC+ GA== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3p5y87smmx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 07 Mar 2023 04:05:37 -0800 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 7 Mar 2023 04:05:35 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.42 via Frontend Transport; Tue, 7 Mar 2023 04:05:34 -0800 Received: from localhost.localdomain (unknown [10.28.36.185]) by maili.marvell.com (Postfix) with ESMTP id 8BC233F7086; Tue, 7 Mar 2023 04:05:33 -0800 (PST) From: Ankur Dwivedi <adwivedi@marvell.com> To: <dev@dpdk.org> CC: <thomas@monjalon.net>, <jerinj@marvell.com>, Ankur Dwivedi <adwivedi@marvell.com> Subject: [PATCH v5 0/1] devtools: add tracepoint check in checkpatch Date: Tue, 7 Mar 2023 17:35:13 +0530 Message-ID: <20230307120514.2774917-1-adwivedi@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230303155811.2751210-1-adwivedi@marvell.com> References: <20230303155811.2751210-1-adwivedi@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: ca1u01sTuVm4w4HEcQRefI4oatwWGO0v X-Proofpoint-ORIG-GUID: ca1u01sTuVm4w4HEcQRefI4oatwWGO0v X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-07_06,2023-03-07_01,2023-02-09_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Message
Ankur Dwivedi
March 7, 2023, 12:05 p.m. UTC
This patch series adds a validation in checkpatch tool to check if tracepoint is present in any new function added in ethdev, eventdev cryptodev and mempool library. v5: - Copied the build_map_changes function from check-symbol-change.sh to check-tracepoint.sh. - Added eventdev, cryptodev and mempool in libdir in check-tracepoint.sh. v4: - Rebased on the recent next-net branch. - Refined logic to find function definition. - Updated year in the license in devtools/check-tracepoint.sh. - Removed cryptodev, added ethdev in libdir in devtools/check-tracepoint.sh. v3: - Split the v2 patch into 2 patches. - The file common-func.sh is renamed to build-symbol-map.sh. - Removed check-tracepoint.py file. - Code improvements in check-tracepoint.sh. v2: - Add check for parent directory. Ankur Dwivedi (1): devtools: add tracepoint check in checkpatch devtools/check-tracepoint.sh | 223 +++++++++++++++++++++++++++++++++++ devtools/checkpatches.sh | 9 ++ devtools/trace-skiplist.txt | 0 3 files changed, 232 insertions(+) create mode 100755 devtools/check-tracepoint.sh create mode 100644 devtools/trace-skiplist.txt
Comments
07/03/2023 13:05, Ankur Dwivedi: > This patch series adds a validation in checkpatch tool to check if > tracepoint is present in any new function added in ethdev, eventdev > cryptodev and mempool library. > > v5: > - Copied the build_map_changes function from check-symbol-change.sh to > check-tracepoint.sh. > - Added eventdev, cryptodev and mempool in libdir in check-tracepoint.sh. Why did you decide to copy the function in v5, instead of having a common file usable by different scripts?
>07/03/2023 13:05, Ankur Dwivedi: >> This patch series adds a validation in checkpatch tool to check if >> tracepoint is present in any new function added in ethdev, eventdev >> cryptodev and mempool library. >> >> v5: >> - Copied the build_map_changes function from check-symbol-change.sh to >> check-tracepoint.sh. >> - Added eventdev, cryptodev and mempool in libdir in check-tracepoint.sh. > >Why did you decide to copy the function in v5, instead of having a common >file usable by different scripts? > There was comments in v2 of the patch that common scripts may not work well and to keep the scripts specialized.
28/11/2023 15:07, Ankur Dwivedi: > >07/03/2023 13:05, Ankur Dwivedi: > >> This patch series adds a validation in checkpatch tool to check if > >> tracepoint is present in any new function added in ethdev, eventdev > >> cryptodev and mempool library. > >> > >> v5: > >> - Copied the build_map_changes function from check-symbol-change.sh to > >> check-tracepoint.sh. > >> - Added eventdev, cryptodev and mempool in libdir in check-tracepoint.sh. > > > >Why did you decide to copy the function in v5, instead of having a common > >file usable by different scripts? > > > There was comments in v2 of the patch that common scripts may not work well and to keep the scripts specialized. I meant you can have a common file specialized in symbols. In general, you should reply, establish a discussion, so we share the same understanding.
>-----Original Message----- >From: Thomas Monjalon <thomas@monjalon.net> >Sent: Tuesday, November 28, 2023 9:25 PM >To: Ankur Dwivedi <adwivedi@marvell.com> >Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com> >Subject: Re: [EXT] Re: [PATCH v5 0/1] devtools: add tracepoint check in >checkpatch > >28/11/2023 15:07, Ankur Dwivedi: >> >07/03/2023 13:05, Ankur Dwivedi: >> >> This patch series adds a validation in checkpatch tool to check if >> >> tracepoint is present in any new function added in ethdev, eventdev >> >> cryptodev and mempool library. >> >> >> >> v5: >> >> - Copied the build_map_changes function from check-symbol-change.sh >to >> >> check-tracepoint.sh. >> >> - Added eventdev, cryptodev and mempool in libdir in check- >tracepoint.sh. >> > >> >Why did you decide to copy the function in v5, instead of having a >> >common file usable by different scripts? >> > >> There was comments in v2 of the patch that common scripts may not work >well and to keep the scripts specialized. > >I meant you can have a common file specialized in symbols. The build_map_changes() (in devtools/check-symbol-change.sh) which is a common function can be moved to a new file named devtools/build-symbol-map.sh. The build-symbol-map.sh can be included in check-symbol-change.sh and check-tracepoint.sh. Please let me know if this is fine. >In general, you should reply, establish a discussion, so we share the same >understanding. >
30/11/2023 06:56, Ankur Dwivedi: > From: Thomas Monjalon <thomas@monjalon.net> > > 28/11/2023 15:07, Ankur Dwivedi: > >> > 07/03/2023 13:05, Ankur Dwivedi: > >> >> This patch series adds a validation in checkpatch tool to check if > >> >> tracepoint is present in any new function added in ethdev, eventdev > >> >> cryptodev and mempool library. > >> >> > >> >> v5: > >> >> - Copied the build_map_changes function from check-symbol-change.sh > >to > >> >> check-tracepoint.sh. > >> >> - Added eventdev, cryptodev and mempool in libdir in check- > >tracepoint.sh. > >> > > >> >Why did you decide to copy the function in v5, instead of having a > >> >common file usable by different scripts? > >> > > >> There was comments in v2 of the patch that common scripts may not work > >well and to keep the scripts specialized. > > > >I meant you can have a common file specialized in symbols. > The build_map_changes() (in devtools/check-symbol-change.sh) which is a common function can be moved to a new file named devtools/build-symbol-map.sh. > The build-symbol-map.sh can be included in check-symbol-change.sh and check-tracepoint.sh. > Please let me know if this is fine. Yes We can imagine moving more symbol map related funtions in this new file. What about symbol-map-util.sh as filename?
>-----Original Message----- >From: Thomas Monjalon <thomas@monjalon.net> >Sent: Thursday, November 30, 2023 2:11 PM >To: Ankur Dwivedi <adwivedi@marvell.com> >Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com> >Subject: Re: [EXT] Re: [PATCH v5 0/1] devtools: add tracepoint check in >checkpatch > >30/11/2023 06:56, Ankur Dwivedi: >> From: Thomas Monjalon <thomas@monjalon.net> >> > 28/11/2023 15:07, Ankur Dwivedi: >> >> > 07/03/2023 13:05, Ankur Dwivedi: >> >> >> This patch series adds a validation in checkpatch tool to check >> >> >> if tracepoint is present in any new function added in ethdev, >> >> >> eventdev cryptodev and mempool library. >> >> >> >> >> >> v5: >> >> >> - Copied the build_map_changes function from >> >> >> check-symbol-change.sh >> >to >> >> >> check-tracepoint.sh. >> >> >> - Added eventdev, cryptodev and mempool in libdir in check- >> >tracepoint.sh. >> >> > >> >> >Why did you decide to copy the function in v5, instead of having a >> >> >common file usable by different scripts? >> >> > >> >> There was comments in v2 of the patch that common scripts may not >> >> work >> >well and to keep the scripts specialized. >> > >> >I meant you can have a common file specialized in symbols. >> The build_map_changes() (in devtools/check-symbol-change.sh) which is a >common function can be moved to a new file named devtools/build-symbol- >map.sh. >> The build-symbol-map.sh can be included in check-symbol-change.sh and >check-tracepoint.sh. >> Please let me know if this is fine. > >Yes >We can imagine moving more symbol map related funtions in this new file. >What about symbol-map-util.sh as filename? I am ok with this filename. >