Message ID | 20211014095311.1311617-1-kevin.laatz@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2343A0C4C; Thu, 14 Oct 2021 11:53:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A847411FC; Thu, 14 Oct 2021 11:53:34 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 85D6140041 for <dev@dpdk.org>; Thu, 14 Oct 2021 11:53:32 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10136"; a="227927737" X-IronPort-AV: E=Sophos;i="5.85,372,1624345200"; d="scan'208";a="227927737" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2021 02:53:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,372,1624345200"; d="scan'208";a="491882186" Received: from silpixa00401122.ir.intel.com ([10.55.128.10]) by orsmga008.jf.intel.com with ESMTP; 14 Oct 2021 02:53:12 -0700 From: Kevin Laatz <kevin.laatz@intel.com> To: dev@dpdk.org Cc: bruce.richardson@intel.com, fengchengwen@huawei.com, conor.walsh@intel.com, Kevin Laatz <kevin.laatz@intel.com> Date: Thu, 14 Oct 2021 09:53:03 +0000 Message-Id: <20211014095311.1311617-1-kevin.laatz@intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210910172737.2561156-1-kevin.laatz@intel.com> References: <20210910172737.2561156-1-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v4 0/8] port ioatfwd app to dmadev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
port ioatfwd app to dmadev
|
|
Message
Kevin Laatz
Oct. 14, 2021, 9:53 a.m. UTC
This patchset first adds some additional command line options to the existing ioatfwd application to enhance usability. The last 3 patches of this set then port the ioatfwd application to use the dmadev library APIs instead of the IOAT rawdev APIs. Following the port, all variables etc are renamed to be more appropriate for using with the DMAdev library. Lastly, the application itself is renamed to "dmafwd". Depends-on: series-19594 ("support dmadev") --- v4: - rebase on dmadev lib v26 patchset v3: - add signal-triggered device dump - add cmd line option to control stats print frequency - documentation updates - small miscellaneous changes from review feedback Kevin Laatz (5): examples/ioat: add cmd line option to control stats print interval examples/ioat: add signal-triggered device dumps examples/ioat: port application to dmadev APIs examples/ioat: update naming to match change to dmadev examples/ioat: rename application to dmafwd Konstantin Ananyev (3): examples/ioat: always use same lcore for both DMA requests enqueue and dequeue examples/ioat: add cmd line option to control DMA batch size examples/ioat: add cmd line option to control max frame size .../sample_app_ug/{ioat.rst => dma.rst} | 149 ++--- doc/guides/sample_app_ug/index.rst | 2 +- doc/guides/sample_app_ug/intro.rst | 4 +- examples/{ioat => dma}/Makefile | 4 +- examples/{ioat/ioatfwd.c => dma/dmafwd.c} | 632 ++++++++++-------- examples/{ioat => dma}/meson.build | 10 +- examples/meson.build | 2 +- 7 files changed, 427 insertions(+), 376 deletions(-) rename doc/guides/sample_app_ug/{ioat.rst => dma.rst} (64%) rename examples/{ioat => dma}/Makefile (97%) rename examples/{ioat/ioatfwd.c => dma/dmafwd.c} (60%) rename examples/{ioat => dma}/meson.build (63%)
Comments
14/10/2021 11:53, Kevin Laatz: > This patchset first adds some additional command line options to the > existing ioatfwd application to enhance usability. Please could you rebase? I see some errors about max_rx_pkt_len and DEV_RX_OFFLOAD_JUMBO_FRAME. Cc Ferruh for help if needed.
On 22/10/2021 20:48, Thomas Monjalon wrote: > 14/10/2021 11:53, Kevin Laatz: >> This patchset first adds some additional command line options to the >> existing ioatfwd application to enhance usability. > Please could you rebase? > I see some errors about max_rx_pkt_len and DEV_RX_OFFLOAD_JUMBO_FRAME. > Cc Ferruh for help if needed. > I'll send a v5 with rebase and fix for this. Thanks, Kevin
Hi Kevin, We test whole patch set and found it should add one judgement: the ring_size should be less than or equal to MBUF_RING_SIZE. If ring_size greater than MBUF_RING_SIZE, the tracking DMA bufs may be overwrited when the DMA copy is not in time. Thanks. On 2021/10/14 17:53, Kevin Laatz wrote: > This patchset first adds some additional command line options to the > existing ioatfwd application to enhance usability. > > The last 3 patches of this set then port the ioatfwd application to use the > dmadev library APIs instead of the IOAT rawdev APIs. Following the port, > all variables etc are renamed to be more appropriate for using with the > DMAdev library. Lastly, the application itself is renamed to "dmafwd". > > Depends-on: series-19594 ("support dmadev") > > --- > v4: > - rebase on dmadev lib v26 patchset > v3: > - add signal-triggered device dump > - add cmd line option to control stats print frequency > - documentation updates > - small miscellaneous changes from review feedback > > Kevin Laatz (5): > examples/ioat: add cmd line option to control stats print interval > examples/ioat: add signal-triggered device dumps > examples/ioat: port application to dmadev APIs > examples/ioat: update naming to match change to dmadev > examples/ioat: rename application to dmafwd > > Konstantin Ananyev (3): > examples/ioat: always use same lcore for both DMA requests enqueue and > dequeue > examples/ioat: add cmd line option to control DMA batch size > examples/ioat: add cmd line option to control max frame size > > .../sample_app_ug/{ioat.rst => dma.rst} | 149 ++--- > doc/guides/sample_app_ug/index.rst | 2 +- > doc/guides/sample_app_ug/intro.rst | 4 +- > examples/{ioat => dma}/Makefile | 4 +- > examples/{ioat/ioatfwd.c => dma/dmafwd.c} | 632 ++++++++++-------- > examples/{ioat => dma}/meson.build | 10 +- > examples/meson.build | 2 +- > 7 files changed, 427 insertions(+), 376 deletions(-) > rename doc/guides/sample_app_ug/{ioat.rst => dma.rst} (64%) > rename examples/{ioat => dma}/Makefile (97%) > rename examples/{ioat/ioatfwd.c => dma/dmafwd.c} (60%) > rename examples/{ioat => dma}/meson.build (63%) >
On 26/10/2021 01:56, fengchengwen wrote: > Hi Kevin, > > We test whole patch set and found it should add one judgement: > the ring_size should be less than or equal to MBUF_RING_SIZE. > If ring_size greater than MBUF_RING_SIZE, the tracking DMA bufs > may be overwrited when the DMA copy is not in time. > > Thanks. > Thanks for testing, Chengwen. I'll include this check in the v5. /Kevin