diff mbox series

[v7,1/9] bbdev: add big endian processing data processing info

Message ID 20210928082953.18731-2-nipun.gupta@nxp.com (mailing list archive)
State Superseded, archived
Delegated to: akhil goyal
Headers
Series baseband: add NXP LA12xx driver |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-testing warning apply patch failure

Commit Message

Nipun Gupta Sept. 28, 2021, 8:29 a.m. UTC 
  From: Nipun Gupta <nipun.gupta@nxp.com>

This patch intoduces a new info pertaining to bbdev device
to process the data in big endian order.

Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
---
 lib/bbdev/rte_bbdev.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Chautru, Nicolas Oct. 4, 2021, 11:09 p.m. UTC | #1 
> -----Original Message-----
> From: nipun.gupta@nxp.com <nipun.gupta@nxp.com>
> Sent: Tuesday, September 28, 2021 1:30 AM
> To: dev@dpdk.org; gakhil@marvell.com; Chautru, Nicolas
> <nicolas.chautru@intel.com>
> Cc: david.marchand@redhat.com; hemant.agrawal@nxp.com; Nipun Gupta
> <nipun.gupta@nxp.com>
> Subject: [PATCH v7 1/9] bbdev: add big endian processing data processing
> info
> 
> From: Nipun Gupta <nipun.gupta@nxp.com>
> 
> This patch intoduces a new info pertaining to bbdev device to process the
> data in big endian order.

Typo in commit message

> 
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> ---
>  lib/bbdev/rte_bbdev.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h index
> 7017124414..3acc008d06 100644
> --- a/lib/bbdev/rte_bbdev.h
> +++ b/lib/bbdev/rte_bbdev.h
> @@ -309,6 +309,8 @@ struct rte_bbdev_driver_info {
>  	uint16_t min_alignment;
>  	/** HARQ memory available in kB */
>  	uint32_t harq_buffer_size;
> +	/** Device support input, output and HARQ data as big-endian */
> +	uint8_t support_be_data;

Shouldn't this either be a bool or even better an enum?
Ie. as per rte_bbdev_op_cb_mode enum for instance
Having 0/1 magic number in the code will always be misleading

>  	/** Default queue configuration used if none is supplied  */
>  	struct rte_bbdev_queue_conf default_queue_conf;
>  	/** Device operation capabilities */
> --
> 2.17.1
diff mbox series

Patch

diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h
index 7017124414..3acc008d06 100644
--- a/lib/bbdev/rte_bbdev.h
+++ b/lib/bbdev/rte_bbdev.h
@@ -309,6 +309,8 @@  struct rte_bbdev_driver_info {
 	uint16_t min_alignment;
 	/** HARQ memory available in kB */
 	uint32_t harq_buffer_size;
+	/** Device support input, output and HARQ data as big-endian */
+	uint8_t support_be_data;
 	/** Default queue configuration used if none is supplied  */
 	struct rte_bbdev_queue_conf default_queue_conf;
 	/** Device operation capabilities */