diff mbox series

[1/2] common/cnxk: send link event to VF

Message ID 20210730160829.13597-1-hkalra@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series [1/2] common/cnxk: send link event to VF |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Harman Kalra July 30, 2021, 4:08 p.m. UTC 
  Currently link event is only sent to the PF by AF as soon as it comes
up, or in case of any physical change in link. PF will broadcast
these link events to all its VFs as soon as it receives it.
But no event is sent when a new VF comes up, hence it will not have
the link status.
Adding support for sending link status to the VF once it comes up
successfully.

Signed-off-by: Harman Kalra <hkalra@marvell.com>
---
 drivers/common/cnxk/roc_dev.c      | 33 ++++++++++++++++++++++++++++++
 drivers/common/cnxk/roc_dev_priv.h |  5 +++++
 drivers/common/cnxk/roc_nix.h      |  7 +++++++
 drivers/common/cnxk/roc_nix_mac.c  | 23 +++++++++++++++++++++
 drivers/common/cnxk/version.map    |  2 ++
 5 files changed, 70 insertions(+)

Comments

Jerin Jacob Sept. 16, 2021, 2:31 p.m. UTC | #1 
On Fri, Jul 30, 2021 at 9:38 PM Harman Kalra <hkalra@marvell.com> wrote:
>
> Currently link event is only sent to the PF by AF as soon as it comes
> up, or in case of any physical change in link. PF will broadcast
> these link events to all its VFs as soon as it receives it.
> But no event is sent when a new VF comes up, hence it will not have
> the link status.
> Adding support for sending link status to the VF once it comes up
> successfully.
>
> Signed-off-by: Harman Kalra <hkalra@marvell.com>


Series Acked-by: Jerin Jacob <jerinj@marvell.com>


> ---
>  drivers/common/cnxk/roc_dev.c      | 33 ++++++++++++++++++++++++++++++
>  drivers/common/cnxk/roc_dev_priv.h |  5 +++++
>  drivers/common/cnxk/roc_nix.h      |  7 +++++++
>  drivers/common/cnxk/roc_nix_mac.c  | 23 +++++++++++++++++++++
>  drivers/common/cnxk/version.map    |  2 ++
>  5 files changed, 70 insertions(+)
>
> diff --git a/drivers/common/cnxk/roc_dev.c b/drivers/common/cnxk/roc_dev.c
> index c14f189f9b..4e204373dc 100644
> --- a/drivers/common/cnxk/roc_dev.c
> +++ b/drivers/common/cnxk/roc_dev.c
> @@ -163,6 +163,39 @@ af_pf_wait_msg(struct dev *dev, uint16_t vf, int num_msg)
>                 rsp->rc = msg->rc;
>                 rsp->pcifunc = msg->pcifunc;
>
> +               /* Whenever a PF comes up, AF sends the link status to it but
> +                * when VF comes up no such event is sent to respective VF.
> +                * Using MBOX_MSG_NIX_LF_START_RX response from AF for the
> +                * purpose and send the link status of PF to VF.
> +                */
> +               if (msg->id == MBOX_MSG_NIX_LF_START_RX) {
> +                       /* Send link status to VF */
> +                       struct cgx_link_user_info linfo;
> +                       struct mbox_msghdr *vf_msg;
> +                       size_t sz;
> +
> +                       /* Get the link status */
> +                       memset(&linfo, 0, sizeof(struct cgx_link_user_info));
> +                       if (dev->ops && dev->ops->link_status_get)
> +                               dev->ops->link_status_get(dev->roc_nix, &linfo);
> +
> +                       sz = PLT_ALIGN(mbox_id2size(MBOX_MSG_CGX_LINK_EVENT),
> +                                      MBOX_MSG_ALIGN);
> +                       /* Prepare the message to be sent */
> +                       vf_msg = mbox_alloc_msg(&dev->mbox_vfpf_up, vf, sz);
> +                       if (vf_msg) {
> +                               mbox_req_init(MBOX_MSG_CGX_LINK_EVENT, vf_msg);
> +                               memcpy((uint8_t *)vf_msg +
> +                                      sizeof(struct mbox_msghdr), &linfo,
> +                                      sizeof(struct cgx_link_user_info));
> +
> +                               vf_msg->rc = msg->rc;
> +                               vf_msg->pcifunc = msg->pcifunc;
> +                               /* Send to VF */
> +                               mbox_msg_send(&dev->mbox_vfpf_up, vf);
> +                       }
> +               }
> +
>                 offset = mbox->rx_start + msg->next_msgoff;
>         }
>         plt_spinlock_unlock(&mdev->mbox_lock);
> diff --git a/drivers/common/cnxk/roc_dev_priv.h b/drivers/common/cnxk/roc_dev_priv.h
> index 9488db3c41..302dc0feb0 100644
> --- a/drivers/common/cnxk/roc_dev_priv.h
> +++ b/drivers/common/cnxk/roc_dev_priv.h
> @@ -30,9 +30,14 @@ typedef void (*link_info_t)(void *roc_nix,
>  /* PTP info callback */
>  typedef int (*ptp_info_t)(void *roc_nix, bool enable);
>
> +/* Link status get callback */
> +typedef void (*link_status_get_t)(void *roc_nix,
> +                                 struct cgx_link_user_info *link);
> +
>  struct dev_ops {
>         link_info_t link_status_update;
>         ptp_info_t ptp_info_update;
> +       link_status_get_t link_status_get;
>  };
>
>  #define dev_is_vf(dev) ((dev)->hwcap & DEV_HWCAP_F_VF)
> diff --git a/drivers/common/cnxk/roc_nix.h b/drivers/common/cnxk/roc_nix.h
> index bb69027956..d7ab3c674e 100644
> --- a/drivers/common/cnxk/roc_nix.h
> +++ b/drivers/common/cnxk/roc_nix.h
> @@ -243,6 +243,10 @@ typedef void (*link_status_t)(struct roc_nix *roc_nix,
>  /* PTP info update callback */
>  typedef int (*ptp_info_update_t)(struct roc_nix *roc_nix, bool enable);
>
> +/* Link status get callback */
> +typedef void (*link_info_get_t)(struct roc_nix *roc_nix,
> +                               struct roc_nix_link_info *link);
> +
>  struct roc_nix {
>         /* Input parameters */
>         struct plt_pci_device *pci_dev;
> @@ -487,6 +491,9 @@ int __roc_api roc_nix_mac_max_rx_len_set(struct roc_nix *roc_nix,
>  int __roc_api roc_nix_mac_link_cb_register(struct roc_nix *roc_nix,
>                                            link_status_t link_update);
>  void __roc_api roc_nix_mac_link_cb_unregister(struct roc_nix *roc_nix);
> +int __roc_api roc_nix_mac_link_info_get_cb_register(
> +       struct roc_nix *roc_nix, link_info_get_t link_info_get);
> +void __roc_api roc_nix_mac_link_info_get_cb_unregister(struct roc_nix *roc_nix);
>
>  /* Ops */
>  int __roc_api roc_nix_switch_hdr_set(struct roc_nix *roc_nix,
> diff --git a/drivers/common/cnxk/roc_nix_mac.c b/drivers/common/cnxk/roc_nix_mac.c
> index 682d5a7295..36259941c9 100644
> --- a/drivers/common/cnxk/roc_nix_mac.c
> +++ b/drivers/common/cnxk/roc_nix_mac.c
> @@ -296,3 +296,26 @@ roc_nix_mac_link_cb_unregister(struct roc_nix *roc_nix)
>
>         dev->ops->link_status_update = NULL;
>  }
> +
> +int
> +roc_nix_mac_link_info_get_cb_register(struct roc_nix *roc_nix,
> +                                     link_info_get_t link_info_get)
> +{
> +       struct nix *nix = roc_nix_to_nix_priv(roc_nix);
> +       struct dev *dev = &nix->dev;
> +
> +       if (link_info_get == NULL)
> +               return NIX_ERR_PARAM;
> +
> +       dev->ops->link_status_get = (link_info_t)link_info_get;
> +       return 0;
> +}
> +
> +void
> +roc_nix_mac_link_info_get_cb_unregister(struct roc_nix *roc_nix)
> +{
> +       struct nix *nix = roc_nix_to_nix_priv(roc_nix);
> +       struct dev *dev = &nix->dev;
> +
> +       dev->ops->link_status_get = NULL;
> +}
> diff --git a/drivers/common/cnxk/version.map b/drivers/common/cnxk/version.map
> index e3af48c02e..4cc2c9652c 100644
> --- a/drivers/common/cnxk/version.map
> +++ b/drivers/common/cnxk/version.map
> @@ -105,6 +105,8 @@ INTERNAL {
>         roc_nix_mac_addr_set;
>         roc_nix_mac_link_cb_register;
>         roc_nix_mac_link_cb_unregister;
> +       roc_nix_mac_link_info_get_cb_register;
> +       roc_nix_mac_link_info_get_cb_unregister;
>         roc_nix_mac_link_event_start_stop;
>         roc_nix_mac_link_info_get;
>         roc_nix_mac_link_info_set;
> --
> 2.18.0
>
Ray Kinsella Sept. 27, 2021, 1:06 p.m. UTC | #2 
On 30/07/2021 17:08, Harman Kalra wrote:
> Currently link event is only sent to the PF by AF as soon as it comes
> up, or in case of any physical change in link. PF will broadcast
> these link events to all its VFs as soon as it receives it.
> But no event is sent when a new VF comes up, hence it will not have
> the link status.
> Adding support for sending link status to the VF once it comes up
> successfully.
> 
> Signed-off-by: Harman Kalra <hkalra@marvell.com>
> ---
>  drivers/common/cnxk/roc_dev.c      | 33 ++++++++++++++++++++++++++++++
>  drivers/common/cnxk/roc_dev_priv.h |  5 +++++
>  drivers/common/cnxk/roc_nix.h      |  7 +++++++
>  drivers/common/cnxk/roc_nix_mac.c  | 23 +++++++++++++++++++++
>  drivers/common/cnxk/version.map    |  2 ++
>  5 files changed, 70 insertions(+)
> 
Acked-by: Ray Kinsella <mdr@ashroe.eu>
diff mbox series

Patch

diff --git a/drivers/common/cnxk/roc_dev.c b/drivers/common/cnxk/roc_dev.c
index c14f189f9b..4e204373dc 100644
--- a/drivers/common/cnxk/roc_dev.c
+++ b/drivers/common/cnxk/roc_dev.c
@@ -163,6 +163,39 @@  af_pf_wait_msg(struct dev *dev, uint16_t vf, int num_msg)
 		rsp->rc = msg->rc;
 		rsp->pcifunc = msg->pcifunc;
 
+		/* Whenever a PF comes up, AF sends the link status to it but
+		 * when VF comes up no such event is sent to respective VF.
+		 * Using MBOX_MSG_NIX_LF_START_RX response from AF for the
+		 * purpose and send the link status of PF to VF.
+		 */
+		if (msg->id == MBOX_MSG_NIX_LF_START_RX) {
+			/* Send link status to VF */
+			struct cgx_link_user_info linfo;
+			struct mbox_msghdr *vf_msg;
+			size_t sz;
+
+			/* Get the link status */
+			memset(&linfo, 0, sizeof(struct cgx_link_user_info));
+			if (dev->ops && dev->ops->link_status_get)
+				dev->ops->link_status_get(dev->roc_nix, &linfo);
+
+			sz = PLT_ALIGN(mbox_id2size(MBOX_MSG_CGX_LINK_EVENT),
+				       MBOX_MSG_ALIGN);
+			/* Prepare the message to be sent */
+			vf_msg = mbox_alloc_msg(&dev->mbox_vfpf_up, vf, sz);
+			if (vf_msg) {
+				mbox_req_init(MBOX_MSG_CGX_LINK_EVENT, vf_msg);
+				memcpy((uint8_t *)vf_msg +
+				       sizeof(struct mbox_msghdr), &linfo,
+				       sizeof(struct cgx_link_user_info));
+
+				vf_msg->rc = msg->rc;
+				vf_msg->pcifunc = msg->pcifunc;
+				/* Send to VF */
+				mbox_msg_send(&dev->mbox_vfpf_up, vf);
+			}
+		}
+
 		offset = mbox->rx_start + msg->next_msgoff;
 	}
 	plt_spinlock_unlock(&mdev->mbox_lock);
diff --git a/drivers/common/cnxk/roc_dev_priv.h b/drivers/common/cnxk/roc_dev_priv.h
index 9488db3c41..302dc0feb0 100644
--- a/drivers/common/cnxk/roc_dev_priv.h
+++ b/drivers/common/cnxk/roc_dev_priv.h
@@ -30,9 +30,14 @@  typedef void (*link_info_t)(void *roc_nix,
 /* PTP info callback */
 typedef int (*ptp_info_t)(void *roc_nix, bool enable);
 
+/* Link status get callback */
+typedef void (*link_status_get_t)(void *roc_nix,
+				  struct cgx_link_user_info *link);
+
 struct dev_ops {
 	link_info_t link_status_update;
 	ptp_info_t ptp_info_update;
+	link_status_get_t link_status_get;
 };
 
 #define dev_is_vf(dev) ((dev)->hwcap & DEV_HWCAP_F_VF)
diff --git a/drivers/common/cnxk/roc_nix.h b/drivers/common/cnxk/roc_nix.h
index bb69027956..d7ab3c674e 100644
--- a/drivers/common/cnxk/roc_nix.h
+++ b/drivers/common/cnxk/roc_nix.h
@@ -243,6 +243,10 @@  typedef void (*link_status_t)(struct roc_nix *roc_nix,
 /* PTP info update callback */
 typedef int (*ptp_info_update_t)(struct roc_nix *roc_nix, bool enable);
 
+/* Link status get callback */
+typedef void (*link_info_get_t)(struct roc_nix *roc_nix,
+				struct roc_nix_link_info *link);
+
 struct roc_nix {
 	/* Input parameters */
 	struct plt_pci_device *pci_dev;
@@ -487,6 +491,9 @@  int __roc_api roc_nix_mac_max_rx_len_set(struct roc_nix *roc_nix,
 int __roc_api roc_nix_mac_link_cb_register(struct roc_nix *roc_nix,
 					   link_status_t link_update);
 void __roc_api roc_nix_mac_link_cb_unregister(struct roc_nix *roc_nix);
+int __roc_api roc_nix_mac_link_info_get_cb_register(
+	struct roc_nix *roc_nix, link_info_get_t link_info_get);
+void __roc_api roc_nix_mac_link_info_get_cb_unregister(struct roc_nix *roc_nix);
 
 /* Ops */
 int __roc_api roc_nix_switch_hdr_set(struct roc_nix *roc_nix,
diff --git a/drivers/common/cnxk/roc_nix_mac.c b/drivers/common/cnxk/roc_nix_mac.c
index 682d5a7295..36259941c9 100644
--- a/drivers/common/cnxk/roc_nix_mac.c
+++ b/drivers/common/cnxk/roc_nix_mac.c
@@ -296,3 +296,26 @@  roc_nix_mac_link_cb_unregister(struct roc_nix *roc_nix)
 
 	dev->ops->link_status_update = NULL;
 }
+
+int
+roc_nix_mac_link_info_get_cb_register(struct roc_nix *roc_nix,
+				      link_info_get_t link_info_get)
+{
+	struct nix *nix = roc_nix_to_nix_priv(roc_nix);
+	struct dev *dev = &nix->dev;
+
+	if (link_info_get == NULL)
+		return NIX_ERR_PARAM;
+
+	dev->ops->link_status_get = (link_info_t)link_info_get;
+	return 0;
+}
+
+void
+roc_nix_mac_link_info_get_cb_unregister(struct roc_nix *roc_nix)
+{
+	struct nix *nix = roc_nix_to_nix_priv(roc_nix);
+	struct dev *dev = &nix->dev;
+
+	dev->ops->link_status_get = NULL;
+}
diff --git a/drivers/common/cnxk/version.map b/drivers/common/cnxk/version.map
index e3af48c02e..4cc2c9652c 100644
--- a/drivers/common/cnxk/version.map
+++ b/drivers/common/cnxk/version.map
@@ -105,6 +105,8 @@  INTERNAL {
 	roc_nix_mac_addr_set;
 	roc_nix_mac_link_cb_register;
 	roc_nix_mac_link_cb_unregister;
+	roc_nix_mac_link_info_get_cb_register;
+	roc_nix_mac_link_info_get_cb_unregister;
 	roc_nix_mac_link_event_start_stop;
 	roc_nix_mac_link_info_get;
 	roc_nix_mac_link_info_set;