cryptodev: build on Windows
Checks
Commit Message
Build the cryptography device library on Windows OS
by removing unneeded include and exports blocking the
compilation.
Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
---
lib/cryptodev/rte_cryptodev.c | 1 -
lib/cryptodev/version.map | 2 --
lib/meson.build | 1 +
3 files changed, 1 insertion(+), 3 deletions(-)
Comments
On Mon, Sep 13, 2021 at 10:19 AM Tal Shnaiderman <talshn@nvidia.com> wrote:
>
> Build the cryptography device library on Windows OS
> by removing unneeded include and exports blocking the
> compilation.
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
Acked-by: William Tu <u9012063@gmail.com>
I sent similar patch to enable ixgbe support for windows.
http://inbox.dpdk.org/dev/CALDO+SY_YkdV+Dx-dUJx8cyqafL6HdL=09DrOGCUBeonH2bPrA@mail.gmail.com/T/#t
On 9/13/2021 10:16 AM, Tal Shnaiderman wrote:
> Build the cryptography device library on Windows OS
> by removing unneeded include and exports blocking the
> compilation.
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
Acked-by: Pallavi Kadam <pallavi.kadam@intel.com>
>
> Build the cryptography device library on Windows OS
> by removing unneeded include and exports blocking the
> compilation.
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
Acked-by: Akhil Goyal <gakhil@marvell.com>
Applied to dpdk-next-crypto
Thanks.
> > Build the cryptography device library on Windows OS
> > by removing unneeded include and exports blocking the
> > compilation.
> >
> > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> > ---
> Acked-by: Akhil Goyal <gakhil@marvell.com>
>
> Applied to dpdk-next-crypto
Removing this patch from dpdk-next-crypto as the patch is superseded
With another series delegated to Thomas.
http://patches.dpdk.org/project/dpdk/cover/20211002003344.594-1-u9012063@gmail.com/
Please ensure previous versions are marked superseded or else it will create
Unnecessary issues while merging.
> Subject: RE: [EXT] [PATCH] cryptodev: build on Windows
>
> External email: Use caution opening links or attachments
>
>
> > > Build the cryptography device library on Windows OS by removing
> > > unneeded include and exports blocking the compilation.
> > >
> > > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> > > ---
> > Acked-by: Akhil Goyal <gakhil@marvell.com>
> >
> > Applied to dpdk-next-crypto
> Removing this patch from dpdk-next-crypto as the patch is superseded With
> another series delegated to Thomas.
> http://patches.dpdk.org/project/dpdk/cover/20211002003344.594-1-
> u9012063@gmail.com/
>
> Please ensure previous versions are marked superseded or else it will create
> Unnecessary issues while merging.
>
>
Thanks, you're right, I superseded the security patches but didn't notice a v3 for crypto was also sent.
@@ -12,7 +12,6 @@
#include <errno.h>
#include <stdint.h>
#include <inttypes.h>
-#include <netinet/in.h>
#include <rte_byteorder.h>
#include <rte_log.h>
@@ -93,10 +93,8 @@ EXPERIMENTAL {
# added in 20.11
rte_cryptodev_configure_raw_dp_ctx;
rte_cryptodev_get_raw_dp_ctx_size;
- rte_cryptodev_raw_dequeue;
rte_cryptodev_raw_dequeue_burst;
rte_cryptodev_raw_dequeue_done;
- rte_cryptodev_raw_enqueue;
rte_cryptodev_raw_enqueue_burst;
rte_cryptodev_raw_enqueue_done;
@@ -80,6 +80,7 @@ if is_windows
'hash',
'timer',
'bitratestats',
+ 'cryptodev',
'cfgfile',
'gro',
'gso',