Message ID | 20210915162603.16652-2-talshn@nvidia.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | akhil goyal |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62E73A0C41; Wed, 15 Sep 2021 18:27:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 55673411AC; Wed, 15 Sep 2021 18:27:07 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2071.outbound.protection.outlook.com [40.107.100.71]) by mails.dpdk.org (Postfix) with ESMTP id 82376411A2 for <dev@dpdk.org>; Wed, 15 Sep 2021 18:27:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VTr0B6R8Hjm9Am5dQQX5SN6wo0TQEceLpTrdm/irUJtZc89cci8z1KgFXjOS0r9s4xniN1lMoIVuobhWAZSImJJxQQJ1l7zGGk73RyRrlurSBvUrwa75ILorjwkrNNh6jrQYe9sUhpmGUP8K0Rrrb5VKPUBP/zAAMsKPQtPtB79VnElRcnVYWz0xIQbxmoMYrPQzz1kOpdyGfO26iAdcGVEWMhBlQozILjRlbHJPtAoX/UvXDf4yGFFod/nBVCPIPuyMD+E9AIZ1B+zyEKf7bXYvZOy9C5eZ+h8YqFseIyYsz5AGWEd7uC1mNyzt8wcEBM05T+HtjwywL1eGOjy2rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=w2AprtGsuidysVAZPykoj8H0qRBVCJhx/36YkOddFIk=; b=I23Wi9l5HboVJ+NdYN4MYwh3eXBSqgIR0EvHhZQSW7HYjo4ZsJlL7ZdIe3OY4sjk87T6a+R4NUmqpCb8h5nJKTyXLZNr96Htr99EPSYPfPP89xWjkKUz9UX3lP6wPG7bO2akoSe24AG0XiNDY23Pv6hm4sBTfJCTtcfyHgfL4wcnAJEPKolc8nr3fR1rIe1XoSd3suLTgbk57L8quaVWhTgY42gSZ5kPSOHpJyaiXZS1Isl6BpOdCYlRf8iYYzzUWOwLHIW+gS1CtnyU4Y3n5btk5liDl9DAhjJFhQ4Qw/TTCeqwLL1m00Bt1a4NZQ7AdkThBXdT2nnRZiAuBFGT4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.35) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w2AprtGsuidysVAZPykoj8H0qRBVCJhx/36YkOddFIk=; b=gsN/jNAXlzgFIFRyVbAXrvGdZCmgDmrsO2W1tB65P5awtBAzBEftUKILdSDhJO62jdnWhQMYBwcghUECyN0TnVhBHSDhbSeNPQy3PAfa/2vSFMDho0Py0HQt3Jg1ehYVVHkpx0qE7zqWiXCIeHdnFNp8gUtp7zlKKUvWikUeo6ITTtDJ29uPzyca9TK0d8SSYPaCw3nqdz62hKtBOA61Be5Zw+C/m/sCWl34B4CV7ksHsv4Scv804D88mH8syV0u1TJohA45hWwM3zDeELnz+r5z40noKT97xx2RQC3uP2kVzbjtpoc60zeeBmnX8BgyGLFRL39XTWapFR2cLZoW8w== Received: from BN6PR1701CA0002.namprd17.prod.outlook.com (2603:10b6:405:15::12) by BN8PR12MB3169.namprd12.prod.outlook.com (2603:10b6:408:69::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Wed, 15 Sep 2021 16:27:04 +0000 Received: from BN8NAM11FT038.eop-nam11.prod.protection.outlook.com (2603:10b6:405:15:cafe::59) by BN6PR1701CA0002.outlook.office365.com (2603:10b6:405:15::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Wed, 15 Sep 2021 16:27:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.35) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.35 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.35; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.35) by BN8NAM11FT038.mail.protection.outlook.com (10.13.176.246) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4523.14 via Frontend Transport; Wed, 15 Sep 2021 16:27:04 +0000 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 15 Sep 2021 16:27:03 +0000 Received: from nvidia.com (172.20.187.5) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 15 Sep 2021 16:27:01 +0000 From: Tal Shnaiderman <talshn@nvidia.com> To: <dev@dpdk.org> CC: <thomas@monjalon.net>, <pallavi.kadam@intel.com>, <dmitry.kozliuk@gmail.com>, <navasile@linux.microsoft.com>, <dmitrym@microsoft.com>, <gakhil@marvell.com>, <declan.doherty@intel.com> Date: Wed, 15 Sep 2021 19:26:03 +0300 Message-ID: <20210915162603.16652-2-talshn@nvidia.com> X-Mailer: git-send-email 2.16.1.windows.4 In-Reply-To: <20210915162603.16652-1-talshn@nvidia.com> References: <20210915162603.16652-1-talshn@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To DRHQMAIL107.nvidia.com (10.27.9.16) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7b898ed9-cf41-4e00-bbaa-08d97865a73b X-MS-TrafficTypeDiagnostic: BN8PR12MB3169: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: <BN8PR12MB31693A3520D02D965BF27346A4DB9@BN8PR12MB3169.namprd12.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:3826; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lLv5o5/sLrJ58B5afRAMoy5yINMaLYd1qJb+L93pPjOqXaoo+oDkhZRXNjp3UN8b8+1eSeEiizP7dB9rrd9EAk163l/EWCueJ1ZSFRfuimxVTafigUanIiAKahBZVJRmRP/1GepuiLyaWJXdVmISWtNaaBM3v3bExiCK8Q4QMB03jWRcNzMeaVNv5TVDrHOrYyxrC8ahcaDG7XDe5ECkGVblc7qRmFKghnDKHhFzG7YIwuVni+ZMl3MbT63iEnWeoInopmU2V7GGu9GsAi3F42MvJOK4yeIVyt0Ogf3ZG83bWeQZKLMH/8uBIv3R15wkWf1YaHyWfNZ0h+l/WMnwvpqBc6J3u+S8n3iC5QOoo6vurKtrW5CYKjcXTUAp89GgTwqZwFmWKRq6cC4O7ev3q9y58sKEPDwJvt7TXOnMO9rDj1rOrUweNnYQLeMRMbXtPRZ2oR9Q4E/HXGyX3mrahJ2lboC7j0gCNtatMBDmj7GrrHnkjG2TGgavC1JUF1/WX3vuLyzxnQu3PP4C2X+cuYS/5btKeAGYvUGqEkWh+gXo9tT9/fBHF3A9EJUYx6F3UeickDd7LzYohS2gfQWMPrIf3NPKl9w9wBsj/gSWswNMidpZyRqaQ4/pQQMIpidMOL8xMGkzIOKqehoFyEIShVtN55UcTxkqv/fEq5gAaCWzvRnq+iGuKvZHuXu3l3B/x22rzcKrGM6Aki3Ho4/A6g== X-Forefront-Antispam-Report: CIP:216.228.112.35; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid04.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(136003)(376002)(346002)(39860400002)(36840700001)(46966006)(316002)(15650500001)(55016002)(47076005)(82740400003)(36756003)(7636003)(54906003)(4326008)(6916009)(6286002)(5660300002)(86362001)(1076003)(478600001)(70206006)(2906002)(36860700001)(4744005)(356005)(70586007)(2616005)(8676002)(26005)(82310400003)(426003)(336012)(36906005)(16526019)(186003)(8936002)(7696005)(83380400001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2021 16:27:04.0773 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7b898ed9-cf41-4e00-bbaa-08d97865a73b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.35]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT038.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3169 Subject: [dpdk-dev] [PATCH 2/2] security: build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
[1/2] security: use the net library for IP structs
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/github-robot: build | success | github build: passed |
ci/Intel-compilation | fail | Compilation issues |
ci/intel-Testing | fail | Testing issues |
ci/iol-mellanox-Performance | success | Performance Testing PASS |
ci/iol-x86_64-compile-testing | fail | Testing issues |
ci/iol-x86_64-unit-testing | fail | Testing issues |
ci/iol-aarch64-compile-testing | success | Testing PASS |
Commit Message
Tal Shnaiderman
Sept. 15, 2021, 4:26 p.m. UTC
Build the security library on Windows.
Remove unneeded export from version file.
Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
---
Depends-on: patch-98796 ("cryptodev: build on Windows")
---
lib/meson.build | 1 +
lib/security/version.map | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
Comments
On Wed, Sep 15, 2021 at 9:27 AM Tal Shnaiderman <talshn@nvidia.com> wrote: > > Build the security library on Windows. > > Remove unneeded export from version file. > > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com> > --- Acked-by: William Tu <u9012063@gmail.com>
On 9/15/2021 9:26 AM, Tal Shnaiderman wrote: > Build the security library on Windows. > > Remove unneeded export from version file. > > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com> > --- > Depends-on: patch-98796 ("cryptodev: build on Windows") > --- > lib/meson.build | 1 + > lib/security/version.map | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/meson.build b/lib/meson.build > index 5f3b1cf365..e5f0094a82 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -86,6 +86,7 @@ if is_windows > 'gso', > 'latencystats', > 'pdump', > + 'security', > ] # only supported libraries for windows > endif > > diff --git a/lib/security/version.map b/lib/security/version.map > index c44c7f5f60..6067051552 100644 > --- a/lib/security/version.map > +++ b/lib/security/version.map > @@ -1,7 +1,6 @@ > DPDK_22 { > global: > > - rte_security_attach_session; > rte_security_capabilities_get; > rte_security_capability_get; > rte_security_session_create; Getting linking errors using clang for 'rte_security_get_userdata' and 'rte_security_set_pkt_metadata' as below: FAILED: lib/rte_security-22.dll "clang" -Wl,/MACHINE:X64 -Wl,/OUT:lib/rte_security-22.dll lib/librte_security.a.p/security_rte_security.c.obj "-Wl,/nologo" "-Wl,/release" "-Wl,/nologo" "-Wl,/OPT:REF" "-Wl,/DLL" "-Wl,/IMPLIB:lib\rte_security.lib" "lib\rte_eal.lib" "lib\rte_kvargs.lib" "lib\rte_mempool.lib" "lib\rte_ring.lib" "lib\rte_cryptodev.lib" "lib\rte_mbuf.lib" "lib\rte_rcu.lib" "lib\rte_net.lib" "-Wl,/def:C:\dpdk\ixgbe\dpdk\build\lib\rte_security_exports.def" "-ldbghelp" "-lsetupapi" "-lws2_32" "-lmincore" "-lkernel32" "-luser32" "-lgdi32" "-lwinspool" "-lshell32" "-lole32" "-loleaut32" "-luuid" "-lcomdlg32" "-ladvapi32" rte_security_exports.def : error LNK2001: unresolved external symbol rte_security_get_userdata rte_security_exports.def : error LNK2001: unresolved external symbol rte_security_set_pkt_metadata lib\rte_security.lib : fatal error LNK1120: 2 unresolved externals clang: error: linker command failed with exit code 1120 (use -v to see invocation) Should it be removed from version file?
> Subject: Re: [PATCH 2/2] security: build on Windows > > External email: Use caution opening links or attachments > > > On 9/15/2021 9:26 AM, Tal Shnaiderman wrote: > > Build the security library on Windows. > > > > Remove unneeded export from version file. > > > > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com> > > --- > > Depends-on: patch-98796 ("cryptodev: build on Windows") > > --- > > lib/meson.build | 1 + > > lib/security/version.map | 1 - > > 2 files changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/meson.build b/lib/meson.build index > > 5f3b1cf365..e5f0094a82 100644 > > --- a/lib/meson.build > > +++ b/lib/meson.build > > @@ -86,6 +86,7 @@ if is_windows > > 'gso', > > 'latencystats', > > 'pdump', > > + 'security', > > ] # only supported libraries for windows > > endif > > > > diff --git a/lib/security/version.map b/lib/security/version.map index > > c44c7f5f60..6067051552 100644 > > --- a/lib/security/version.map > > +++ b/lib/security/version.map > > @@ -1,7 +1,6 @@ > > DPDK_22 { > > global: > > > > - rte_security_attach_session; > > rte_security_capabilities_get; > > rte_security_capability_get; > > rte_security_session_create; > > Getting linking errors using clang for 'rte_security_get_userdata' and > 'rte_security_set_pkt_metadata' as below: > > FAILED: lib/rte_security-22.dll > "clang" -Wl,/MACHINE:X64 -Wl,/OUT:lib/rte_security-22.dll > lib/librte_security.a.p/security_rte_security.c.obj "-Wl,/nologo" > "-Wl,/release" "-Wl,/nologo" "-Wl,/OPT:REF" "-Wl,/DLL" > "-Wl,/IMPLIB:lib\rte_security.lib" "lib\rte_eal.lib" > "lib\rte_kvargs.lib" "lib\rte_mempool.lib" "lib\rte_ring.lib" > "lib\rte_cryptodev.lib" "lib\rte_mbuf.lib" "lib\rte_rcu.lib" > "lib\rte_net.lib" > "-Wl,/def:C:\dpdk\ixgbe\dpdk\build\lib\rte_security_exports.def" > "-ldbghelp" "-lsetupapi" "-lws2_32" "-lmincore" "-lkernel32" "-luser32" > "-lgdi32" "-lwinspool" "-lshell32" "-lole32" "-loleaut32" "-luuid" > "-lcomdlg32" "-ladvapi32" > rte_security_exports.def : error LNK2001: unresolved external symbol > rte_security_get_userdata rte_security_exports.def : error LNK2001: > unresolved external symbol rte_security_set_pkt_metadata > lib\rte_security.lib : fatal error LNK1120: 2 unresolved externals > clang: error: linker command failed with exit code 1120 (use -v to see > invocation) > > Should it be removed from version file? Yes, those 2 functions were changed in the patch below after my v1 was sent and no longer need export. https://git.dpdk.org/dpdk/commit/?id=d08dcd28c3b245468a9859b7b9a288247dfc95f1 I'll remove them from the version file in v2 as suggested, thanks.
On Wed, Sep 29, 2021 at 12:55 PM Kadam, Pallavi <pallavi.kadam@intel.com> wrote: > > > On 9/15/2021 9:26 AM, Tal Shnaiderman wrote: > > Build the security library on Windows. > > > > Remove unneeded export from version file. > > > > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com> > > --- > > Depends-on: patch-98796 ("cryptodev: build on Windows") > > --- > > lib/meson.build | 1 + > > lib/security/version.map | 1 - > > 2 files changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/meson.build b/lib/meson.build > > index 5f3b1cf365..e5f0094a82 100644 > > --- a/lib/meson.build > > +++ b/lib/meson.build > > @@ -86,6 +86,7 @@ if is_windows > > 'gso', > > 'latencystats', > > 'pdump', > > + 'security', > > ] # only supported libraries for windows > > endif > > > > diff --git a/lib/security/version.map b/lib/security/version.map > > index c44c7f5f60..6067051552 100644 > > --- a/lib/security/version.map > > +++ b/lib/security/version.map > > @@ -1,7 +1,6 @@ > > DPDK_22 { > > global: > > > > - rte_security_attach_session; > > rte_security_capabilities_get; > > rte_security_capability_get; > > rte_security_session_create; > > Getting linking errors using clang for 'rte_security_get_userdata' and > 'rte_security_set_pkt_metadata' as below: > > FAILED: lib/rte_security-22.dll > "clang" -Wl,/MACHINE:X64 -Wl,/OUT:lib/rte_security-22.dll > lib/librte_security.a.p/security_rte_security.c.obj "-Wl,/nologo" > "-Wl,/release" "-Wl,/nologo" "-Wl,/OPT:REF" "-Wl,/DLL" > "-Wl,/IMPLIB:lib\rte_security.lib" "lib\rte_eal.lib" > "lib\rte_kvargs.lib" "lib\rte_mempool.lib" "lib\rte_ring.lib" > "lib\rte_cryptodev.lib" "lib\rte_mbuf.lib" "lib\rte_rcu.lib" > "lib\rte_net.lib" > "-Wl,/def:C:\dpdk\ixgbe\dpdk\build\lib\rte_security_exports.def" > "-ldbghelp" "-lsetupapi" "-lws2_32" "-lmincore" "-lkernel32" "-luser32" > "-lgdi32" "-lwinspool" "-lshell32" "-lole32" "-loleaut32" "-luuid" > "-lcomdlg32" "-ladvapi32" > rte_security_exports.def : error LNK2001: unresolved external symbol > rte_security_get_userdata > rte_security_exports.def : error LNK2001: unresolved external symbol > rte_security_set_pkt_metadata > lib\rte_security.lib : fatal error LNK1120: 2 unresolved externals > clang: error: linker command failed with exit code 1120 (use -v to see > invocation) > > Should it be removed from version file? > Previously it works ok, now on the latest main branch also hit the same issue. And yes, we should remove it from the version file. I will prepare the patch. William
diff --git a/lib/meson.build b/lib/meson.build index 5f3b1cf365..e5f0094a82 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -86,6 +86,7 @@ if is_windows 'gso', 'latencystats', 'pdump', + 'security', ] # only supported libraries for windows endif diff --git a/lib/security/version.map b/lib/security/version.map index c44c7f5f60..6067051552 100644 --- a/lib/security/version.map +++ b/lib/security/version.map @@ -1,7 +1,6 @@ DPDK_22 { global: - rte_security_attach_session; rte_security_capabilities_get; rte_security_capability_get; rte_security_session_create;