diff mbox series

devtools: allow to skip some build tests

Message ID 20210503144640.1369012-1-thomas@monjalon.net (mailing list archive)
State Rejected, archived
Delegated to: Thomas Monjalon
Headers
Series devtools: allow to skip some build tests |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/github-robot success github build: passed
ci/iol-abi-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

Thomas Monjalon May 3, 2021, 2:46 p.m. UTC 
  Inserting "return 1" in .develconfig file will allow to skip
some build tests based on $DPDK_TARGET or other parameters.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 devtools/test-meson-builds.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon Aug. 8, 2021, 11:32 a.m. UTC | #1 
03/05/2021 16:46, Thomas Monjalon:
> Inserting "return 1" in .develconfig file will allow to skip
> some build tests based on $DPDK_TARGET or other parameters.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> @@ -87,7 +87,7 @@ load_env () # <target compiler>
>  	fi
>  	echo "Using DPDK_TARGET $DPDK_TARGET" >&$verbose
>  	# config input: $DPDK_TARGET
> -	. $srcdir/devtools/load-devel-config
> +	. $srcdir/devtools/load-devel-config || return 1
>  	# config output: $DPDK_MESON_OPTIONS, $PATH, $PKG_CONFIG_PATH, etc
>  	command -v $targetcc >/dev/null 2>&1 || return 1
>  }

This technique does not work,
and it is possible to skip a build test
by inserting targetcc=SKIP in the development config file.
diff mbox series

Patch

diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
index daf817ac3e..d68d0e356e 100755
--- a/devtools/test-meson-builds.sh
+++ b/devtools/test-meson-builds.sh
@@ -87,7 +87,7 @@  load_env () # <target compiler>
 	fi
 	echo "Using DPDK_TARGET $DPDK_TARGET" >&$verbose
 	# config input: $DPDK_TARGET
-	. $srcdir/devtools/load-devel-config
+	. $srcdir/devtools/load-devel-config || return 1
 	# config output: $DPDK_MESON_OPTIONS, $PATH, $PKG_CONFIG_PATH, etc
 	command -v $targetcc >/dev/null 2>&1 || return 1
 }