Message ID | 20210715164126.54073-1-shirik@nvidia.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2538FA0C41; Thu, 15 Jul 2021 18:42:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A7A740686; Thu, 15 Jul 2021 18:42:04 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2063.outbound.protection.outlook.com [40.107.243.63]) by mails.dpdk.org (Postfix) with ESMTP id 5E2C94014D for <dev@dpdk.org>; Thu, 15 Jul 2021 18:42:02 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VEbRLZwoqhMFgvorfPENIo0kkGtnTOY8Mj4eaJfPpSdgnd6DAxHVE+NDsP94QQzZQYLYSLxz9gz8PI5wD118a9WoqDaWEQhYOQZEHSIT2HCfzclsuMoseln+2Gqvz9iJCCY5RrPGsUrf0w7jx/AK8KMDoT0o0aHPRNFwTPLuD95MeT9fL8t9hiG9Gfnq3pEDlJ5NXrxvJmadJjf15A+1Y8xL8OoJokfg9NbOLEyvAaVj4wtAKioVti1SLDX/581Aeq7B1VqHxwwzdkazAxf/e3lMtLcj4rMSKrYJ1gxgGM4YyKTFcJAZEReWRWXwoHu+vLtECkqyIpkagSNu/4HrYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x3yjNM/+MAyLkz3pAbaLFX8neklxq0zVwWL9gHocGPw=; b=VQ+JzIk+VhaWowtE+llFJOAh3z8sN3NEPliqMT7pgbf+Crby7EOuTq26Pi4QAtAhOFggPNJOxjO6g6FJ/ced0z6O9pz/CJ5kYR/GqEmGmZv3DIWVsjRscnDZISHiiYSSOZIj7z2HrAdSBevu/MSlPNvqaSZIMbIbgHjJ6SwCsIEETugC0tAV3oGHqCLsdzvh+HOORHW4N0YLyRi/6nsJ4cnVDjQNmrM3ckcH82imSknzoG9PyHCg2AERExJXUPfax7nZT4oUU0jRGv8WOC9IpOW2N4bCYyIKy/w3PGZAsi6SoGhkxw9cPwKLJiEnofks3hyCgQNA1OmWohUCnv/SLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x3yjNM/+MAyLkz3pAbaLFX8neklxq0zVwWL9gHocGPw=; b=m+4umrHEc5DOh0UFyH4/sU2bYEjdXpbvV26HX8eMES62gYSGPbtMOMB5cvHFDKbAmqDBaCtCU0cUvf5dRTWaiK7yTGSPk4KsJD9PFcnatddcKJmCni7mjhkkZ+KW8iqcLRCCe8AJioQObnEZO3k0AOrVZ90WOE17xW7LlLqMjeYhrQcEtFFluCO3G5CAnB8lP9Nl5anvfHZCfKsK/gdSsta9MXk69T/i27O8LrDcT4FF6pMcMhCxN+H1KtJ7oVuZwuBpecouVQXjx0u3dRlM9ekubtxKeenLM8JHZiAp5ca2VVQRUOYgYVYa9oVt0Qv5oPTxjBSPiuR4s71F6FkLUA== Received: from MW4PR04CA0024.namprd04.prod.outlook.com (2603:10b6:303:69::29) by DM6PR12MB3546.namprd12.prod.outlook.com (2603:10b6:5:18d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.24; Thu, 15 Jul 2021 16:42:01 +0000 Received: from CO1NAM11FT066.eop-nam11.prod.protection.outlook.com (2603:10b6:303:69:cafe::12) by MW4PR04CA0024.outlook.office365.com (2603:10b6:303:69::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21 via Frontend Transport; Thu, 15 Jul 2021 16:42:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT066.mail.protection.outlook.com (10.13.175.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4331.21 via Frontend Transport; Thu, 15 Jul 2021 16:42:00 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 15 Jul 2021 16:41:58 +0000 From: Shiri Kuzin <shirik@nvidia.com> To: <dev@dpdk.org> CC: <matan@nvidia.com>, <gakhil@marvell.com>, <suanmingm@nvidia.com>, <david.marchand@redhat.com> Date: Thu, 15 Jul 2021 19:41:10 +0300 Message-ID: <20210715164126.54073-1-shirik@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210715150817.51485-1-shirik@nvidia.com> References: <20210715150817.51485-1-shirik@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0bd6d32a-5088-4b92-f1b3-08d947af7812 X-MS-TrafficTypeDiagnostic: DM6PR12MB3546: X-Microsoft-Antispam-PRVS: <DM6PR12MB354646887AD6535BFA20F96EAA129@DM6PR12MB3546.namprd12.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:669; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o4in2K6xBG5UjQX1Ek8aEjtbmvz67eiXuW42uocaX80rhgWCLKw1yBNCCGCW5SqSstYbftgamoIaXksiOBwTVJsC3/UhfD/OXi6uFZZbU1UUOa/kCtJm5KPYpu0kzof875VoWcIMKpl9YJvQ0qqXUYs6SX+Zi8tfEh6XCfrU91SBPdqYTNEcQT9B/O+aLPV2vX1QrUNu7uIed0v/STo0Af5brClIeOdbze3T2Du7GoULRAnTkAUM05z/QAh6IRjj+BITQw1A5o8DiFfDevpVFc2Nf9XQ3KSO2juWwYQSdgl1e8NVUgRFIgU4GRm5oI8ot+a7t6aiRXsv3HYZfDrZ9DqF5A6dX4X2Et7tGxb+LeNiQnO8wwlzoKSD21GaUWxiYe2v4mD69BmA2LmSFlKClA3K4Mbon/hbs5fhrWpE9kiaKezjwNbz4kNHUOYKYK91js8H+FKAajOlGQW7IV9OfiX2kIg1FendbAFKN+t0SxJnA6L8ZT07gcDjiWOChl6OOdd8bzcv5ZBbYHDPaCqYCk8GARE+Co3OsbN47oaUG8+SGkaAqJnk5gcijf1fQ/GXOMGQJOqS2Pk8ZqDUxeDMrfHk7kaQpSNV+79lCDSk2wCi8h8OVDeC/vglop4OKMhSWDTgtNIGK2IpSPism1rcoPzbu5/CSfMIyoWUGRZtHV8YZEPYA/PZpklyjOfg3w7xkHZdGDV2HJfskF8TvG0LZQ+MTosDlm7K1JjR52zjs3Y= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(39860400002)(376002)(346002)(136003)(396003)(46966006)(36840700001)(6916009)(1076003)(36906005)(8676002)(70586007)(336012)(47076005)(82310400003)(34020700004)(426003)(26005)(6286002)(8936002)(70206006)(4326008)(316002)(478600001)(83380400001)(7696005)(7636003)(2906002)(16526019)(36756003)(5660300002)(186003)(86362001)(2616005)(356005)(82740400003)(54906003)(55016002)(36860700001)(6666004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2021 16:42:00.7882 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0bd6d32a-5088-4b92-f1b3-08d947af7812 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT066.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3546 Subject: [dpdk-dev] [PATCH v8 00/16] drivers: introduce mlx5 crypto PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
drivers: introduce mlx5 crypto PMD
|
|
Message
Shiri Kuzin
July 15, 2021, 4:41 p.m. UTC
v2: - Add data-path part. v3: - Rebase. v4: - Rebase + Address the following Akhil comments: - Set HW feature flag in the capability patch. - Fix mp object release in session clear. - Some spelling and word missing in doc. - Squash data-unit adjustment to the session operations commit. - Wording: device argument -> devarg. v5: - Add mlx5 crypto tests into test library. - Update documentation according to Akhil comments. - Fix memory region management. - Fix multi segment case in data-path code. - Split documentation to the correct commits according to Akhil comments. - Rebase to new version. - Change license to Nvidia license. v6: - Rebase to new version. - Address David's comment and update log accordingly. - Update testing app commits as suggested by Akhil. v7: - Rebase to new version. - Add scatter gather and OOP test cases. v8: - Add a test case that was removed by error. Shiri Kuzin (11): drivers: introduce mlx5 crypto PMD crypto/mlx5: add DEK object management crypto/mlx5: add session operations crypto/mlx5: add basic operations crypto/mlx5: add queue pairs operations crypto/mlx5: add dev stop and start operations crypto/mlx5: add memory region management crypto/mlx5: create login object using DevX test/crypto: add mlx5 crypto driver test/crypto: add data-unit and wrapped vectors test/crypto: add AES-XTS multi segment OOP tests Suanming Mou (5): crypto/mlx5: add keytag devarg crypto/mlx5: add maximum segments devarg crypto/mlx5: add WQE set initialization crypto/mlx5: add enqueue and dequeue operations crypto/mlx5: add statistic get and reset operations MAINTAINERS | 4 + app/test/test_cryptodev.c | 7 + app/test/test_cryptodev.h | 4 +- app/test/test_cryptodev_aes_test_vectors.h | 1404 ++++++++++++++++++++ app/test/test_cryptodev_blockcipher.c | 10 +- app/test/test_cryptodev_blockcipher.h | 2 + doc/guides/cryptodevs/features/mlx5.ini | 37 + doc/guides/cryptodevs/index.rst | 1 + doc/guides/cryptodevs/mlx5.rst | 153 +++ doc/guides/rel_notes/release_21_08.rst | 5 + drivers/common/mlx5/mlx5_common.h | 1 + drivers/common/mlx5/mlx5_common_pci.c | 14 + drivers/common/mlx5/mlx5_common_pci.h | 21 +- drivers/crypto/meson.build | 1 + drivers/crypto/mlx5/meson.build | 27 + drivers/crypto/mlx5/mlx5_crypto.c | 1177 ++++++++++++++++ drivers/crypto/mlx5/mlx5_crypto.h | 91 ++ drivers/crypto/mlx5/mlx5_crypto_dek.c | 161 +++ drivers/crypto/mlx5/mlx5_crypto_utils.h | 19 + drivers/crypto/mlx5/version.map | 3 + 20 files changed, 3130 insertions(+), 12 deletions(-) create mode 100644 doc/guides/cryptodevs/features/mlx5.ini create mode 100644 doc/guides/cryptodevs/mlx5.rst create mode 100644 drivers/crypto/mlx5/meson.build create mode 100644 drivers/crypto/mlx5/mlx5_crypto.c create mode 100644 drivers/crypto/mlx5/mlx5_crypto.h create mode 100644 drivers/crypto/mlx5/mlx5_crypto_dek.c create mode 100644 drivers/crypto/mlx5/mlx5_crypto_utils.h create mode 100644 drivers/crypto/mlx5/version.map
Comments
> v2: > - Add data-path part. > > v3: > - Rebase. > > v4: > - Rebase + Address the following Akhil comments: > - Set HW feature flag in the capability patch. > - Fix mp object release in session clear. > - Some spelling and word missing in doc. > - Squash data-unit adjustment to the session operations commit. > - Wording: device argument -> devarg. > > v5: > - Add mlx5 crypto tests into test library. > - Update documentation according to Akhil comments. > - Fix memory region management. > - Fix multi segment case in data-path code. > - Split documentation to the correct commits according to Akhil comments. > - Rebase to new version. > - Change license to Nvidia license. > > v6: > - Rebase to new version. > - Address David's comment and update log accordingly. > - Update testing app commits as suggested by Akhil. > > v7: > - Rebase to new version. > - Add scatter gather and OOP test cases. > > v8: > - Add a test case that was removed by error. > > > > Shiri Kuzin (11): > drivers: introduce mlx5 crypto PMD > crypto/mlx5: add DEK object management This is really bad, I was planning to apply this series today, It had small issues, so was planning to fix them while applying. But when I applied the 2/16, it does not compile. Please fix this, we are into v8 and compilation is broken. I am adding few more comments, please fix them too in your next version As soon as possible. I was planning to close RC2 during weekend, but it looks It will fall over next week. 147 | mlx5_crypto_dek_match_cb, | ^~~~~~~~~~~~~~~~~~~~~~~~ | | | int (*)(void *, struct mlx5_list_entry *, void *) In file included from ../drivers/crypto/mlx5/mlx5_crypto.h:13, from ../drivers/crypto/mlx5/mlx5_crypto_dek.c:14: ../drivers/common/mlx5/mlx5_common_utils.h:138:20: note: expected 'mlx5_hlist_remove_cb' {aka 'void (*)(struct mlx5_hlist *, struct mlx5_hlist_entry *)'} but argument is of type 'int (*)(void *, struct mlx5_list_entry *, void *)' 138 | struct mlx5_hlist *mlx5_hlist_create(const char *name, uint32_t size, | ^~~~~~~~~~~~~~~~~ ../drivers/crypto/mlx5/mlx5_crypto_dek.c:144:20: error: too many arguments to function 'mlx5_hlist_create' 144 | priv->dek_hlist = mlx5_hlist_create("dek_hlist", | ^~~~~~~~~~~~~~~~~ In file included from ../drivers/crypto/mlx5/mlx5_crypto.h:13, from ../drivers/crypto/mlx5/mlx5_crypto_dek.c:14: ../drivers/common/mlx5/mlx5_common_utils.h:138:20: note: declared here 138 | struct mlx5_hlist *mlx5_hlist_create(const char *name, uint32_t size, | ^~~~~~~~~~~~~~~~~ ../drivers/crypto/mlx5/mlx5_crypto_dek.c: In function 'mlx5_crypto_dek_destroy': ../drivers/crypto/mlx5/mlx5_crypto_dek.c:26:1: error: control reaches end of non-void function [-Werror=return-type] 26 | } | ^ ../drivers/crypto/mlx5/mlx5_crypto_dek.c: In function 'mlx5_crypto_dek_prepare': ../drivers/crypto/mlx5/mlx5_crypto_dek.c:45:1: error: control reaches end of non-void function [-Werror=return-type] 45 | } | ^ ../drivers/crypto/mlx5/mlx5_crypto_dek.c: In function 'mlx5_crypto_dek_create_cb': ../drivers/crypto/mlx5/mlx5_crypto_dek.c:127:1: error: control reaches end of non-void function [-Werror=return-type] 127 | } | ^ cc1: all warnings being treated as errors
> > v2: > > - Add data-path part. > > > > v3: > > - Rebase. > > > > v4: > > - Rebase + Address the following Akhil comments: > > - Set HW feature flag in the capability patch. > > - Fix mp object release in session clear. > > - Some spelling and word missing in doc. > > - Squash data-unit adjustment to the session operations commit. > > - Wording: device argument -> devarg. > > > > v5: > > - Add mlx5 crypto tests into test library. > > - Update documentation according to Akhil comments. > > - Fix memory region management. > > - Fix multi segment case in data-path code. > > - Split documentation to the correct commits according to Akhil comments. > > - Rebase to new version. > > - Change license to Nvidia license. > > > > v6: > > - Rebase to new version. > > - Address David's comment and update log accordingly. > > - Update testing app commits as suggested by Akhil. > > > > v7: > > - Rebase to new version. > > - Add scatter gather and OOP test cases. > > > > v8: > > - Add a test case that was removed by error. > > > > > > > > Shiri Kuzin (11): > > drivers: introduce mlx5 crypto PMD > > crypto/mlx5: add DEK object management > > This is really bad, I was planning to apply this series today, > It had small issues, so was planning to fix them while applying. > But when I applied the 2/16, it does not compile. > Please fix this, we are into v8 and compilation is broken. > > I am adding few more comments, please fix them too in your next version > As soon as possible. I was planning to close RC2 during weekend, but it looks > It will fall over next week. > Please review this patchset thoroughly within Nvidia before sending next version. Take reference to other crypto PMDs for patch splitting and sequencing.
> > > > v2: > > > - Add data-path part. > > > > > > v3: > > > - Rebase. > > > > > > v4: > > > - Rebase + Address the following Akhil comments: > > > - Set HW feature flag in the capability patch. > > > - Fix mp object release in session clear. > > > - Some spelling and word missing in doc. > > > - Squash data-unit adjustment to the session operations commit. > > > - Wording: device argument -> devarg. > > > > > > v5: > > > - Add mlx5 crypto tests into test library. > > > - Update documentation according to Akhil comments. > > > - Fix memory region management. > > > - Fix multi segment case in data-path code. > > > - Split documentation to the correct commits according to Akhil > comments. > > > - Rebase to new version. > > > - Change license to Nvidia license. > > > > > > v6: > > > - Rebase to new version. > > > - Address David's comment and update log accordingly. > > > - Update testing app commits as suggested by Akhil. > > > > > > v7: > > > - Rebase to new version. > > > - Add scatter gather and OOP test cases. > > > > > > v8: > > > - Add a test case that was removed by error. > > > > > > > > > > > > Shiri Kuzin (11): > > > drivers: introduce mlx5 crypto PMD > > > crypto/mlx5: add DEK object management > > > > This is really bad, I was planning to apply this series today, > > It had small issues, so was planning to fix them while applying. > > But when I applied the 2/16, it does not compile. > > Please fix this, we are into v8 and compilation is broken. > > > > I am adding few more comments, please fix them too in your next version > > As soon as possible. I was planning to close RC2 during weekend, but it > looks > > It will fall over next week. > > > Please review this patchset thoroughly within Nvidia before sending next > version. > Take reference to other crypto PMDs for patch splitting and sequencing. Are we expecting next version today? This is the only major patchset left for RC2. Any update?
Hi Akhil, > -----Original Message----- > From: Akhil Goyal <gakhil@marvell.com> > Sent: Tuesday, July 20, 2021 4:14 PM > To: Shiri Kuzin <shirik@nvidia.com>; NBU-Contact-Thomas Monjalon > <thomas@monjalon.net>; Matan Azrad <matan@nvidia.com>; Suanming Mou > <suanmingm@nvidia.com> > Cc: david.marchand@redhat.com; dev@dpdk.org > Subject: RE: [EXT] [PATCH v8 00/16] drivers: introduce mlx5 crypto PMD > > > > > > > > v2: > > > > - Add data-path part. > > > > > > > > v3: > > > > - Rebase. > > > > > > > > v4: > > > > - Rebase + Address the following Akhil comments: > > > > - Set HW feature flag in the capability patch. > > > > - Fix mp object release in session clear. > > > > - Some spelling and word missing in doc. > > > > - Squash data-unit adjustment to the session operations commit. > > > > - Wording: device argument -> devarg. > > > > > > > > v5: > > > > - Add mlx5 crypto tests into test library. > > > > - Update documentation according to Akhil comments. > > > > - Fix memory region management. > > > > - Fix multi segment case in data-path code. > > > > - Split documentation to the correct commits according to Akhil > > comments. > > > > - Rebase to new version. > > > > - Change license to Nvidia license. > > > > > > > > v6: > > > > - Rebase to new version. > > > > - Address David's comment and update log accordingly. > > > > - Update testing app commits as suggested by Akhil. > > > > > > > > v7: > > > > - Rebase to new version. > > > > - Add scatter gather and OOP test cases. > > > > > > > > v8: > > > > - Add a test case that was removed by error. > > > > > > > > > > > > > > > > Shiri Kuzin (11): > > > > drivers: introduce mlx5 crypto PMD > > > > crypto/mlx5: add DEK object management > > > > > > This is really bad, I was planning to apply this series today, It > > > had small issues, so was planning to fix them while applying. > > > But when I applied the 2/16, it does not compile. > > > Please fix this, we are into v8 and compilation is broken. > > > > > > I am adding few more comments, please fix them too in your next > > > version As soon as possible. I was planning to close RC2 during > > > weekend, but it > > looks > > > It will fall over next week. > > > > > Please review this patchset thoroughly within Nvidia before sending > > next version. > > Take reference to other crypto PMDs for patch splitting and sequencing. > > Are we expecting next version today? > This is the only major patchset left for RC2. > Any update? Sorry for the late reply, Shiri is not available these days, so I'm trying to follow up the status and update the new version later today. Regarding the compilation failure, it's due to the crypto patch series depends on some mlx5 common code. The mlx5 common code has some changes and I assume Shiri rebased the version with the dpdk-next-mlx and meanwhile the dpdk-next-crypto branch still did not get the latest mlx5 common code. I just checked the dpdk-next-crypto branch, seems the mlx5 part is still not updated yet. So will you also sync up the crypto branch today? If no, then the failure will come again. I'm not so familiar with the branch update procedure, but we will need the branch to be updated to the version below: http://git.dpdk.org/next/dpdk-next-net-mlx/commit/?id=7e1cf892711b9ba237563b6c876382caaec434f7 Thanks, SuanmingMou
> > > > > v2: > > > > > - Add data-path part. > > > > > > > > > > v3: > > > > > - Rebase. > > > > > > > > > > v4: > > > > > - Rebase + Address the following Akhil comments: > > > > > - Set HW feature flag in the capability patch. > > > > > - Fix mp object release in session clear. > > > > > - Some spelling and word missing in doc. > > > > > - Squash data-unit adjustment to the session operations commit. > > > > > - Wording: device argument -> devarg. > > > > > > > > > > v5: > > > > > - Add mlx5 crypto tests into test library. > > > > > - Update documentation according to Akhil comments. > > > > > - Fix memory region management. > > > > > - Fix multi segment case in data-path code. > > > > > - Split documentation to the correct commits according to Akhil > > > comments. > > > > > - Rebase to new version. > > > > > - Change license to Nvidia license. > > > > > > > > > > v6: > > > > > - Rebase to new version. > > > > > - Address David's comment and update log accordingly. > > > > > - Update testing app commits as suggested by Akhil. > > > > > > > > > > v7: > > > > > - Rebase to new version. > > > > > - Add scatter gather and OOP test cases. > > > > > > > > > > v8: > > > > > - Add a test case that was removed by error. > > > > > > > > > > > > > > > > > > > > Shiri Kuzin (11): > > > > > drivers: introduce mlx5 crypto PMD > > > > > crypto/mlx5: add DEK object management > > > > > > > > This is really bad, I was planning to apply this series today, It > > > > had small issues, so was planning to fix them while applying. > > > > But when I applied the 2/16, it does not compile. > > > > Please fix this, we are into v8 and compilation is broken. > > > > > > > > I am adding few more comments, please fix them too in your next > > > > version As soon as possible. I was planning to close RC2 during > > > > weekend, but it > > > looks > > > > It will fall over next week. > > > > > > > Please review this patchset thoroughly within Nvidia before sending > > > next version. > > > Take reference to other crypto PMDs for patch splitting and sequencing. > > > > Are we expecting next version today? > > This is the only major patchset left for RC2. > > Any update? > > Sorry for the late reply, Shiri is not available these days, so I'm trying to > follow up the status and update the new version later today. > Regarding the compilation failure, it's due to the crypto patch series depends > on some mlx5 common code. > The mlx5 common code has some changes and I assume Shiri rebased the > version with the dpdk-next-mlx and meanwhile the dpdk-next-crypto branch > still did not get the latest mlx5 common code. > > I just checked the dpdk-next-crypto branch, seems the mlx5 part is still not > updated yet. So will you also sync up the crypto branch today? If no, then the > failure will come again. > I'm not so familiar with the branch update procedure, but we will need the > branch to be updated to the version below: > http://git.dpdk.org/next/dpdk-next-net-mlx/commit/?id=7e1cf892711b9ba237563b6c876382caaec434f7 The tree is in sync with main branch now.
> > Sorry for the late reply, Shiri is not available these days, so I'm trying to > > follow up the status and update the new version later today. > > Regarding the compilation failure, it's due to the crypto patch series > depends > > on some mlx5 common code. > > The mlx5 common code has some changes and I assume Shiri rebased the > > version with the dpdk-next-mlx and meanwhile the dpdk-next-crypto > branch > > still did not get the latest mlx5 common code. > > > > I just checked the dpdk-next-crypto branch, seems the mlx5 part is still not > > updated yet. So will you also sync up the crypto branch today? If no, then > the > > failure will come again. > > I'm not so familiar with the branch update procedure, but we will need the > > branch to be updated to the version below: > > http://git.dpdk.org/next/dpdk-next-net- > mlx/commit/?id=7e1cf892711b9ba237563b6c876382caaec434f7 > > The tree is in sync with main branch now. BTW, it was not mentioned in the cover note that it has dependency on other patchset.
> -----Original Message----- > From: Akhil Goyal <gakhil@marvell.com> > Sent: Tuesday, July 20, 2021 4:42 PM > To: Suanming Mou <suanmingm@nvidia.com>; Shiri Kuzin <shirik@nvidia.com>; > NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Matan Azrad > <matan@nvidia.com> > Cc: david.marchand@redhat.com; dev@dpdk.org > Subject: RE: [EXT] [PATCH v8 00/16] drivers: introduce mlx5 crypto PMD > > > > Sorry for the late reply, Shiri is not available these days, so I'm > > > trying to follow up the status and update the new version later today. > > > Regarding the compilation failure, it's due to the crypto patch > > > series > > depends > > > on some mlx5 common code. > > > The mlx5 common code has some changes and I assume Shiri rebased the > > > version with the dpdk-next-mlx and meanwhile the dpdk-next-crypto > > branch > > > still did not get the latest mlx5 common code. > > > > > > I just checked the dpdk-next-crypto branch, seems the mlx5 part is > > > still not updated yet. So will you also sync up the crypto branch > > > today? If no, then > > the > > > failure will come again. > > > I'm not so familiar with the branch update procedure, but we will > > > need the branch to be updated to the version below: > > > http://git.dpdk.org/next/dpdk-next-net- > > mlx/commit/?id=7e1cf892711b9ba237563b6c876382caaec434f7 > > > > The tree is in sync with main branch now. > > BTW, it was not mentioned in the cover note that it has dependency on other > patchset. Thank you for the branch syncing. I assume the main reason is that the required patchset was already merged when the crypto patch v8 was sent, we are not so familiar with the branch syncing. Will keep an eye on that next time.