diff mbox series

test/mbuf: fix virtual address conversion

Message ID 20210705072734.22484-1-olivier.matz@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series test/mbuf: fix virtual address conversion |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot success github build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-testing fail Testing issues
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Olivier Matz July 5, 2021, 7:27 a.m. UTC 
  Seen with address sanitizer.

rte_mempool_virt2iova() can only be used on mempool elements. In this case,
it is incorrect, and rte_mem_virt2iova() has to be used.

Bugzilla ID: 737
Fixes: 7b295dceea07 ("test/mbuf: add unit test cases")
Cc: stable@dpdk.org

Reported-by: Zhihong Peng <zhihongx.peng@intel.com>
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
 app/test/test_mbuf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Marchand July 6, 2021, 11:50 a.m. UTC | #1 
On Mon, Jul 5, 2021 at 9:28 AM Olivier Matz <olivier.matz@6wind.com> wrote:
>
> Seen with address sanitizer.
>
> rte_mempool_virt2iova() can only be used on mempool elements. In this case,
> it is incorrect, and rte_mem_virt2iova() has to be used.
>
> Bugzilla ID: 737
> Fixes: 7b295dceea07 ("test/mbuf: add unit test cases")
> Cc: stable@dpdk.org
>
> Reported-by: Zhihong Peng <zhihongx.peng@intel.com>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
David Marchand July 6, 2021, 2:42 p.m. UTC | #2 
On Tue, Jul 6, 2021 at 1:50 PM David Marchand <david.marchand@redhat.com> wrote:
>
> On Mon, Jul 5, 2021 at 9:28 AM Olivier Matz <olivier.matz@6wind.com> wrote:
> >
> > Seen with address sanitizer.
> >
> > rte_mempool_virt2iova() can only be used on mempool elements. In this case,
> > it is incorrect, and rte_mem_virt2iova() has to be used.
> >
> > Bugzilla ID: 737
> > Fixes: 7b295dceea07 ("test/mbuf: add unit test cases")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Zhihong Peng <zhihongx.peng@intel.com>
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> Reviewed-by: David Marchand <david.marchand@redhat.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c
index 8e0561eabb..9a248dfaea 100644
--- a/app/test/test_mbuf.c
+++ b/app/test/test_mbuf.c
@@ -2363,7 +2363,7 @@  test_pktmbuf_ext_shinfo_init_helper(struct rte_mempool *pktmbuf_pool)
 	if (rte_mbuf_refcnt_read(m) != 1)
 		GOTO_FAIL("%s: Invalid refcnt in mbuf\n", __func__);
 
-	buf_iova = rte_mempool_virt2iova(ext_buf_addr);
+	buf_iova = rte_mem_virt2iova(ext_buf_addr);
 	rte_pktmbuf_attach_extbuf(m, ext_buf_addr, buf_iova, buf_len,
 		ret_shinfo);
 	if (m->ol_flags != EXT_ATTACHED_MBUF)