[v1] eal/arm64: fix aarch64 reg platform value
Checks
Commit Message
REG_PLATFORM only uses bit 0 to indicate whether the value retrieved
from hardware matches PLATFORM_STR.
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
Fixes: 97523f822ba9 ("eal/arm: add CPU flags for ARMv8")
Cc: jerinj@marvell.com
Cc: stable@dpdk.org
---
lib/eal/arm/rte_cpuflags.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Thu, Apr 22, 2021 at 2:41 PM Juraj Linkeš <juraj.linkes@pantheon.tech> wrote:
>
> REG_PLATFORM only uses bit 0 to indicate whether the value retrieved
> from hardware matches PLATFORM_STR.
>
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Fixes: 97523f822ba9 ("eal/arm: add CPU flags for ARMv8")
Fixes and cc stable should go above Signoff.
> Cc: jerinj@marvell.com
> Cc: stable@dpdk.org
Reviewed-by: Jerin Jacob <jerinj@marvell.com>
> ---
> lib/eal/arm/rte_cpuflags.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/eal/arm/rte_cpuflags.c b/lib/eal/arm/rte_cpuflags.c
> index e3a53bcece..e709a2800e 100644
> --- a/lib/eal/arm/rte_cpuflags.c
> +++ b/lib/eal/arm/rte_cpuflags.c
> @@ -108,7 +108,7 @@ const struct feature_entry rte_cpu_feature_table[] = {
> FEAT_DEF(SVEF32MM, REG_HWCAP2, 10)
> FEAT_DEF(SVEF64MM, REG_HWCAP2, 11)
> FEAT_DEF(SVEBF16, REG_HWCAP2, 12)
> - FEAT_DEF(AARCH64, REG_PLATFORM, 1)
> + FEAT_DEF(AARCH64, REG_PLATFORM, 0)
> };
> #endif /* RTE_ARCH */
>
> --
> 2.20.1
>
> -----Original Message-----
> From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Sent: Thursday, April 22, 2021 5:12 PM
> To: thomas@monjalon.net; david.marchand@redhat.com; Honnappa
> Nagarahalli <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; jerinj@marvell.com
> Cc: dev@dpdk.org; Juraj Linkeš <juraj.linkes@pantheon.tech>;
> stable@dpdk.org
> Subject: [PATCH v1] eal/arm64: fix aarch64 reg platform value
>
> REG_PLATFORM only uses bit 0 to indicate whether the value retrieved from
> hardware matches PLATFORM_STR.
>
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Fixes: 97523f822ba9 ("eal/arm: add CPU flags for ARMv8")
> Cc: jerinj@marvell.com
> Cc: stable@dpdk.org
> ---
> lib/eal/arm/rte_cpuflags.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/eal/arm/rte_cpuflags.c b/lib/eal/arm/rte_cpuflags.c index
> e3a53bcece..e709a2800e 100644
> --- a/lib/eal/arm/rte_cpuflags.c
> +++ b/lib/eal/arm/rte_cpuflags.c
> @@ -108,7 +108,7 @@ const struct feature_entry rte_cpu_feature_table[] =
> {
> FEAT_DEF(SVEF32MM, REG_HWCAP2, 10)
> FEAT_DEF(SVEF64MM, REG_HWCAP2, 11)
> FEAT_DEF(SVEBF16, REG_HWCAP2, 12)
> - FEAT_DEF(AARCH64, REG_PLATFORM, 1)
> + FEAT_DEF(AARCH64, REG_PLATFORM, 0)
> };
> #endif /* RTE_ARCH */
>
> --
> 2.20.1
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > REG_PLATFORM only uses bit 0 to indicate whether the value retrieved from
> > hardware matches PLATFORM_STR.
> >
> > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > Fixes: 97523f822ba9 ("eal/arm: add CPU flags for ARMv8")
> > Cc: jerinj@marvell.com
> > Cc: stable@dpdk.org
>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Applied, thanks
@@ -108,7 +108,7 @@ const struct feature_entry rte_cpu_feature_table[] = {
FEAT_DEF(SVEF32MM, REG_HWCAP2, 10)
FEAT_DEF(SVEF64MM, REG_HWCAP2, 11)
FEAT_DEF(SVEBF16, REG_HWCAP2, 12)
- FEAT_DEF(AARCH64, REG_PLATFORM, 1)
+ FEAT_DEF(AARCH64, REG_PLATFORM, 0)
};
#endif /* RTE_ARCH */