[0/6] net/ice: base update update batch 3.

  Add IP fragment support in base code and couple QinQ improvement.
update the release date as the last base patch for DPDK 21.05.

Qi Zhang (6):
  net/ice/base: add IP fragment flags
  net/ice/base: add function for post DDP download VLAN mode
    configuration
  net/ice/base: add print if DDP/FW don't support QinQ as expected
  net/ice/base: modififcation to support L3 DSCP QoS
  net/ice/base: signed External Device Package Programming
  net/ice/base: support IP fragment RSS and FDIR

 drivers/net/ice/base/README           |   2 +-
 drivers/net/ice/base/ice_adminq_cmd.h |  39 +++---
 drivers/net/ice/base/ice_common.c     | 119 ++++++++++++++++-
 drivers/net/ice/base/ice_common.h     |  10 ++
 drivers/net/ice/base/ice_dcb.c        | 185 +++++++++++++++++++++++---
 drivers/net/ice/base/ice_dcb.h        |  16 +++
 drivers/net/ice/base/ice_fdir.c       |  51 ++++++-
 drivers/net/ice/base/ice_fdir.h       |  20 ++-
 drivers/net/ice/base/ice_flex_pipe.c  |   5 +-
 drivers/net/ice/base/ice_flow.c       |  51 ++++++-
 drivers/net/ice/base/ice_flow.h       |   9 +-
 drivers/net/ice/base/ice_type.h       |  24 +++-
 drivers/net/ice/base/ice_vlan_mode.c  |  97 ++++++++++++--
 drivers/net/ice/base/ice_vlan_mode.h  |   2 +-
 14 files changed, 565 insertions(+), 65 deletions(-)
  

Hi,

> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: 2021年4月29日 8:42
> To: Yang, Qiming <qiming.yang@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [PATCH 0/6] net/ice: base update update batch 3.
> 
> Add IP fragment support in base code and couple QinQ improvement.
> update the release date as the last base patch for DPDK 21.05.
> 
> Qi Zhang (6):
>   net/ice/base: add IP fragment flags
>   net/ice/base: add function for post DDP download VLAN mode
>     configuration
>   net/ice/base: add print if DDP/FW don't support QinQ as expected
>   net/ice/base: modififcation to support L3 DSCP QoS
>   net/ice/base: signed External Device Package Programming
>   net/ice/base: support IP fragment RSS and FDIR
> 
>  drivers/net/ice/base/README           |   2 +-
>  drivers/net/ice/base/ice_adminq_cmd.h |  39 +++---
>  drivers/net/ice/base/ice_common.c     | 119 ++++++++++++++++-
>  drivers/net/ice/base/ice_common.h     |  10 ++
>  drivers/net/ice/base/ice_dcb.c        | 185 +++++++++++++++++++++++---
>  drivers/net/ice/base/ice_dcb.h        |  16 +++
>  drivers/net/ice/base/ice_fdir.c       |  51 ++++++-
>  drivers/net/ice/base/ice_fdir.h       |  20 ++-
>  drivers/net/ice/base/ice_flex_pipe.c  |   5 +-
>  drivers/net/ice/base/ice_flow.c       |  51 ++++++-
>  drivers/net/ice/base/ice_flow.h       |   9 +-
>  drivers/net/ice/base/ice_type.h       |  24 +++-
>  drivers/net/ice/base/ice_vlan_mode.c  |  97 ++++++++++++--
>  drivers/net/ice/base/ice_vlan_mode.h  |   2 +-
>  14 files changed, 565 insertions(+), 65 deletions(-)
> 
> --
> 2.26.2

Acked-by: Qiming Yang <qiming.yang@intel.com>
  

> -----Original Message-----
> From: Yang, Qiming <qiming.yang@intel.com>
> Sent: Thursday, April 29, 2021 10:30 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH 0/6] net/ice: base update update batch 3.
> 
> Hi,
> 
> > -----Original Message-----
> > From: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Sent: 2021年4月29日 8:42
> > To: Yang, Qiming <qiming.yang@intel.com>
> > Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>
> > Subject: [PATCH 0/6] net/ice: base update update batch 3.
> >
> > Add IP fragment support in base code and couple QinQ improvement.
> > update the release date as the last base patch for DPDK 21.05.
> >
> > Qi Zhang (6):
> >   net/ice/base: add IP fragment flags
> >   net/ice/base: add function for post DDP download VLAN mode
> >     configuration
> >   net/ice/base: add print if DDP/FW don't support QinQ as expected
> >   net/ice/base: modififcation to support L3 DSCP QoS
> >   net/ice/base: signed External Device Package Programming
> >   net/ice/base: support IP fragment RSS and FDIR
> >
> >  drivers/net/ice/base/README           |   2 +-
> >  drivers/net/ice/base/ice_adminq_cmd.h |  39 +++---
> >  drivers/net/ice/base/ice_common.c     | 119 ++++++++++++++++-
> >  drivers/net/ice/base/ice_common.h     |  10 ++
> >  drivers/net/ice/base/ice_dcb.c        | 185
> +++++++++++++++++++++++---
> >  drivers/net/ice/base/ice_dcb.h        |  16 +++
> >  drivers/net/ice/base/ice_fdir.c       |  51 ++++++-
> >  drivers/net/ice/base/ice_fdir.h       |  20 ++-
> >  drivers/net/ice/base/ice_flex_pipe.c  |   5 +-
> >  drivers/net/ice/base/ice_flow.c       |  51 ++++++-
> >  drivers/net/ice/base/ice_flow.h       |   9 +-
> >  drivers/net/ice/base/ice_type.h       |  24 +++-
> >  drivers/net/ice/base/ice_vlan_mode.c  |  97 ++++++++++++--
> >  drivers/net/ice/base/ice_vlan_mode.h  |   2 +-
> >  14 files changed, 565 insertions(+), 65 deletions(-)
> >
> > --
> > 2.26.2
> 
> Acked-by: Qiming Yang <qiming.yang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
  

On 4/29/2021 1:41 AM, Qi Zhang wrote:
> Add IP fragment support in base code and couple QinQ improvement.
> update the release date as the last base patch for DPDK 21.05.
> 
> Qi Zhang (6):
>   net/ice/base: add IP fragment flags
>   net/ice/base: add function for post DDP download VLAN mode
>     configuration
>   net/ice/base: add print if DDP/FW don't support QinQ as expected
>   net/ice/base: modififcation to support L3 DSCP QoS
>   net/ice/base: signed External Device Package Programming
>   net/ice/base: support IP fragment RSS and FDIR
> 

Hi Qi,

Patch by patch build fails, can you please check it?

Also some of the above patches title doesn't match to our convention, plus there
is a checkpatch warning, can you please fix them too?

And in 4/6, the message logs are too long, yes we allow long lines instead of
breaking them, this is to help searching log in the code, but those lines are
~150 chars and I think makes harder to read the code, what do you think indent
the message and break in the sentences boundary, something like:
"
ice_info(hw
	"QinQ functionality cannot be enabled on this device. "
        "Update your DDP package and NVM to versions that support QinQ.\n");
"
  

> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Friday, April 30, 2021 7:57 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 0/6] net/ice: base update update batch 3.
> 
> On 4/29/2021 1:41 AM, Qi Zhang wrote:
> > Add IP fragment support in base code and couple QinQ improvement.
> > update the release date as the last base patch for DPDK 21.05.
> >
> > Qi Zhang (6):
> >   net/ice/base: add IP fragment flags
> >   net/ice/base: add function for post DDP download VLAN mode
> >     configuration
> >   net/ice/base: add print if DDP/FW don't support QinQ as expected
> >   net/ice/base: modififcation to support L3 DSCP QoS
> >   net/ice/base: signed External Device Package Programming
> >   net/ice/base: support IP fragment RSS and FDIR
> >
> 
> Hi Qi,
> 
> Patch by patch build fails, can you please check it?
> 
> Also some of the above patches title doesn't match to our convention, plus
> there is a checkpatch warning, can you please fix them too?
> 
> And in 4/6, the message logs are too long, yes we allow long lines instead of
> breaking them, this is to help searching log in the code, but those lines are
> ~150 chars and I think makes harder to read the code, what do you think
> indent the message and break in the sentences boundary, something like:
> "
> ice_info(hw
> 	"QinQ functionality cannot be enabled on this device. "
>         "Update your DDP package and NVM to versions that support
> QinQ.\n"); "

Thanks for the capture, all issue fixed in v2.