diff mbox series

config/arm: restore support for Qualcomm servers

Message ID 20210428160807.17191-1-thierry.herbelot@6wind.com (mailing list archive)
State Superseded, archived
Delegated to: David Marchand
Headers
Series config/arm: restore support for Qualcomm servers |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/github-robot success github build: passed
ci/iol-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

Thierry Herbelot April 28, 2021, 4:08 p.m. UTC 
  Like for other Arm chips, the 'soc' entry is also needed.

Fixes: fddbe822c3eb ("config/arm: add Qualcomm")

Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
---
 config/arm/meson.build | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Thomas Monjalon April 28, 2021, 5:47 p.m. UTC | #1 
28/04/2021 18:08, Thierry Herbelot:
> Like for other Arm chips, the 'soc' entry is also needed.
> 
> Fixes: fddbe822c3eb ("config/arm: add Qualcomm")
> 
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>

Is there any testing of this platform?
Honnappa Nagarahalli April 28, 2021, 6:21 p.m. UTC | #2 
<snip>

> Subject: Re: [PATCH] config/arm: restore support for Qualcomm servers
> 
> 28/04/2021 18:08, Thierry Herbelot:
> > Like for other Arm chips, the 'soc' entry is also needed.
> >
> > Fixes: fddbe822c3eb ("config/arm: add Qualcomm")
> >
> > Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> 
> Is there any testing of this platform?
I do run DPDK on this platform. I think we should support it for some more time.

>
Thierry Herbelot April 28, 2021, 6:26 p.m. UTC | #3 
On 4/28/21 8:21 PM, Honnappa Nagarahalli wrote:
> <snip>
> 
>> Subject: Re: [PATCH] config/arm: restore support for Qualcomm servers
>>
>> 28/04/2021 18:08, Thierry Herbelot:
>>> Like for other Arm chips, the 'soc' entry is also needed.
>>>
>>> Fixes: fddbe822c3eb ("config/arm: add Qualcomm")
>>>
>>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
>>
>> Is there any testing of this platform?
> I do run DPDK on this platform. I think we should support it for some more time.

We also run DPDK on these machines.

	Thierry
David Marchand April 29, 2021, 7:09 a.m. UTC | #4 
On Wed, Apr 28, 2021 at 6:09 PM Thierry Herbelot
<thierry.herbelot@6wind.com> wrote:
>
> Like for other Arm chips, the 'soc' entry is also needed.

Please spare some time to explain the reason why it is needed.


>
> Fixes: fddbe822c3eb ("config/arm: add Qualcomm")

This is not the right Fixes: line, since the soc notion in config/arm/
is fairly recent.
Probably:
Fixes: f2340c858046 ("config/arm: add platform config option")


We have a list of supported socs in
doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst.
It is already out of sync, I sent a fix for this.
For now, please add this soc in the documentation.
diff mbox series

Patch

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 22cd81319c06..83df190343b1 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -298,6 +298,13 @@  soc_octeontx2 = {
     'numa': false
 }
 
+soc_qualcomm = {
+    'description': 'Qualcomm',
+    'implementer': '0x51',
+    'part_number': '0xc00',
+    'numa': false
+}
+
 soc_stingray = {
     'description': 'Broadcom Stingray',
     'implementer': '0x41',
@@ -334,6 +341,7 @@  socs = {
     'n1sdp': soc_n1sdp,
     'n2': soc_n2,
     'octeontx2': soc_octeontx2,
+    'qualcomm': soc_qualcomm,
     'stingray': soc_stingray,
     'thunderx2': soc_thunderx2,
     'thunderxt88': soc_thunderxt88