[v3,4/6] app/testpmd: add device event stubs on Windows
Checks
Commit Message
Add hot_plug related device event stubs in eal_dev.c on Windows.
Signed-off-by: Jie Zhou <jizh@microsoft.com>
Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
---
lib/librte_eal/windows/eal_dev.c | 35 ++++++++++++++++++++++++++++++
lib/librte_eal/windows/meson.build | 1 +
2 files changed, 36 insertions(+)
create mode 100644 lib/librte_eal/windows/eal_dev.c
Comments
Commit topic is incorrect, suggesting "eal/windows: add device event stubs".
2021-04-13 10:19 (UTC-0700), Jie Zhou:
> Add hot_plug related device event stubs in eal_dev.c on Windows.
>
> Signed-off-by: Jie Zhou <jizh@microsoft.com>
> Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> ---
> lib/librte_eal/windows/eal_dev.c | 35 ++++++++++++++++++++++++++++++
> lib/librte_eal/windows/meson.build | 1 +
> 2 files changed, 36 insertions(+)
> create mode 100644 lib/librte_eal/windows/eal_dev.c
>
> diff --git a/lib/librte_eal/windows/eal_dev.c b/lib/librte_eal/windows/eal_dev.c
> new file mode 100644
> index 000000000..4c51d07df
> --- /dev/null
> +++ b/lib/librte_eal/windows/eal_dev.c
> @@ -0,0 +1,35 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2018 Intel Corporation
2018 Intel?
> + */
> +
> +#include <rte_log.h>
> +#include <rte_compat.h>
Not needed.
[...]
On Tue, Apr 13, 2021 at 11:10:38PM +0300, Dmitry Kozlyuk wrote:
> Commit topic is incorrect, suggesting "eal/windows: add device event stubs".
>
> 2021-04-13 10:19 (UTC-0700), Jie Zhou:
> > Add hot_plug related device event stubs in eal_dev.c on Windows.
> >
> > Signed-off-by: Jie Zhou <jizh@microsoft.com>
> > Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> > ---
> > lib/librte_eal/windows/eal_dev.c | 35 ++++++++++++++++++++++++++++++
> > lib/librte_eal/windows/meson.build | 1 +
> > 2 files changed, 36 insertions(+)
> > create mode 100644 lib/librte_eal/windows/eal_dev.c
> >
> > diff --git a/lib/librte_eal/windows/eal_dev.c b/lib/librte_eal/windows/eal_dev.c
> > new file mode 100644
> > index 000000000..4c51d07df
> > --- /dev/null
> > +++ b/lib/librte_eal/windows/eal_dev.c
> > @@ -0,0 +1,35 @@
> > +/* SPDX-License-Identifier: BSD-3-Clause
> > + * Copyright(c) 2018 Intel Corporation
>
> 2018 Intel?
>
> > + */
> > +
> > +#include <rte_log.h>
> > +#include <rte_compat.h>
>
> Not needed.
>
> [...]
Thanks Dmitry. Will fix all in V4.
new file mode 100644
@@ -0,0 +1,35 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Intel Corporation
+ */
+
+#include <rte_log.h>
+#include <rte_compat.h>
+#include <rte_dev.h>
+
+int
+rte_dev_event_monitor_start(void)
+{
+ RTE_LOG(ERR, EAL, "Device event is not supported for Windows\n");
+ return -1;
+}
+
+int
+rte_dev_event_monitor_stop(void)
+{
+ RTE_LOG(ERR, EAL, "Device event is not supported for Windows\n");
+ return -1;
+}
+
+int
+rte_dev_hotplug_handle_enable(void)
+{
+ RTE_LOG(ERR, EAL, "Device event is not supported for Windows\n");
+ return -1;
+}
+
+int
+rte_dev_hotplug_handle_disable(void)
+{
+ RTE_LOG(ERR, EAL, "Device event is not supported for Windows\n");
+ return -1;
+}
@@ -7,6 +7,7 @@ sources += files(
'eal.c',
'eal_alarm.c',
'eal_debug.c',
+ 'eal_dev.c',
'eal_file.c',
'eal_hugepages.c',
'eal_interrupts.c',