[v2] examples/packet_ordering: use local port config
Checks
Commit Message
From: Dapeng Yu <dapengx.yu@intel.com>
A global ethernet port configuration is assigned to local variable
because in this way the local variable may be updated as required. But
this local variable is not used as input of rte_eth_dev_configure() in
original implementation, and cause that fast mbuf free feature cannot
be enabled on port.
This patch use this local variable as input of rte_eth_dev_configure().
Fixes: 6833f919f56b ("examples/packet_ordering: convert to new ethdev offloads API")
Cc: shahafs@mellanox.com
Cc: stable@dpdk.org
Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
Acked-by: Reshma Pattan <reshma.pattan@intel.com>
---
v2:
* Add Cc:<original author> and Acked-by:<maintainer>
examples/packet_ordering/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
19/03/2021 08:11, dapengx.yu@intel.com:
> From: Dapeng Yu <dapengx.yu@intel.com>
>
> A global ethernet port configuration is assigned to local variable
> because in this way the local variable may be updated as required. But
> this local variable is not used as input of rte_eth_dev_configure() in
> original implementation, and cause that fast mbuf free feature cannot
> be enabled on port.
>
> This patch use this local variable as input of rte_eth_dev_configure().
>
> Fixes: 6833f919f56b ("examples/packet_ordering: convert to new ethdev offloads API")
> Cc: shahafs@mellanox.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
> Acked-by: Reshma Pattan <reshma.pattan@intel.com>
Applied, thanks
@@ -290,7 +290,7 @@ configure_eth_port(uint16_t port_id)
if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
port_conf.txmode.offloads |=
DEV_TX_OFFLOAD_MBUF_FAST_FREE;
- ret = rte_eth_dev_configure(port_id, rxRings, txRings, &port_conf_default);
+ ret = rte_eth_dev_configure(port_id, rxRings, txRings, &port_conf);
if (ret != 0)
return ret;