diff mbox series

[v2] dpdk-kmods: nvme support for netuio on Windows

Message ID 20210223173508.1200-1-nick.connolly@mayadata.io (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v2] dpdk-kmods: nvme support for netuio on Windows |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply issues

Commit Message

Nick Connolly Feb. 23, 2021, 5:35 p.m. UTC 
  Enable the netuio driver for an NVMe storage controller on Windows.
Add the class ID 010802 and identify the device as
 'netuio NVM Express Controller'.

Signed-off-by: Nick Connolly <nick.connolly@mayadata.io>
---
v2:
* rebase to latest netuio.inf

 windows/netuio/netuio.inf | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Monjalon March 17, 2021, 9:41 a.m. UTC | #1 
23/02/2021 18:35, Nick Connolly:
> Enable the netuio driver for an NVMe storage controller on Windows.
> Add the class ID 010802 and identify the device as
>  'netuio NVM Express Controller'.
> 
> Signed-off-by: Nick Connolly <nick.connolly@mayadata.io>

I don't understand why there is no review.

Applied, thanks.
Nick Connolly March 17, 2021, 9:46 a.m. UTC | #2 
Hi Thomas,

> I don't understand why there is no review.
>
> Applied, thanks.

Reviewed by the team at Microsoft who were happy, but looks like a 
formal 'Acked-by' didn't get sent.

Thanks,
Nick
Thomas Monjalon March 17, 2021, 10:06 a.m. UTC | #3 
17/03/2021 10:46, Nick Connolly:
> Hi Thomas,
> 
> > I don't understand why there is no review.
> >
> > Applied, thanks.
> 
> Reviewed by the team at Microsoft who were happy, but looks like a 
> formal 'Acked-by' didn't get sent.

To everybody working on Windows DPDK:
It is good to have meetings, but please avoid private discussions,
and do not forget the public communications.
It will make the community work smoother, thanks.
diff mbox series

Patch

diff --git a/windows/netuio/netuio.inf b/windows/netuio/netuio.inf
index 666a69c..64872de 100644
--- a/windows/netuio/netuio.inf
+++ b/windows/netuio/netuio.inf
@@ -28,6 +28,7 @@  HKR,,Icon,,-5
 
 [Standard.NT$ARCH$]
 %netuio.DeviceDesc%=netuio_Device, Root\netuio
+%netuio.nvme.DeviceDesc%=netuio_Device, PCI\CC_010802
 %Intel.F1572.Description%=netuio_Device, PCI\VEN_8086&DEV_1572
 %Intel.F1580.Description%=netuio_Device, PCI\VEN_8086&DEV_1580
 %Intel.F1581.Description%=netuio_Device, PCI\VEN_8086&DEV_1581
@@ -85,6 +86,7 @@  Provider = "Vendor"
 ClassName = "Windows UIO"
 DiskName = "DPDK netUIO Installation Disk"
 netuio.DeviceDesc = "netuio Device"
+netuio.nvme.DeviceDesc = "netuio NVM Express Controller"
 Intel.F1572.Description = "Intel(R) Ethernet Controller X710 for 10GbE SFP+"
 Intel.F1580.Description = "Intel(R) Ethernet Controller XL710 for 40GbE backplane"
 Intel.F1581.Description = "Intel(R) Ethernet Controller X710 for 10GbE backplane"