[2/4] telemetry: make the legacy registration function internal
Checks
Commit Message
The function for registration of callbacks for legacy telemetry was
documented as internal-only in the API documents, but marked as
experimental in the version.map file. Since this is an internal-only
function, for consistency we update the version mapping to have it as
internal.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
doc/guides/rel_notes/release_21_05.rst | 5 +++++
lib/librte_telemetry/rte_telemetry_legacy.h | 2 +-
lib/librte_telemetry/version.map | 2 +-
3 files changed, 7 insertions(+), 2 deletions(-)
Comments
>-----Original Message-----
>From: dev <dev-bounces@dpdk.org> On Behalf Of Bruce Richardson
>Sent: Wednesday 10 March 2021 17:24
>To: dev@dpdk.org
>Cc: Richardson, Bruce <bruce.richardson@intel.com>; Laatz, Kevin
><kevin.laatz@intel.com>; Ray Kinsella <mdr@ashroe.eu>; Neil Horman
><nhorman@tuxdriver.com>
>Subject: [dpdk-dev] [PATCH 2/4] telemetry: make the legacy registration
>function internal
>
>The function for registration of callbacks for legacy telemetry was
>documented as internal-only in the API documents, but marked as
>experimental in the version.map file. Since this is an internal-only function, for
>consistency we update the version mapping to have it as internal.
>
>Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>---
> doc/guides/rel_notes/release_21_05.rst | 5 +++++
> lib/librte_telemetry/rte_telemetry_legacy.h | 2 +-
> lib/librte_telemetry/version.map | 2 +-
> 3 files changed, 7 insertions(+), 2 deletions(-)
>
<snip>
Acked-by: Ciara Power <ciara.power@intel.com>
@@ -117,6 +117,11 @@ ABI Changes
* No ABI change that would break compatibility with 20.11.
+* The experimental function ``rte_telemetry_legacy_register`` has been
+ removed from the public API and is now an internal-only function. This
+ function was already marked as internal in the API documentation for it,
+ and was not for use by external applications.
+
Known Issues
------------
@@ -78,7 +78,7 @@ legacy_client_handler(void *sock_id);
* @return
* -ENOENT if max callbacks limit has been reached.
*/
-__rte_experimental
+__rte_internal
int
rte_telemetry_legacy_register(const char *cmd,
enum rte_telemetry_legacy_data_req data_req,
@@ -14,12 +14,12 @@ EXPERIMENTAL {
rte_tel_data_start_array;
rte_tel_data_start_dict;
rte_tel_data_string;
- rte_telemetry_legacy_register;
rte_telemetry_register_cmd;
local: *;
};
INTERNAL {
+ rte_telemetry_legacy_register;
rte_telemetry_init;
};