mbox series

[0/8] ether: refine debug compile option

Message ID 20210310121626.2019863-1-qi.z.zhang@intel.com (mailing list archive)
Headers
Series ether: refine debug compile option |

Message

Qi Zhang March 10, 2021, 12:16 p.m. UTC 
  PMDs use RTE_LIBRTE_<PMD_NAME>_DEBUG_RX|TX as compile option to wrap
data path debug code. As .config has been removed since the meson build,
It is not friendly for new DPDK users to notice those debug options.

Patch 1/8: introduces new compile options for specific Rx/Tx data path
debug in ether layer, so PMD can choose to reuse them to avoid maintain
their own.

- RTE_LIBRTE_ETHDEV_DEBUG_RX
- RTE_LIBRTE_ETHDEV_DEBUG_TX

Patch 2/8 - 8/8: refine all the compile option for Intel PMDs.

Qi Zhang (8):
  ether: refine debug compile option
  net/fm10k: refine debug compile option
  net/e1000: refine debug compile option
  net/i40e: refine debug compile option
  net/iavf: refine debug compile option
  net/ice: refine debug compile option
  net/ixgbe: refine debug compile option
  net/igc: refine debug compile option

 doc/guides/nics/overview.rst     | 20 ++++++++++
 drivers/net/e1000/e1000_logs.c   | 17 ++-------
 drivers/net/e1000/e1000_logs.h   | 13 +------
 drivers/net/e1000/em_rxtx.c      | 38 +++++++++----------
 drivers/net/e1000/igb_rxtx.c     |  2 +-
 drivers/net/fm10k/fm10k_ethdev.c |  7 +---
 drivers/net/fm10k/fm10k_logs.h   | 13 +------
 drivers/net/fm10k/fm10k_rxtx.c   |  8 ++--
 drivers/net/i40e/i40e_ethdev.c   |  7 +---
 drivers/net/i40e/i40e_logs.h     | 13 +------
 drivers/net/i40e/i40e_rxtx.c     | 16 ++++----
 drivers/net/iavf/iavf_ethdev.c   |  7 +---
 drivers/net/iavf/iavf_log.h      | 13 +------
 drivers/net/iavf/iavf_rxtx.c     |  8 ++--
 drivers/net/ice/ice_ethdev.c     |  7 +---
 drivers/net/ice/ice_logs.h       | 13 +------
 drivers/net/ice/ice_rxtx.c       | 20 +++++-----
 drivers/net/igc/igc_logs.h       |  4 +-
 drivers/net/igc/igc_txrx.c       |  2 +-
 drivers/net/ixgbe/ixgbe_ethdev.c |  7 +---
 drivers/net/ixgbe/ixgbe_logs.h   | 13 +------
 drivers/net/ixgbe/ixgbe_rxtx.c   | 64 ++++++++++++++++----------------
 lib/librte_ethdev/rte_ethdev.h   | 16 ++++----
 23 files changed, 135 insertions(+), 193 deletions(-)

Comments

Ferruh Yigit March 10, 2021, 12:35 p.m. UTC | #1 
On 3/10/2021 12:16 PM, Qi Zhang wrote:
> PMDs use RTE_LIBRTE_<PMD_NAME>_DEBUG_RX|TX as compile option to wrap
> data path debug code. As .config has been removed since the meson build,
> It is not friendly for new DPDK users to notice those debug options.
> 
> Patch 1/8: introduces new compile options for specific Rx/Tx data path
> debug in ether layer, so PMD can choose to reuse them to avoid maintain
> their own.
> 
> - RTE_LIBRTE_ETHDEV_DEBUG_RX
> - RTE_LIBRTE_ETHDEV_DEBUG_TX
> 

+1 to have common flag and documentation

> Patch 2/8 - 8/8: refine all the compile option for Intel PMDs.
> 
> Qi Zhang (8):
>    ether: refine debug compile option
>    net/fm10k: refine debug compile option
>    net/e1000: refine debug compile option
>    net/i40e: refine debug compile option
>    net/iavf: refine debug compile option
>    net/ice: refine debug compile option
>    net/ixgbe: refine debug compile option
>    net/igc: refine debug compile option

<...>