[v2] app/testpmd: add support for forced ethernet speed
Checks
Commit Message
Add support for forced ethernet speed setting.
Currently testpmd tries to configure the Ethernet port in autoneg mode.
It is not possible to set the Ethernet port to a specific speed while
starting testpmd. In some cases capability to configure a forced speed
for the Ethernet port during initialization may be necessary. This patch
tries to add this support.
The patch assumes full duplex setting and does not attempt to change that.
So speeds like 10M, 100M are not configurable using this method.
The command line to configure a forced speed of 10G:
dpdk-testpmd -c 0xff -- -i --eth-link-speed 10000
The command line to configure a forced speed of 50G:
dpdk-testpmd -c 0xff -- -i --eth-link-speed 50000
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
----
v1->v2:
- Updated the release notes to document the new parameter.
- Updated the user guide to indicate 10 and 100 Mbps are not supported.
- Check and return error if 10 or 100Mbps speeds are requested.
- Set ETH_LINK_SPEED_FIXED when requesting forced link speed.
- Updated code based on other review comments.
Please apply.
---
app/test-pmd/parameters.c | 44 ++++++++++++++++++++++++++
app/test-pmd/testpmd.c | 8 +++++
app/test-pmd/testpmd.h | 1 +
doc/guides/rel_notes/release_21_05.rst | 3 ++
doc/guides/testpmd_app_ug/run_app.rst | 16 ++++++++++
5 files changed, 72 insertions(+)
Comments
On 3/5/2021 4:17 AM, Ajit Khaparde wrote:
> Add support for forced ethernet speed setting.
> Currently testpmd tries to configure the Ethernet port in autoneg mode.
> It is not possible to set the Ethernet port to a specific speed while
> starting testpmd. In some cases capability to configure a forced speed
> for the Ethernet port during initialization may be necessary. This patch
> tries to add this support.
>
> The patch assumes full duplex setting and does not attempt to change that.
> So speeds like 10M, 100M are not configurable using this method.
>
> The command line to configure a forced speed of 10G:
> dpdk-testpmd -c 0xff -- -i --eth-link-speed 10000
>
> The command line to configure a forced speed of 50G:
> dpdk-testpmd -c 0xff -- -i --eth-link-speed 50000
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
<...>
> @@ -536,3 +536,19 @@ The command line options are:
> bit 1 - two hairpin ports paired
> bit 0 - two hairpin ports loop
> The default value is 0. Hairpin will use single port mode and implicit Tx flow mode.
> +
> +* ``--eth-link-speed``
> +
> + Set a forced link speed to the ethernet port.
> + 1000 - 1Gbps
> + 10000 - 10Gbps
> + 25000 - 25Gbps
> + 40000 - 40Gbps
> + 50000 - 50Gbps
> + 100000 - 100Gbps
> + 200000 - 200Gbps
> + ...
> +
Line breaks are lost when converted to html, it becomes single line, '::' and
indentation is required.
Except from documentation, looks good to me.
@@ -224,6 +224,7 @@ usage(char* progname)
printf(" --hairpin-mode=0xXX: bitmask set the hairpin port mode.\n "
" 0x10 - explicit Tx rule, 0x02 - hairpin ports paired\n"
" 0x01 - hairpin ports loop, 0x00 - hairpin port self\n");
+ printf(" --eth-link-speed: forced link speed.\n");
}
#ifdef RTE_LIB_CMDLINE
@@ -485,6 +486,43 @@ parse_event_printing_config(const char *optarg, int enable)
return 0;
}
+static int
+parse_link_speed(int n)
+{
+ uint32_t speed = ETH_LINK_SPEED_FIXED;
+
+ switch (n) {
+ case 1000:
+ speed |= ETH_LINK_SPEED_1G;
+ break;
+ case 10000:
+ speed |= ETH_LINK_SPEED_10G;
+ break;
+ case 25000:
+ speed |= ETH_LINK_SPEED_25G;
+ break;
+ case 40000:
+ speed |= ETH_LINK_SPEED_40G;
+ break;
+ case 50000:
+ speed |= ETH_LINK_SPEED_50G;
+ break;
+ case 100000:
+ speed |= ETH_LINK_SPEED_100G;
+ break;
+ case 200000:
+ speed |= ETH_LINK_SPEED_200G;
+ break;
+ case 100:
+ case 10:
+ default:
+ printf("Unsupported fixed speed\n");
+ return 0;
+ }
+
+ return speed;
+}
+
void
launch_args_parse(int argc, char** argv)
{
@@ -605,6 +643,7 @@ launch_args_parse(int argc, char** argv)
{ "rx-mq-mode", 1, 0, 0 },
{ "record-core-cycles", 0, 0, 0 },
{ "record-burst-stats", 0, 0, 0 },
+ { "eth-link-speed", 1, 0, 0 },
{ 0, 0, 0, 0 },
};
@@ -1366,6 +1405,11 @@ launch_args_parse(int argc, char** argv)
record_core_cycles = 1;
if (!strcmp(lgopts[opt_idx].name, "record-burst-stats"))
record_burst_stats = 1;
+ if (!strcmp(lgopts[opt_idx].name, "eth-link-speed")) {
+ n = atoi(optarg);
+ if (n >= 0 && parse_link_speed(n) > 0)
+ eth_link_speed = parse_link_speed(n);
+ }
break;
case 'h':
usage(argv[0]);
@@ -513,6 +513,11 @@ uint8_t gro_flush_cycles = GRO_DEFAULT_FLUSH_CYCLES;
*/
enum rte_eth_rx_mq_mode rx_mq_mode = ETH_MQ_RX_VMDQ_DCB_RSS;
+/*
+ * Used to set forced link speed
+ */
+uint32_t eth_link_speed;
+
/* Forward function declarations */
static void setup_attached_port(portid_t pi);
static void check_all_ports_link_status(uint32_t port_mask);
@@ -1484,6 +1489,9 @@ init_config(void)
port->tx_conf[k].offloads =
port->dev_conf.txmode.offloads;
+ if (eth_link_speed)
+ port->dev_conf.link_speeds = eth_link_speed;
+
/* set flag to initialize port/queue */
port->need_reconfig = 1;
port->need_reconfig_queues = 1;
@@ -353,6 +353,7 @@ extern bool setup_on_probe_event; /**< disabled by port setup-on iterator */
extern uint8_t hot_plug; /**< enable by "--hot-plug" parameter */
extern int do_mlockall; /**< set by "--mlockall" or "--no-mlockall" parameter */
extern uint8_t clear_ptypes; /**< disabled by set ptype cmd */
+extern uint32_t eth_link_speed;
#ifdef RTE_LIBRTE_IXGBE_BYPASS
extern uint32_t bypass_timeout; /**< Store the NIC bypass watchdog timeout */
@@ -64,6 +64,9 @@ New Features
* Added command to display Rx queue used descriptor count.
``show port (port_id) rxq (queue_id) desc used count``
+ * Added a command line option to configure forced speed for Ethernet port.
+ ``dpdk-testpmd -c 0xff -- -i --eth-link-speed N``
+
Removed Items
-------------
@@ -536,3 +536,19 @@ The command line options are:
bit 1 - two hairpin ports paired
bit 0 - two hairpin ports loop
The default value is 0. Hairpin will use single port mode and implicit Tx flow mode.
+
+* ``--eth-link-speed``
+
+ Set a forced link speed to the ethernet port.
+ 1000 - 1Gbps
+ 10000 - 10Gbps
+ 25000 - 25Gbps
+ 40000 - 40Gbps
+ 50000 - 50Gbps
+ 100000 - 100Gbps
+ 200000 - 200Gbps
+ ...
+
+.. Note::
+
+ Setting 10Mbps and 100Mbps speeds is not supported.