diff mbox series

[3/4] net/ice: disable ice DDP package on Windows

Message ID 20210303215929.5616-4-pallavi.kadam@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series Support ice PMD on Windows |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Kadam, Pallavi March 3, 2021, 9:59 p.m. UTC 
  Disable loading of private DDP packages in ice PMD on Windows.

Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
---
 drivers/net/ice/ice_ethdev.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Dmitry Kozlyuk March 3, 2021, 11:12 p.m. UTC | #1 
2021-03-03 13:59, Pallavi Kadam:
> Disable loading of private DDP packages in ice PMD on Windows.
> 
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> ---
>  drivers/net/ice/ice_ethdev.c | 6 ++++++
>  1 file changed, 6 insertions(+)

Are DDP packages unavailable on Windows or is their loading disabled because
reading from PCI config space is not implemented by netuio? In the former
case, please document the reason in commit (and probably in used guide?).
In the latter case, could you instead fix rte_pci_config_read() to return (-1)
on Windows, so that DDP loading automatically fails at reading capabilities?
This would ensure ICE PMD remains portable by compiling all of its code in
every platform.
Kadam, Pallavi March 5, 2021, 12:31 a.m. UTC | #2 
Hi Dmitry,

On 3/3/2021 3:12 PM, Dmitry Kozlyuk wrote:
> 2021-03-03 13:59, Pallavi Kadam:
>> Disable loading of private DDP packages in ice PMD on Windows.
>>
>> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
>> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
>> ---
>>   drivers/net/ice/ice_ethdev.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
> Are DDP packages unavailable on Windows or is their loading disabled because
> reading from PCI config space is not implemented by netuio? In the former
> case, please document the reason in commit (and probably in used guide?).
> In the latter case, could you instead fix rte_pci_config_read() to return (-1)
> on Windows, so that DDP loading automatically fails at reading capabilities?
> This would ensure ICE PMD remains portable by compiling all of its code in
> every platform.

Yes, loading of external DDP package is not supported on Windows.

Will update the commit message and the ice user guide accordingly in v2.
diff mbox series

Patch

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index d22bc92ff..1f5f16d42 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -1652,6 +1652,7 @@  ice_pf_setup(struct ice_pf *pf)
  * Extract device serial number from PCIe Configuration Space and
  * determine the pkg file path according to the DSN.
  */
+#ifndef RTE_EXEC_ENV_WINDOWS
 static int
 ice_pkg_file_search_path(struct rte_pci_device *pci_dev, char *pkg_file)
 {
@@ -1689,6 +1690,7 @@  ice_pkg_file_search_path(struct rte_pci_device *pci_dev, char *pkg_file)
 	strncpy(pkg_file, ICE_PKG_FILE_DEFAULT, ICE_MAX_PKG_FILENAME_SIZE);
 	return 0;
 }
+#endif
 
 enum ice_pkg_type
 ice_load_pkg_type(struct ice_hw *hw)
@@ -1714,6 +1716,7 @@  ice_load_pkg_type(struct ice_hw *hw)
 	return package_type;
 }
 
+#ifndef RTE_EXEC_ENV_WINDOWS
 static int ice_load_pkg(struct rte_eth_dev *dev)
 {
 	struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
@@ -1785,6 +1788,7 @@  static int ice_load_pkg(struct rte_eth_dev *dev)
 	rte_free(buf);
 	return err;
 }
+#endif
 
 static void
 ice_base_queue_get(struct ice_pf *pf)
@@ -2065,6 +2069,7 @@  ice_dev_init(struct rte_eth_dev *dev)
 		return -EINVAL;
 	}
 
+#ifndef RTE_EXEC_ENV_WINDOWS
 	ret = ice_load_pkg(dev);
 	if (ret) {
 		if (ad->devargs.safe_mode_support == 0) {
@@ -2077,6 +2082,7 @@  ice_dev_init(struct rte_eth_dev *dev)
 					"Entering Safe Mode");
 		ad->is_safe_mode = 1;
 	}
+#endif
 
 	PMD_INIT_LOG(INFO, "FW %d.%d.%05d API %d.%d",
 		     hw->fw_maj_ver, hw->fw_min_ver, hw->fw_build,