diff mbox series

testpmd: remove unused member from lcore structure

Message ID 20210205190823.7765-1-kathleen.capella@arm.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series testpmd: remove unused member from lcore structure |

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/travis-robot warning Travis build: failed
ci/iol-testing warning Testing issues
ci/checkpatch success coding style OK

Commit Message

Kathleen Capella Feb. 5, 2021, 7:08 p.m. UTC 
  The tx_queue member of the fwd_lcore struct is unused as it is already
part of the fwd_stream structure. Deleting helps improve code readability.

Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
---
 app/test-pmd/testpmd.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Thomas Monjalon Feb. 5, 2021, 8:11 p.m. UTC | #1 
About the title:
	- the prefix should be app/testpmd
	- it is not exactly an lcore structure
I would propose: app/testpmd: remove unused struct member

05/02/2021 20:08, Kathleen Capella:
> The tx_queue member of the fwd_lcore struct is unused as it is already
> part of the fwd_stream structure. Deleting helps improve code readability.
> 
> Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>
Thanks for looking at cleaning up.
diff mbox series

Patch

diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index 5f2316210..f805f1b4d 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -247,7 +247,6 @@  struct fwd_lcore {
 	streamid_t stream_idx;   /**< index of 1st stream in "fwd_streams" */
 	streamid_t stream_nb;    /**< number of streams in "fwd_streams" */
 	lcoreid_t  cpuid_idx;    /**< index of logical core in CPU id table */
-	queueid_t  tx_queue;     /**< TX queue to send forwarded packets */
 	volatile char stopped;   /**< stop forwarding when set */
 };