[v1,16/20] net/txgbe: add some supports as PF driver implemented

Message ID 20210122094800.197748-17-jiawenwu@trustnetic.com (mailing list archive)
State Changes Requested, archived
Delegated to: Ferruh Yigit
Headers
Series net/txgbe: add VF driver support |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Jiawen Wu Jan. 22, 2021, 9:47 a.m. UTC
  Some RXTX operations like queue setup and release, packet type get, and
Tx done cleanup have been supported on PF device. There are ops
functions directly added.

Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
 doc/guides/nics/features/txgbe_vf.ini | 1 +
 drivers/net/txgbe/txgbe_ethdev_vf.c   | 6 ++++++
 2 files changed, 7 insertions(+)
  

Comments

Ferruh Yigit Feb. 2, 2021, 5:50 p.m. UTC | #1
On 1/22/2021 9:47 AM, Jiawen Wu wrote:
> Some RXTX operations like queue setup and release, packet type get, and
> Tx done cleanup have been supported on PF device. There are ops
> functions directly added.
> 
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>

<...>

> @@ -1375,6 +1380,7 @@ static const struct eth_dev_ops txgbevf_eth_dev_ops = {
>   	.reta_query           = txgbe_dev_rss_reta_query,
>   	.rss_hash_update      = txgbe_dev_rss_hash_update,
>   	.rss_hash_conf_get    = txgbe_dev_rss_hash_conf_get,
> +	.tx_done_cleanup      = txgbe_dev_tx_done_cleanup,

Can you please add "Free Tx mbuf on demand" feature to the .ini file with this 
dev_ops.
  

Patch

diff --git a/doc/guides/nics/features/txgbe_vf.ini b/doc/guides/nics/features/txgbe_vf.ini
index 3d4b69d51..4cd010f96 100644
--- a/doc/guides/nics/features/txgbe_vf.ini
+++ b/doc/guides/nics/features/txgbe_vf.ini
@@ -18,6 +18,7 @@  RSS hash             = Y
 RSS key update       = Y
 RSS reta update      = Y
 VLAN filter          = Y
+Inline crypto        = Y
 CRC offload          = P
 VLAN offload         = P
 QinQ offload         = P
diff --git a/drivers/net/txgbe/txgbe_ethdev_vf.c b/drivers/net/txgbe/txgbe_ethdev_vf.c
index 1ae221167..5a9f4294d 100644
--- a/drivers/net/txgbe/txgbe_ethdev_vf.c
+++ b/drivers/net/txgbe/txgbe_ethdev_vf.c
@@ -1358,10 +1358,15 @@  static const struct eth_dev_ops txgbevf_eth_dev_ops = {
 	.allmulticast_enable  = txgbevf_dev_allmulticast_enable,
 	.allmulticast_disable = txgbevf_dev_allmulticast_disable,
 	.dev_infos_get        = txgbevf_dev_info_get,
+	.dev_supported_ptypes_get = txgbe_dev_supported_ptypes_get,
 	.mtu_set              = txgbevf_dev_set_mtu,
 	.vlan_filter_set      = txgbevf_vlan_filter_set,
 	.vlan_strip_queue_set = txgbevf_vlan_strip_queue_set,
 	.vlan_offload_set     = txgbevf_vlan_offload_set,
+	.rx_queue_setup       = txgbe_dev_rx_queue_setup,
+	.rx_queue_release     = txgbe_dev_rx_queue_release,
+	.tx_queue_setup       = txgbe_dev_tx_queue_setup,
+	.tx_queue_release     = txgbe_dev_tx_queue_release,
 	.rx_queue_intr_enable = txgbevf_dev_rx_queue_intr_enable,
 	.rx_queue_intr_disable = txgbevf_dev_rx_queue_intr_disable,
 	.mac_addr_add         = txgbevf_add_mac_addr,
@@ -1375,6 +1380,7 @@  static const struct eth_dev_ops txgbevf_eth_dev_ops = {
 	.reta_query           = txgbe_dev_rss_reta_query,
 	.rss_hash_update      = txgbe_dev_rss_hash_update,
 	.rss_hash_conf_get    = txgbe_dev_rss_hash_conf_get,
+	.tx_done_cleanup      = txgbe_dev_tx_done_cleanup,
 };
 
 RTE_PMD_REGISTER_PCI(net_txgbe_vf, rte_txgbevf_pmd);