[v2] config/arm: fix variable name
Checks
Commit Message
A config variable rename seems missed to update all config files and new
config file get with old variable names.
Reflect config variable rename to all config files, changed
'implementor_id' to 'implementer_id',
'implementor_pn' to 'part_number'.
Fixes: 3d01d65ba0d3 ("config: add aarch64 clang for Ubuntu 18.04")
Fixes: 7870ae8994c6 ("config/arm: rename variables")
Reported-by: Thierry Herbelot <thierry.herbelot@6wind.com>
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>
Cc: Ruifeng Wang <ruifeng.wang@arm.com>
Cc: vcchunga@amazon.com
v2:
* Update 'implementor_pn' as 'part_number'
* Fix fixes line
---
config/arm/arm64_armv8_linux_clang_ubuntu1804 | 4 ++--
config/arm/arm64_graviton2_linux_gcc | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
Comments
02/02/2021 09:35, Ferruh Yigit:
> A config variable rename seems missed to update all config files and new
> config file get with old variable names.
>
> Reflect config variable rename to all config files, changed
> 'implementor_id' to 'implementer_id',
> 'implementor_pn' to 'part_number'.
>
> Fixes: 3d01d65ba0d3 ("config: add aarch64 clang for Ubuntu 18.04")
> Fixes: 7870ae8994c6 ("config/arm: rename variables")
>
> Reported-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
Applied, thanks.
That's why I don't want to merge all the Arm build changes
as a batch in the same release.
Sometimes we need to have some steps.
@@ -14,7 +14,7 @@ cpu = 'armv8-a'
endian = 'little'
[properties]
-implementor_id = 'generic'
-implementor_pn = 'default'
+implementer_id = 'generic'
+part_number = 'default'
c_args = ['-target', 'aarch64-linux-gnu', '--sysroot', '/usr/aarch64-linux-gnu']
c_link_args = ['-target', 'aarch64-linux-gnu', '-fuse-ld=lld', '--gcc-toolchain=/usr']
@@ -13,8 +13,8 @@ cpu = 'armv8-a'
endian = 'little'
[properties]
-implementor_id = '0x41'
-implementor_pn = '0xd0c'
+implementer_id = '0x41'
+part_number = '0xd0c'
max_lcores = 64
max_numa_nodes = 1
numa = false