usertools/dpdk-devbind: fix missing device classes
Checks
Commit Message
The "misc" and "regex" device classes were missing from the list used to
check arguments, preventing them from being used with "--status-dev"
flag to list only devices of those types.
When adding them to the list, the list is also sorted alphabetically for
consistency.
Fixes: 81255f27c65c ("usertools: replace optparse with argparse")
Cc: stephen@networkplumber.org
Bugzilla ID: 582
Reported-by: Wei Ling <weix.ling@intel.com>
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
usertools/dpdk-devbind.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On Tue, 24 Nov 2020 09:46:56 +0000
Bruce Richardson <bruce.richardson@intel.com> wrote:
> The "misc" and "regex" device classes were missing from the list used to
> check arguments, preventing them from being used with "--status-dev"
> flag to list only devices of those types.
>
> When adding them to the list, the list is also sorted alphabetically for
> consistency.
>
> Fixes: 81255f27c65c ("usertools: replace optparse with argparse")
> Cc: stephen@networkplumber.org
>
> Bugzilla ID: 582
>
> Reported-by: Wei Ling <weix.ling@intel.com>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Almost the same patch I was sending right now...
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Tested-by: Jiang, YuX <yux.jiang@intel.com>
Best Regards
Jiang yu
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen
> Hemminger
> Sent: Wednesday, November 25, 2020 1:53 AM
> To: Richardson, Bruce <bruce.richardson@intel.com>
> Cc: dev@dpdk.org; Ling, WeiX <weix.ling@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] usertools/dpdk-devbind: fix missing device
> classes
>
> On Tue, 24 Nov 2020 09:46:56 +0000
> Bruce Richardson <bruce.richardson@intel.com> wrote:
>
> > The "misc" and "regex" device classes were missing from the list used
> > to check arguments, preventing them from being used with "--status-dev"
> > flag to list only devices of those types.
> >
> > When adding them to the list, the list is also sorted alphabetically
> > for consistency.
> >
> > Fixes: 81255f27c65c ("usertools: replace optparse with argparse")
> > Cc: stephen@networkplumber.org
> >
> > Bugzilla ID: 582
> >
> > Reported-by: Wei Ling <weix.ling@intel.com>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Almost the same patch I was sending right now...
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
25/11/2020 03:23, Jiang, YuX:
> Tested-by: Jiang, YuX <yux.jiang@intel.com>
Thanks for the test.
Next time, please reply below with this exact line (name):
Tested-by: Yu Jiang <yux.jiang@intel.com>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen
> > Hemminger
> > Sent: Wednesday, November 25, 2020 1:53 AM
> > To: Richardson, Bruce <bruce.richardson@intel.com>
> > Cc: dev@dpdk.org; Ling, WeiX <weix.ling@intel.com>
> > Subject: Re: [dpdk-dev] [PATCH] usertools/dpdk-devbind: fix missing device
> > classes
> >
> > On Tue, 24 Nov 2020 09:46:56 +0000
> > Bruce Richardson <bruce.richardson@intel.com> wrote:
> >
> > > The "misc" and "regex" device classes were missing from the list used
> > > to check arguments, preventing them from being used with "--status-dev"
> > > flag to list only devices of those types.
> > >
> > > When adding them to the list, the list is also sorted alphabetically
> > > for consistency.
> > >
> > > Fixes: 81255f27c65c ("usertools: replace optparse with argparse")
> > > Cc: stephen@networkplumber.org
> > >
> > > Bugzilla ID: 582
> > >
> > > Reported-by: Wei Ling <weix.ling@intel.com>
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> > Almost the same patch I was sending right now...
> >
> > Acked-by: Stephen Hemminger <stephen@networkplumber.org>
>
24/11/2020 18:53, Stephen Hemminger:
> On Tue, 24 Nov 2020 09:46:56 +0000
> Bruce Richardson <bruce.richardson@intel.com> wrote:
>
> > The "misc" and "regex" device classes were missing from the list used to
> > check arguments, preventing them from being used with "--status-dev"
> > flag to list only devices of those types.
> >
> > When adding them to the list, the list is also sorted alphabetically for
> > consistency.
> >
> > Fixes: 81255f27c65c ("usertools: replace optparse with argparse")
> > Cc: stephen@networkplumber.org
> >
> > Bugzilla ID: 582
> >
> > Reported-by: Wei Ling <weix.ling@intel.com>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Almost the same patch I was sending right now...
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Applied, thanks
@@ -634,7 +634,8 @@ def parse_args():
parser.add_argument(
'--status-dev',
help="Print the status of given device group.",
- choices=['net', 'baseband', 'crypto', 'event', 'mempool', 'compress'])
+ choices=['baseband', 'compress', 'crypto', 'event',
+ 'mempool', 'misc', 'net', 'regex'])
bind_group = parser.add_mutually_exclusive_group()
bind_group.add_argument(
'-b',